graesslin added a comment.
Overall looks good! It's way more self contained than I expected when first
thinking about it.
INLINE COMMENTS
> test_helpers.cpp:110-113
> +QObject::connect(®istry, &Registry::outputAnnounced, [&](quint32
> name, quint32 version) {
> +auto output = re
graesslin added a comment.
I'm wondering whether we should do it directly in Toplevel as we also have
the XWayland windows which have a Surface.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7359
To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, Z
Hi team,
I wanted to request if we can include the creation of some simple
animations to the bootup process. Here are the 4 that I am looking to get
implemented:
Collapse/Unfold Users, https://share.kde.org/index.php/s/H7TdSzcOAEbtqXj
Collapse/unfold Action Buttons,
https://share.kde.org/index.p
https://bugs.kde.org/show_bug.cgi?id=383614
Bug ID: 383614
Summary: KCM opened from tray icon has wrong icon under Wayland
Product: Powerdevil
Version: unspecified
Platform: Neon Packages
OS: Linux
Status: UNCONFIRM
davidedmundson created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
A surface has an API to know which screen(s) it's on, this is useful
especially for knowing the scale it should render at.
ngraham added a comment.
Yes, Hugo mentioned those current limitations in his comment at
https://bugs.kde.org/show_bug.cgi?id=383434. Ideally we would want to resolve
those, I think, but this is definitely progress and better than the status quo!
REPOSITORY
R31 Breeze
REVISION DETAIL
ht
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
This is needed in virtual keyboard and also used KKeyServer so far. With
this change it is moved to new API provided in Xkb. The new tra
https://bugs.kde.org/show_bug.cgi?id=383606
Bug ID: 383606
Summary: Low power mode settings used regardless of actual
charge
Product: Powerdevil
Version: 5.8.7
Platform: Neon Packages
OS: Linux
S
hpereiradacosta added reviewers: ngraham, graesslin.
hpereiradacosta added a comment.
Please give a shot a the patch reg.
https://bugs.kde.org/show_bug.cgi?id=383434
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7355
To: hpereiradacosta, ngraham, graesslin
Cc: plasm
hpereiradacosta created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
CCBUG:383434
REPOSITORY
R31 Breeze
BRANCH
master-edges
REVISION DETAIL
https://phabricator.kde.org/D7355
AFFECTED FILES
kde
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:5d101ce2977b: Migrate Xkb::toQtKey away from KKeyServer
(authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7336?vs=18209&id=18250#toc
REPOSITORY
R108 KWin
CHANGES SINCE
Test
Test
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:2434bafcb168: [KHintsSettings] Update
AA_DontShowIconsInMenus at runtime (authored by broulik).
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabrica
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Nevertheless I still think we should also ship my review. Rather a null check
too many than too few.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator
graesslin added a comment.
In https://phabricator.kde.org/D7323#136114, @davidedmundson wrote:
> Security in scripts/effects is an existing problem, Scripts already can do
literally anything, from manipulating workspace windows to low level DBus
calls...as kwin. It needs solving regardle
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:51b8518c5e37: [Style KCM] Remove message box about
changes applying only to newly started… (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D7344
To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesli
davidedmundson added a comment.
It wasn't a bug before because it was using whatever Qt had set as a default
value; but that only works when you only have that line once.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D7344
To: brou
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in khintssettings.cpp:357
> If I do removeKey("ShowIconsInMenu") rather than explicitly setting it
>
> then call settings changed, this will always remain on whatever it was
> before; rather than matching what the actual defa
broulik updated this revision to Diff 18236.
broulik added a comment.
Set default to `true`
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7344?vs=18229&id=18236
REVISION DETAIL
https://phabricator.kde.org/D7344
AFFECTE
davidedmundson added inline comments.
INLINE COMMENTS
> khintssettings.cpp:357
> +{
> +bool showIcons = cg.readEntry("ShowIconsInMenuItems",
> !QApplication::testAttribute(Qt::AA_DontShowIconsInMenus));
> +QCoreApplication::setAttribute(Qt::AA_DontShowIconsInMenus, !showIcons);
If I do
cfeck accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7345
To: broulik, #plasma, cfeck
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mar
broulik updated this revision to Diff 18229.
broulik added a comment.
Yet another duplicate removed
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7344?vs=18228&id=18229
REVISION DETAIL
https://phabricator.kde.org/D7344
broulik updated this revision to Diff 18228.
broulik added a comment.
- Split into its own function as it's also done in updateQtSettings
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7344?vs=18225&id=18228
REVISION DETAI
broulik added a dependent revision: D7345: [Style KCM] Remove message box about
changes applying only to newly started applications.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D7344
To: broulik, #plasma
Cc: plasma-devel, ZrenBot, pr
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We now apply this setting at runtime.
TEST PLAN
Depends on https://phabricator.kde.org/D7344
REPOSITORY
R119 Plasma Desktop
REVISION DET
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
CHANGELOG: Changing the "Show icons in menus" setting will now immediately be
applied to running applications
TEST PLAN
Changed the "Show i
sitter reopened this revision.
sitter added a comment.
Blergh, reverted. Pushed in wrong terminal.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D7343
To: sitter, apol, ltoscano
Cc: ltoscano, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:b433b503016e: auto generate desktop file for url handling
(authored by sitter).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7343?vs=18221&id=1822
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:f539a5b5cdec: concept of Layers (authored by mart).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7306?vs=18141&id=18223
REVISION DETAIL
https://phabricator.kde
mart added a comment.
thanks! i can reproduce the warning message, i'll investigate
REPOSITORY
R169 Kirigami
BRANCH
mart/layers
REVISION DETAIL
https://phabricator.kde.org/D7306
To: mart, #kirigami, leinir, atulsharma
Cc: plasma-devel, apol, mart
sitter added a reviewer: ltoscano.
sitter added a subscriber: ltoscano.
sitter added a comment.
@ltoscano is this file name change compatible from an i18n POV?
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D7343
To: sitter, apol, ltoscano
Cc: ltoscan
leinir accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
mart/layers
REVISION DETAIL
https://phabricator.kde.org/D7306
To: mart, #kirigami, leinir, atulsharma
Cc: plasma-devel, apol, mart
leinir added a comment.
The StackView is complaining about some erroneous anchoring (and i don't see
the visual effects it's complaining about, as far as i can tell), but apart
from that, it looks to work really quite nicely :)
PageRow.qml:348:5: QML ListView: StackView has detected conf
progwolff planned changes to this revision.
progwolff added a comment.
I totally aggree with @davidedmundson's objections.
I will think about your comments and hand in another revision when I find
some time.
Things I will consider:
- Don't re-emit persistent notifications. They wil
sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
configure_file on the desktop file to generate a NoDisplay variant to
handle URLs (currently appstream: only) and have the standard desktop fi
sebas added a comment.
Some coding style suggestions
INLINE COMMENTS
> notificationsengine.cpp:87
> +connect(KIdleTime::instance(), static_cast (KIdleTime::*)(int)>(&KIdleTime::timeoutReached), this, [this, idleId](int
> id){
> +if(id == idleId)
> +m_history.clear();
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
xkb-no-kkeyserver
REVISION DETAIL
https://phabricator.kde.org/D7336
To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,
ivan added a comment.
p.s. Transitioned items go to all activities and the documents are supported
in the current patch.
REVISION DETAIL
https://phabricator.kde.org/D3805
To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, seba
ivan added a comment.
> Hmm I think the Kickoff thing might have been a misunderstanding, or maybe
I was full of crap then?
Maybe both :P :D
We can schedule Kickoff for the +1 release - Kicker/Dash would be a nice test
for the whole thing.
REVISION DETAIL
https://phabricator.kde.
ivan updated this revision to Diff 18220.
ivan edited the summary of this revision.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3805?vs=16733&id=18220
REVISION DETAIL
https://phabricator.kde.org/D3805
AFFECTED FILES
applets/kicker/CMakeLists.txt
applets/kicker/package/contents
mart added a comment.
+1
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7316
To: davidedmundson, #plasma
Cc: mart, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
hein added a comment.
Hmm I think the Kickoff thing might have been a misunderstanding, or maybe I
was full of crap then? I can't think of why I'd request that ... not having
this in our default menu would sort of mean most users never get to use it :)
REVISION DETAIL
https://phabricator.k
ivan added a comment.
> The result of the migration is now the superset of all faves, but sorting
is a bit weird (maybe this is the best possible?)
Not sure we can do anything about that unfortunately.
> However it only ends up on my first activity, the other activity was
migrated t
44 matches
Mail list logo
