sebas added a comment.
Some coding style suggestions
INLINE COMMENTS
> notificationsengine.cpp:87
> + connect(KIdleTime::instance(), static_cast<void
> (KIdleTime::*)(int)>(&KIdleTime::timeoutReached), this, [this, idleId](int
> id){
> + if(id == idleId)
> + m_history.clear();
braces around the if block, please, space after if
> notificationsengine.cpp:401
> +{
> + for(const NotificationData& d : m_history) {
> + Notify(d.appName, d.id, d.appIcon, d.summary, d.body, d.actions,
> d.hints, d.timeout);
for (
(missing whitespace)
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7256
To: progwolff, #plasma, mart
Cc: sebas, davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, apol, lukas
