xapienz added a comment.
I think it would also be good to remove the line `static bool
preInitialize();` in kcms/keyboard/xkb_helper.h, because it will be unused.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6956
To: achauvel
Cc: xapienz, plasma-devel, #pl
graesslin updated this revision to Diff 17308.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Better special casing for Xwayland case which should not break high dpi
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
lueck created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Add link to https://community.kde.org/Baloo/Configuration
TEST PLAN
checkXML5
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://pha
achauvel created this revision.
achauvel added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
More details here: https://bugs.kde.org/show_bug.cgi?id=379930
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6956
AFFEC
graesslin added a comment.
In https://phabricator.kde.org/D6952#129558, @davidedmundson wrote:
> My window scaling test still works because (in retrospect) it's really
stupid.
>
> I use render an entirely blue square.
lol, right.
> If you only show the top quarter of that
graesslin updated this revision to Diff 17299.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Updated to master and emit of connectionDied instead of delete
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6571?vs=
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in wayland_server.cpp:99
> Yeah that should work as well. Though of course the documentation of
> ConnectionThread says it's not emitted if created from application, but we
> can fix that ;-)
>
> It might mean we leak a fe
davidedmundson added a comment.
My window scaling test still works because (in retrospect) it's really stupid.
I use render an entirely blue square.
If you only show the top quarter of that it's still an entirely blue square.
I should render the Japanese flag or something to be u
fvogt updated this revision to Diff 17287.
fvogt added a comment.
braces + const
A hasOwnProperty check is not needed here, that's accounted for by the if
(!favIconUrl) below
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6717?vs=16
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6946
To: davidedmundson, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abet
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
davidedmundson/xdgv6
REVISION DETAIL
https://phabricator.kde.org/D6727
To: davidedmundson, graesslin
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, progwolff,
les
graesslin added a comment.
In https://phabricator.kde.org/D6952#129544, @davidedmundson wrote:
> That almost certainly breaks high Dpi support.
That's what I feared when doing the change, though the unit test which does
high dpi still works.
What we can do is check the buffer
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
That almost certainly breaks high Dpi support.
(Though not for xwayland windows which will always be scale 1)
I'll take a look at the bug, and see if we ca
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3ff8c1f65ebe: [AppMenu Applet] Pass "ctx" as context
instead of "this" (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6951?vs=17286&
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6951
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abet
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The buffer for a XWayland window is larger than the actual size. Thus
we need to use the clientSize as reference, not the buffer size.
This came up during akademy with someone.
I've split drkonqi into its own repo. (Not pushed). It's a git-filter
branch with all history looking neat.
I don't intend to move it outside of workspace as that's always an absolute
nightmare. Being a standalone repo will hopefully be enough, and we can
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R856 Plasma Browser Integration
BRANCH
favicons (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D6717
To: fvogt, #plasma, broulik, davidedmundson
Cc: plasma-devel, ZrenBot, progw
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:d435a59b0514: Expose base64-encoded favicons to the
tabsrunner (authored by fvogt).
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6717?vs=17287&
broulik added a comment.
Cool!
INLINE COMMENTS
> extension.js:495
> +var sendTabsIfComplete = function() {
> +if (--total > 0)
> +return;
Braces even for single line statements:
if (...) {
...
}
> extension.js:505
> +
> +for (let tabInd
fvogt marked 4 inline comments as done.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D6717
To: fvogt, #plasma, broulik, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
rootinfo-setActiveWindow-nullptr-check
REVISION DETAIL
https://phabricator.kde.org/D6908
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, progw
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We copy "ctx" pointer by value into our lambda but by the time our timer
fires, it might be gone already.
Instead, pass "ctx" as context to
broulik added a comment.
@davidedmundson Should we go with this now?
INLINE COMMENTS
> tabsrunner.cpp:103
>
> -if (reply.type() != QDBusMessage::ReplyMessage) {
> +if (reply.type() != QDBusMessage::ReplyMessage ||
> reply.arguments().length() < 1) {
> continue;
broulik added a comment.
> I suppose updating the handler for text/html would make sense too, so that
clicking on a local HTML file opens the same webbrowser.
Well, KRun has a special case for text/html to always open them in the
default browser, no matter what. So you cannot actually ha
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1193971e9a27: [Component Chooser] Update http(s) scheme
handler when changing default browser (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kd
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
I suppose updating the handler for text/html would make sense too, so that
clicking on a local HTML file opens the same webbrowser.
Some people editing HTML files might prefer that loca
broulik updated this revision to Diff 17274.
broulik edited the test plan for this revision.
broulik added a comment.
- Sync `mimeAppList` instead of `profile`, fixes the change not being
reflected immediately
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.k
davidedmundson updated this revision to Diff 17272.
davidedmundson added a comment.
Updated docs + unit test
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6727?vs=16758&id=17272
BRANCH
davidedmundson/xdgv6
REVISION DETAIL
https://phabricator.kde.org
davidedmundson created this revision.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6946
AFFECTED FILES
src/client/connection_th
30 matches
Mail list logo
