davidedmundson added inline comments. INLINE COMMENTS
> graesslin wrote in wayland_server.cpp:99 > Yeah that should work as well. Though of course the documentation of > ConnectionThread says it's not emitted if created from application, but we > can fix that ;-) > > It might mean we leak a few resources, but as we are shutting down anyway... RE: https://phabricator.kde.org/D6727 > That would basically allow us to abandon https://phabricator.kde.org/D6571 > and would also solve the issues we see with the kwayland-integration plugin > which can crash applications on exit. I'd like to see this patch merged (but with the emit connectionDied) It might work without, but it still leaves a window where someone calling foo->destroy() would crash. REPOSITORY R108 KWin BRANCH connection-cleanup REVISION DETAIL https://phabricator.kde.org/D6571 To: graesslin, #kwin, #plasma, mart Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
