D6657: [krunner] First set panel behavior than as panel

2017-07-12 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6657#124685, @apol wrote: > Seems like this API is extremely brittle, would it be possible to make sure this is dealt with on the library side? See my long explanation mail. REPOSITORY R120 Plasma Workspace REVISION DE

D6666: Allow having a header in a ListView that is in an OverlaySheet

2017-07-12 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 16615. apol added a comment. Check if there's a flickableItem like others REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D?vs=16614&id=16615 BRANCH master REVISION DETAIL https://phabricator.kde.org/D AFFECT

D6666: Allow having a header in a ListView that is in an OverlaySheet

2017-07-12 Thread Aleix Pol Gonzalez
apol added a comment. Before F3809975: Spectacle.tQ9319.png F3809977: Spectacle.GS9319.png After F3809972: Spectacle.Ea9319.png F3809967: Spectacle.Ti9319.png

D6666: Allow having a header in a ListView that is in an OverlaySheet

2017-07-12 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY For some reason when there's a header ListView decides to start the items at 0 and the headerItem is placed in the negative space. This makes

D6657: [krunner] First set panel behavior than as panel

2017-07-12 Thread Aleix Pol Gonzalez
apol added a comment. Seems like this API is extremely brittle, would it be possible to make sure this is dealt with on the library side? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6657 To: graesslin, #plasma Cc: apol, plasma-devel, ZrenBot, progwolff,

D6658: Fix mdstat parsing of inactive RAID arrays, remove dead code

2017-07-12 Thread Michael Pyne
mpyne created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Something I noticed while doing the musl libc fixes: 1. A GCC warning is generated for `in_devs`. It turns out the warning was referring t

D6657: [krunner] First set panel behavior than as panel

2017-07-12 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If a PlasmaShellSurface for an already mapped window is created and set to panel it affects other windows by adjusting the maximized area.

D6654: [krunner] Perform Wayland integration in show not expose event

2017-07-12 Thread Martin Flöser
graesslin planned changes to this revision. graesslin added a comment. doesn't work REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6654 To: graesslin, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

Re: KRunner Wayland issues on Qt 5.9

2017-07-12 Thread Martin Flöser
Am 2017-07-12 19:02, schrieb Marco Martin: On Wednesday 12 July 2017 18:45:54 Martin Flöser wrote: > Any ideas or advice? So played with the KRunner code, resulted in: https://phabricator.kde.org/D6654 Summary, don't use expose event, use show event uh, this means we have to get the rest on

D6642: Use version of the Applications product

2017-07-12 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D6642 To: elvisangelaccio, #plasma, anthonyfieroni, apol Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

Re: KRunner Wayland issues on Qt 5.9

2017-07-12 Thread Marco Martin
On Wednesday 12 July 2017 18:45:54 Martin Flöser wrote: > > Any ideas or advice? > > So played with the KRunner code, resulted in: > https://phabricator.kde.org/D6654 > > Summary, don't use expose event, use show event uh, this means we have to get the rest on showevent as well then? i tought th

Re: KRunner Wayland issues on Qt 5.9

2017-07-12 Thread Martin Flöser
Am 2017-07-12 18:35, schrieb David Edmundson: On Wed, Jul 12, 2017 at 4:02 PM, Martin Flöser wrote: Hi all, I had a look at the issues of KRunner on Wayland with Qt 5.9 and want to share my findings. What we see is KRunner working fine on first invokation, but afterwards everything is messed

Re: KRunner Wayland issues on Qt 5.9

2017-07-12 Thread Martin Flöser
Am 2017-07-12 17:02, schrieb Martin Flöser: Hi all, I had a look at the issues of KRunner on Wayland with Qt 5.9 and want to share my findings. What we see is KRunner working fine on first invokation, but afterwards everything is messed up: * maximized windows shortly change their size * KRunne

D6654: [krunner] Perform Wayland integration in show not expose event

2017-07-12 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Expose is too late, everything breaks in KWin, see [1]. With show event we get the integration working correctly. No idea what the comment

Re: KRunner Wayland issues on Qt 5.9

2017-07-12 Thread David Edmundson
On Wed, Jul 12, 2017 at 4:02 PM, Martin Flöser wrote: > Hi all, > > I had a look at the issues of KRunner on Wayland with Qt 5.9 and want to > share my findings. > > What we see is KRunner working fine on first invokation, but afterwards > everything is messed up: > * maximized windows shortly ch

D6639: [Color Picker] Fix picking colors in multi-screen

2017-07-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R114:0ed491a1b0f1: [Color Picker] Fix picking colors in multi-screen (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6639?vs=16547&id=16594#toc REPOSITORY R114 Plasma Addons

D6653: [Notifications] Check for corona to avoid crash

2017-07-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:8a05294e5b3e: [Notifications] Check for corona to avoid crash (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6653?vs=16592&id=16593

D6653: [Notifications] Check for corona to avoid crash

2017-07-12 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6653 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mar

D6653: [Notifications] Check for corona to avoid crash

2017-07-12 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6653 To: broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6653: [Notifications] Check for corona to avoid crash

2017-07-12 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY My previous attempt only fixed the case when notifications were directly in a panel. Now it also no longer crashes when removing a panel that

D6631: Fix compilation with strict libc (such as musl)

2017-07-12 Thread Michael Pyne
This revision was automatically updated to reflect the committed changes. Closed by commit R106:257591cf462d: Fix compilation with strict libc (such as musl). (authored by mpyne). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6631?vs=16520&id=16590 REVISIO

KRunner Wayland issues on Qt 5.9

2017-07-12 Thread Martin Flöser
Hi all, I had a look at the issues of KRunner on Wayland with Qt 5.9 and want to share my findings. What we see is KRunner working fine on first invokation, but afterwards everything is messed up: * maximized windows shortly change their size * KRunner opens behind other windows With WAYLAN

D6577: Don't autohide panel if a child window is open

2017-07-12 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:2d8b4e1dec26: Don't autohide panel if a child window is open (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6577?vs=16369&id=

D6649: Port analog clock to PlasmaComponents3

2017-07-12 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:930e8f9609a0: Port analog clock to PlasmaComponents3 (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6649?vs=16573&id=16582 R

D6648: Remove unused references to forceWindowed

2017-07-12 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:af666ef770ac: Remove unused references to forceWindowed (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6648?vs=16571&id=16581

D6647: Show alternatives dialog immediately

2017-07-12 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:74fe83cbaf4f: Show alternatives dialog immediately (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6647?vs=16570&id=16580 REV

D6648: Remove unused references to forceWindowed

2017-07-12 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. thanks for taking care of it REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6648 To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, Z

D6647: Show alternatives dialog immediately

2017-07-12 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6647 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6649: Port analog clock to PlasmaComponents3

2017-07-12 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6649 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6649: Port analog clock to PlasmaComponents3

2017-07-12 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Only use is a label which is API identical. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.

D6648: Remove unused references to forceWindowed

2017-07-12 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6648 AFFECTED FILES shell/desk

D6647: Show alternatives dialog immediately

2017-07-12 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There is (a very appreciated) a description of why loading the alternatives dialog was queued. This causes issues for autohide as

[Breeze] [Bug 382264] Black buttons unreadable on the black logout screen

2017-07-12 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=382264 Sebastian Kügler changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You are receiving th

D6631: Fix compilation with strict libc (such as musl)

2017-07-12 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D6631 To: mpyne, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6642: Use version of the Applications product

2017-07-12 Thread Anthony Fieroni
anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. I saw that and forgot to make a revison. (Ship-it from it's not so correct :)) REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D6

D6642: Use version of the Applications product

2017-07-12 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY kio-extras nowadays is shipped as part of KDE Applications rather than Plasma, so use the correct version. REPOSITORY R320 KIO Ext

Re: Topics for Plasma BoF at Akademy 2017

2017-07-12 Thread Marco Martin
On Wednesday 12 July 2017 07:13:20 Martin Flöser wrote: > > https://community.kde.org/Akademy/2017/Monday#Room_2.3_-_24th_July > > If you want me to remote participate: the earliest I can be at home is > 16:00. But I need to know in before, my normal arriving time is 17:30. would definitely be ap

D6639: [Color Picker] Fix picking colors in multi-screen

2017-07-12 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Can you validate the pixmap is not null before we access the pixel data, just in case grabwindow fails. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricato

D6639: [Color Picker] Fix picking colors in multi-screen

2017-07-12 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Simplifies code and also grab just one pixel instead of the entire screen. BUG: 382261 FIXED-IN: 5.10.4 TEST PLAN Picks correct color

[Breeze] [Bug 382264] Black buttons unreadable on the black logout screen

2017-07-12 Thread Fincer
https://bugs.kde.org/show_bug.cgi?id=382264 Fincer changed: What|Removed |Added Summary|Black logout buttons|Black buttons unreadable on |unreada

[Breeze] [Bug 382264] New: Black logout buttons unreadable on the black background

2017-07-12 Thread Fincer
https://bugs.kde.org/show_bug.cgi?id=382264 Bug ID: 382264 Summary: Black logout buttons unreadable on the black background Product: Breeze Version: 5.10.3 Platform: Other OS: Linux Status: UNCON

Re: Topics for Plasma BoF at Akademy 2017

2017-07-12 Thread Sebastian Kügler
On woensdag 12 juli 2017 06:19:15 CEST Bhushan Shah wrote: > On Mon, Jul 10, 2017 at 3:58 PM, Bhushan Shah wrote: > > > > Currently room information is not available so we can't book slot but at > > least we can collect ideas and topics > > Now room information is available and I've booked a r