This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f8de13c67421: Don't list KF5::WindowSystem in public
libraries (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6495?
hein added a comment.
Another crash, this time a while after running with migrated favourites:
Thread 1 (Thread 0x7f8ef082cdc0 (LWP 8048)):
[KCrash Handler]
#6 0x7f8e44c0dcf8 in
KAStatsFavoritesModel::Private::removeOldCachedEntries() const
(this=0x40fc41c800) at
/home/eike/dev
davidedmundson abandoned this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6472
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
Actually read autostart code this time. It's unaffected.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabri
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R97 Bluedevil
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D6487
To: drosca, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8132e02bb8e8: Fix setting natural/inverted scroll mode
for touchpad with libinput (authored by gladhorn).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6488
asturmlechner added a comment.
Thanks, works for me!
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6495
To: davidedmundson, #plasma
Cc: asturmlechner, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R118 Plasma SDK
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6494
To: asturmlechner, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jens
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We don't use it in public API
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
ht
asturmlechner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Depends on https://phabricator.kde.org/D6493
TEST PLAN
Builds fine.
REPOSITORY
R118 Plasma SDK
BRANCH
master
REVISION DETAIL
ltoscano updated this revision to Diff 16149.
ltoscano added a comment.
Remove a Plasma reference (generic session)
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6469?vs=16097&id=16149
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6488
To: gladhorn, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts,
gladhorn created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Copy and paste meant that the check box didn't work, thus under wayland no
natural scroll direction was possible.
REPOSITORY
R119 Plasma D
drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Recent change in QML broke the code where there was an item
and model role both named MediaPlayer, which made it to show
media player compon
KWin has received an update to the 5.10.3 release. 5.10.3.1 contains a fix for
https://bugs.kde.org/show_bug.cgi?id=381870
Freeze in KWin::checkGLError on startup
which affects machines with an NVidia card.
The change is
https://commits.kde.org/kwin/aefb5f4dd9d41aa7377d56ece203089c73aefe07
htt
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cb2eaef77eef: Remove deprecated plasmashell options
(authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6429?vs=15988&id=16138
RE
Am 2017-07-02 17:12, schrieb Jonathan Riddell:
On Sat, Jul 01, 2017 at 07:15:42PM +0200, Martin Flöser wrote:
This is a severe issue and thus I request an emergency release as
soon as I have the patch ready.
Yes can do, let me know when it should be done
I just pushed:
https://commits.kde.o
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:aefb5f4dd9d4: Prevent endless loop in checkGLError due to
GL_CONTEXT_LOST (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6464?vs=16088&id=1613
This revision was automatically updated to reflect the committed changes.
Closed by commit R6:dce2a89774c6: emit runningActivityListChanged on activity
creation (authored by mart).
REPOSITORY
R6 KActivities
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6484?vs=16130&id=16134
REVISI
garg added a comment.
You can checkout the XML on
http://www.nationalgeographic.com/photography/photo-of-the-day/ by just viewing
the source :)
I'm not aware of a crash in bugzilla, got a bug number?
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D6459
davidedmundson added a comment.
Obviously this isn't the best fix, if they shuffle the XML about it won't
work .. but if it makes things better so be it.
Do you still have a copy of this broken XML?
Is this related to the crash in XML parsing we see over bugzilla?
REPOSITORY
R114 Pl
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Good work.
REPOSITORY
R6 KActivities
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6484
To: mart, #plasma, ivan, davidedmundson
Cc: davidedmundson, plas
mart added a reviewer: ivan.
REPOSITORY
R6 KActivities
REVISION DETAIL
https://phabricator.kde.org/D6484
To: mart, #plasma, ivan
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
if an activity gets created and started immediately,
runningActivityListChanged wasn't emitted, a symptom
was the activi
sebas added a comment.
Needs to smallish changes, then good to go in.
INLINE COMMENTS
> ltoscano wrote in emailclientconfig_ui.ui:12
> Do you mean keep KDE somehow? But "KDE desktop" is exactly what should go
> away :)
Yeah, exactly. The KDE should go away here.
> lukas wrote in globalpath
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:06410e779b4f: Fix tab bar layout key handling in RTL
(authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6480?vs=16120&i
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
origin-master (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D6480
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, Zre
ltoscano added inline comments.
INLINE COMMENTS
> lukas wrote in emailclientconfig_ui.ui:12
> I'd keep the old one as well, just for a better discoverability
Do you mean keep KDE somehow? But "KDE desktop" is exactly what should go away
:)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
ht
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Current code will, when mirrored, treat all keys like they're the left
key.
BUG: 379894
TEST PLAN
Ran pl
lukas added inline comments.
INLINE COMMENTS
> ltoscano wrote in autostart.cpp:75
> Should this be "Session" or "Plasma Session"? Aren't the settings changed
> here valid for all desktops which follow the XDG spec?
Yes, it should be valid for all DEs (I'd vote for "Session" only then)
> emailc
hein added a comment.
Adding new favorites works. However, starting with the blank favorites I did
the following:
1. Add a favorite on all activities
2. Add a favorite specific to the current activity
3. Add another favorite on all activities
I've noticed that for both #2 and #3,
hein added a comment.
Here's what I tried to do today:
1. Set up Kicker and Appdash with different favorites
2. Patch, install
3. Log out, log in
Then I got the crash above.
4. Switch back to master, log out and back in, still have the two widgets
with different faves
5. L
hein added inline comments.
INLINE COMMENTS
> main.xml:48
> +
> + Are the favorites ported to use KActivitiesStats to allow
> per-activity favorites
> + false
Pedantic: Broken grammar
> SideBarItem.qml:59
> onActionClicked: {
> +console.log(actionId + "<-
davidedmundson added a comment.
Can you please upload patches with arc otherwise we don't get to expand the
context.
Plugins have the lifespan of containment. (but could change as user toggles
things)
ConfigDlg lasts till it's quit
This model is owned by the ContainmentConfigView.
hein added a comment.
Reproducable crash:
#0 0x7fff28407f06 in
KAStatsFavoritesModel::Private::removeOldCachedEntries() const (this=0x3266e40)
at
/home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:130
#1 0x7fff284063e5
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:13aa418c2772: get rid of manual window flags setting on
controller (authored by mart).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6403?vs=15905&id=1611
mart abandoned this revision.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6419
To: mart, #plasma, #kwin, davidedmundson, graesslin
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
davidedmundson added a comment.
oh...that seems simpler!
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6472
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, luka
ivan edited the test plan for this revision.
REVISION DETAIL
https://phabricator.kde.org/D3805
To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
ivan added a comment.
True, I haven't updated the branch - had more than a few sub-branches since
the last update.
The diff here is the proposed solution for all my problems ;)
The last comment was just that I've added the test to the review itself (the
"Test Plan" part).
REVISION
hein added a comment.
I'm a little confused by the last comment - the branch in the repo hasn't
been updated in four months, so the new testing location seems to be the diff
again, yet there's a "I added a test" comment with no diff change ... :)
Anyways, I'll review the diff here.
REVI
41 matches
Mail list logo
