hein added inline comments.
INLINE COMMENTS
> main.xml:48
> + <entry name="favoritesPortedToKAstats" type="Bool">
> + <label>Are the favorites ported to use KActivitiesStats to allow
> per-activity favorites</label>
> + <default>false</default>
Pedantic: Broken grammar
> SideBarItem.qml:59
> onActionClicked: {
> + console.log(actionId + "<------------------ this is the id");
> actionTriggered(actionId, actionArgument);
Not a fan of debug stuff that's not really understandable without context ...
lets take the console.log() calls out when finalizing the patch.
REVISION DETAIL
https://phabricator.kde.org/D3805
To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
