D6221: Drop unused dependencies

2017-06-13 Thread Antonio Rojas
arojas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Builds, works REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D6221 AFFECTED FILES CMakeLists.txt To: arojas, #plasma

[Breeze] [Bug 381169] Change Virtualbox icon more similar to the vendor's icon

2017-06-13 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=381169 Christoph Feck changed: What|Removed |Added CC||kain...@gmail.com Component|general

Plasma 5.10.2

2017-06-13 Thread Jonathan Riddell
Plasma 5.10.2 is now released https://www.kde.org/announcements/plasma-5.10.2.php

[Breeze] [Bug 381169] Change Virtualbox icon more similar to the vendor's icon

2017-06-13 Thread martonmiklos
https://bugs.kde.org/show_bug.cgi?id=381169 martonmiklos changed: What|Removed |Added Summary|Change Virtualbox icon more |Change Virtualbox icon more |s

[Breeze] [Bug 381169] New: Change Virtualbox icon more similar to the vendor's

2017-06-13 Thread martonmiklos
https://bugs.kde.org/show_bug.cgi?id=381169 Bug ID: 381169 Summary: Change Virtualbox icon more similar to the vendor's Product: Breeze Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Se

[kio-extras] [Bug 379680] MTP protocol died unexpectedly

2017-06-13 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379680 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |UNCONFIRMED Resolution|WAITINGFORINFO

[kio-extras] [Bug 379817] Behaviour change: JPEG image preview scaled to widget size

2017-06-13 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379817 Christoph Feck changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[kio-extras] [Bug 379680] MTP protocol died unexpectedly

2017-06-13 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=379680 --- Comment #4 from lordgearian2...@gmail.com --- Have run kdeinit5 nothing relevant information came up with that. Best guess right now it that there needs to be a look into the protocols that samsung lg and other brands are using for their devices. Sin

[kio-extras] [Bug 379680] MTP protocol died unexpectedly

2017-06-13 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379680 --- Comment #3 from Christoph Feck --- To further investigate this issue, KDE developers need the information requested in comment #1. If you can provide it, or need help with finding that information, please add a comment. -- You are receiving this m

D6215: Introduce aboutToShow() signal

2017-06-13 Thread Eike Hein
hein added a comment. I used to subclass in Simple Menu, but then eliminated the C++ plugin so I could put it on the Store, so this is important for now. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: he

D6215: Introduce aboutToShow() signal

2017-06-13 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in dialog.cpp:1368-1370 > this is already done in updateVisibility which is effectively called from > > QQuickWindow::setVisible(visible); > > So we're just doing things twice. > > You've not really said what problem we're try

D6215: Introduce aboutToShow() signal

2017-06-13 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > dialog.cpp:1368-1370 > +if (d->mainItem) { > +d->mainItem->setVisible(true); > +d->syncToMainItemSi

D6216: simplify positioning code

2017-06-13 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY drop most of the positioning code, drop the animation of the window position. use the newly introduced aboutToShow() signal and position the p

D6215: Introduce aboutToShow() signal

2017-06-13 Thread Marco Martin
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY introduce this new signal: make sure the size of the dialog is final, sinced with the main item and the optional layout

D6214: check window visibility at expose event

2017-06-13 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D6214#116242, @davidedmundson wrote: > Edit. > > qwaylandwindow code is: > > if (! (mShellSurface && mShellSurface->handleExpose(rect))) > QWindowSystemInterface::handleExposeEvent(window(), rect); > > > so if

D6214: check window visibility at expose event

2017-06-13 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Edit. qwaylandwindow code is: if (! (mShellSurface && mShellSurface->handleExpose(rect))) QWindowSystemInterface::handleExposeEvent(window(), rect);

D6214: check window visibility at expose event

2017-06-13 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D6214#116240, @davidedmundson wrote: > > it's possible that a window gets an expose event even if the qwindow > > is not visible > > How? > > QWaylandXdgSurfaceV6::handleExpose returns false if it's not configured yet, and w

D6214: check window visibility at expose event

2017-06-13 Thread David Edmundson
davidedmundson added a comment. > it's possible that a window gets an expose event even if the qwindow is not visible How? QWaylandXdgSurfaceV6::handleExpose returns false if it's not configured yet, and we can't receive a configure before we've created the shell, and we don't

D6214: check window visibility at expose event

2017-06-13 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY it's possible that a window gets an expose event even if the qwindow is not visible, this can cause problems like the window decoration create

Re: Plasmoid plugin signal handling

2017-06-13 Thread Sebastian Kügler
On dinsdag 13 juni 2017 16:27:47 CEST cdfgh...@gmail.com wrote: [...] > qmlRegisterType(uri, 1, 0, "ActivityJumper"); Why not call this class ActivityJumper in the first place, it's generally less confusing to align class names with their QML names. > -- ActivityJumper.qml > > Item

Plasmoid plugin signal handling

2017-06-13 Thread cdfghglz
Hi there, im pretty new here and I am in need of help: I try to emit a signal from c++ plugin of a plasmoid. I have problem handling this event in the qml. I tried to follow http://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html Here is some of my code: -- plasmoidplugin.h class

D6212: Don't crash when deleted during network operations

2017-06-13 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D6212 To: leinir, #kirigami, mart, apol, davidedmundson Cc: davidedmundson, plasma-devel, apol, mart

D6212: Don't crash when deleted during network operations

2017-06-13 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 15421. leinir marked an inline comment as done. leinir added a comment. Fix glaringly obvious over-complication spotted by David :) REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6212?vs=15420&id=15421 REVISION DETAIL

D6212: Don't crash when deleted during network operations

2017-06-13 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > desktopicon.cpp:333 > +bool isDestroyed = false; > +connect(this, &QObject::destroyed, this, [&isDestroyed](){ > isDestroyed = true; }); > QByteArray data; Normal convention for handling nested event loops (which i

D6212: Don't crash when deleted during network operations

2017-06-13 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Without this patch, we occasionally end up in a situation where the DesktopIcon object is deleted while we are still fetching data from the network, resulti

D6191: Simplify KNSBackend fetch logic

2017-06-13 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Ship when the dependency is in. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D6191 To: leinir, apol, #discover_software_store Cc: plasma-devel, ZrenB

D6191: Simplify KNSBackend fetch logic

2017-06-13 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 15419. leinir marked 2 inline comments as done. leinir added a comment. Adapted code as suggested. Note that this now depends on https://phabricator.kde.org/D6190 getting merged (as that contains the code that's iffed out). REPOSITORY R134 Discover Soft

D6191: Simplify KNSBackend fetch logic

2017-06-13 Thread Dan Leinir Turthra Jensen
leinir marked 2 inline comments as done. leinir added inline comments. INLINE COMMENTS > apol wrote in KNSBackend.cpp:109 > Add an `#if KNEWSTUFF_VERSION_MAJOR==5 && KNEWSTUFF_VERSION_MINOR==36` > > We always end up forgetting these fixme Very true, yes - to be quite frank, i forgot about the p

Re: Plasma Vision v 2.0

2017-06-13 Thread Jens Reuterberg
Awesome! "elegant" is a lovelly way to cover that ground - what do you think Martin? /jens On tisdag 13 juni 2017 kl. 11:30:10 CEST Sebastian Kügler wrote: > On zaterdag 10 juni 2017 09:28:38 CEST Jens Reuterberg wrote: > > You are a man of my own heart! > > > > Beautiful is the core ideal of

Re: Plasma Vision v 2.0

2017-06-13 Thread Sebastian Kügler
On zaterdag 10 juni 2017 09:28:38 CEST Jens Reuterberg wrote: > You are a man of my own heart! > > Beautiful is the core ideal of "venustatis" - I just went for "interesting" > because beautiful has become so... depricated in English usage (or modern/ > western usage). Almost like a pejorative. I

D6161: Add a integration test suite and fix a signal connect bug when attaching reports

2017-06-13 Thread Harald Sitter
sitter updated this revision to Diff 15417. sitter added a comment. do not hardcode at-spi-bus-launcher either REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6161?vs=15415&id=15417 BRANCH master REVISION DETAIL https://phabricator.kde.org/D61

D5405: Create desktop file name based on organization domain unless set explicitely

2017-06-13 Thread Leslie Zhai
This revision was automatically updated to reflect the committed changes. Closed by commit R467:ddd546251022: Set organization name for Wayland icon. (authored by lesliezhai). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5405?vs=13342&id=15416#toc REPOSITORY R467 K3b CHANGES SINCE L

D6161: Add a integration test suite and fix a signal connect bug when attaching reports

2017-06-13 Thread Harald Sitter
sitter updated this revision to Diff 15415. sitter added a comment. do not hardcode drkonqi but use the target_file of the actual exec target REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6161?vs=15303&id=15415 BRANCH master REVISION DETAIL

D6211: Revert "Make the applet DBus activated"

2017-06-13 Thread David Rosca
This revision was automatically updated to reflect the committed changes. Closed by commit R115:e32c8904683d: Revert "Make the applet DBus activated" (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6211?vs=15413&id=15414