mart added inline comments. INLINE COMMENTS
> davidedmundson wrote in dialog.cpp:1368-1370 > this is already done in updateVisibility which is effectively called from > > QQuickWindow::setVisible(visible); > > So we're just doing things twice. > > You've not really said what problem we're trying to solve with this patch. > > If a subclass wants to do custom positioning (like krunner) they've got the > virtual method they can use. > > If you want a hook between us updating our size and the platform showing the > window we've got ShowEvent. > You've not really said what problem we're trying to solve with this patch. having a pointt in which we are 100% sure of the final size of the dialog to correctly position it. if visualparent is set, this is done internally and all works fine, but for users that do a manual positioning, there are currently no hooks from client code to do so, this is in part the reason for the big ugly custom notifications positioning code > this is already done in updateVisibility which is effectively called from i think it should be safe to remove it from updatevisibility > If you want a hook between us updating our size and the platform showing the > window we've got ShowEvent. yes, exactly. The idea is for it to be usable from qml, so can't rely on subclassing. which would be ok for notifications but not for simplemenu REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
