Re: Notice of significant adjustment to KWin

2017-06-09 Thread Rik Mills
Fair enough. I will not poke at that further then. On 09/06/17 21:20, Ben Cooksley wrote: >From my understanding invasive changes were committed without review, > which were similar to changes which had been previously been rejected > in review. > > Regards, > Ben I look forward to good progress

Re: Notice of significant adjustment to KWin

2017-06-09 Thread Ben Cooksley
On Sat, Jun 10, 2017 at 8:17 AM, Rik Mills wrote: > Cannot view T6301 (I have a -dev account now), so I am in the dark on > the reasons/reasoning for this? > > Can you elaborate please? >From my understanding invasive changes were committed without review, which were similar to changes which had

Re: Notice of significant adjustment to KWin

2017-06-09 Thread Rik Mills
Cannot view T6301 (I have a -dev account now), so I am in the dark on the reasons/reasoning for this? Can you elaborate please? On 09/06/17 21:10, Ben Cooksley wrote: > Hi all, > > At the request of the KWin maintainer the KWin repository master > branch has been forcibly rewound to c5861b99 (pe

Notice of significant adjustment to KWin

2017-06-09 Thread Ben Cooksley
Hi all, At the request of the KWin maintainer the KWin repository master branch has been forcibly rewound to c5861b99 (per T6301) A log of the changes which have been thrown away is attached. Developers may need to reinstate these changes (assuming they have been properly reviewed) to ensure no

D6141: make shadows work for windows 100%width or height

2017-06-09 Thread Thomas Lübking
luebking added a comment. I think what David has in mind is a shadow constellation like oo || with the lower edges deliberately being omitted - this will cause glitchy rendering (because the bottom edge will be stretched over the edges) - thus he's looking fo

D6163: [Icon Applet] Get favicon for website shortcuts

2017-06-09 Thread David Faure
dfaure added a comment. Yeah the favicon for kde.org is bigger than the size limit from the kio code -- ironic, isn't it. I never took the time to find out if it could be reduced, or if the size limit should be increased, and whatever other websites and other webbrowsers do. As for KIO:

D6141: make shadows work for windows 100%width or height

2017-06-09 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D6141#115332, @davidedmundson wrote: > You're fixing the one bug at hand as though it's a special case, rather than fixing the original code. > This leaves it still broken in the case that you have 3 images for the top and only one

D6164: Make shadows work for windows 100% width or height

2017-06-09 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY Clients provide shadows as 9 images, which then get split into relevant quads. To work out the full width we need the size of

D6141: make shadows work for windows 100%width or height

2017-06-09 Thread David Edmundson
davidedmundson added a comment. You're fixing the one bug at hand as though it's a special case, rather than fixing the original code. This leaves it still broken in the case that you have 3 images for the top and only one for the bottom (for whatever reason) REPOSITORY R108 KWin REVIS

D6141: make shadows work for windows 100%width or height

2017-06-09 Thread Marco Martin
mart updated this revision to Diff 15310. mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. - more explicit checking on width/height==0 REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6141?vs=15260&id=15310 BRANCH mast

D6163: [Icon Applet] Get favicon for website shortcuts

2017-06-09 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6163 To: broulik, #plasma, dfaure Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6163: [Icon Applet] Get favicon for website shortcuts

2017-06-09 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When creating an icon for a website use its favicon if possible. TEST PLAN It fails to get the favicon for kde.org but succeeds with other w

D6162: generate the old key before updating enabledborders

2017-06-09 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:6ffe068b8014: generate the old key before updating enabledborders (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6162?vs=1530

D6162: generate the old key before updating enabledborders

2017-06-09 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6162 To: mart, #plasma, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,

D6162: generate the old key before updating enabledborders

2017-06-09 Thread Marco Martin
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY sometimes a frame changed enabled borders causing a dangling pointer in s_sharedFrames, since oldkey was generated with

D6148: [Icon Applet] Repopulate if URL didn't change

2017-06-09 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:45e4f998e9e8: [Icon Applet] Repopulate if URL didn't change (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6148?vs=15274&id=15306 R

Re: Plasma Browser Integration is in kdereview

2017-06-09 Thread David Edmundson
>StaticMessages.sh Didn't know about that, thanks. I've implemented it, but can only test so much. Can you send me scripty logs if it fails. David

D6145: Massively simplify the class DesktopPortal

2017-06-09 Thread David Edmundson
davidedmundson added a comment. note I've still only tested with qdus, not Flatpak itself. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D6145 To: davidedmundson, #plasma, jgrulich Cc: apol, plasma-devel, ZrenBot, spstarr, progwol

D6145: Massively simplify the class DesktopPortal

2017-06-09 Thread David Edmundson
davidedmundson updated this revision to Diff 15305. davidedmundson added a comment. Change case of methods, rename portals to portals REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6145?vs=15266&id=15305 BRANCH master

D6161: Add a integration test suite and fix a signal connect bug when attaching reports

2017-06-09 Thread Harald Sitter
sitter updated this revision to Diff 15303. sitter added a comment. fix a11y names of input fields REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6161?vs=15302&id=15303 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6161 AFFECTED

D6161: Add a integration test suite and fix a signal connect bug when attaching reports

2017-06-09 Thread Harald Sitter
sitter edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6161 To: sitter Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6161: Add a integration test suite and fix a signal connect bug when attaching reports

2017-06-09 Thread Harald Sitter
sitter retitled this revision from "listen to toggle signals to properly track radiobuttons" to "Add a integration test suite and fix a signal connect bug when attaching reports". sitter edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricato

D6161: Add a integration test suite and fix a signal connect bug when attaching reports

2017-06-09 Thread Harald Sitter
sitter edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6161 To: sitter Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6161: listen to toggle signals to properly track radiobuttons

2017-06-09 Thread Harald Sitter
sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY radios' toggling doesn't emit buttonclicking :( add a cmdline option to enable bringing up the dialog directly in a testing scenario i

D6143: Even on plasma we shouldn't be using plasma icons

2017-06-09 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D6143#115262, @mart wrote: > it may make sense... > all depends from what we decide to do in plasma mobile, that would be pretty much the place where this is used. Why would we do something different on Plasma Mobile? >

D6143: Even on plasma we shouldn't be using plasma icons

2017-06-09 Thread Aleix Pol Gonzalez
apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D6143 To: apol, #kirigami, mart Cc: davidedmundson, plasma-devel, apol, mart

D6143: Even on plasma we shouldn't be using plasma icons

2017-06-09 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. it may make sense... all depends from what we decide to do in plasma mobile, that would be pretty much the place where this is used restricting icons to system theme may make things simpler

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2017-06-09 Thread FabiB
https://bugs.kde.org/show_bug.cgi?id=369676 FabiB changed: What|Removed |Added CC||plusf...@gmail.com --- Comment #6 from FabiB --- Maybe

Re: Plasma Vision v 2.0

2017-06-09 Thread Martin Steigerwald
Jens Reuterberg - 09.06.17, 09:40: > We build to be durable, we create to be usable, we design to be interesting. […] > Reasoning behind the vision: […] > Finally its the poetic vitruvian line at the end: Firmitas, Utilitas, > Venustatis. That something is "well built" or "durable", that something

Plasma Vision v 2.0

2017-06-09 Thread Jens Reuterberg
Time to get back to the vision. Plasma Vision 2 Plasma Desktop is a cross device work environment where total trust is put on the user's capacity to best define her own workflow and preferences. Plasma is simple by default, a clean work area for real world usage which intends to sta

D6111: UI updates for NetworkManager-l2tp 1.2.6

2017-06-09 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R116:1adb36466475: UI updates for NetworkManager-l2tp 1.2.6 (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6111?vs=1519