mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY sometimes a frame changed enabled borders causing a dangling pointer in s_sharedFrames, since oldkey was generated with the new enabled borders, it generated a key not present in the hash, tryed to remove it and left the one associated with the old key in the hash. if the need to reuse a frame with that key ever arised again, we had a crash BUG:378508 TEST PLAN couldn't reproduce the crash neither with or without patch, with the patch, if i put debug in every place a framedata is removed, searching if the key is in the hash before removing it, now it's always true, before sometimes it was false REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6162 AFFECTED FILES src/plasma/framesvg.cpp To: mart, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
