D6111: UI updates for NetworkManager-l2tp 1.2.6

2017-06-08 Thread Douglas Kosovic
dkosovic added a comment. I'm not aware of being given any privileges to push it. If I was to push it, I'm guessing I need to use Arcanist and git? But I'm happy for you to push it. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D6111 T

D6111: UI updates for NetworkManager-l2tp 1.2.6

2017-06-08 Thread Jan Grulich
jgrulich added a comment. Do you have access to push this? Or do you want me to do it instead? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D6111 To: dkosovic, jgrulich Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D6011: let's continue in debug code instead of returning from XRandRConfig::applyKScreenConfig

2017-06-08 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R110:e1355808be39: let's continue in debug code instead of returning from XRandRConfig… (authored by clutz, committed by davidedmundson). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https

[Powerdevil] [Bug 378498] Power settings missing scrollbar

2017-06-08 Thread Pascal d'Hermilly
https://bugs.kde.org/show_bug.cgi?id=378498 --- Comment #3 from Pascal d'Hermilly --- Confirmed happening in kcmshell5 5.10.1 -- You are receiving this mail because: You are the assignee for the bug.

Re: Plasma Browser Integration is in kdereview

2017-06-08 Thread Albert Astals Cid
El dilluns, 5 de juny de 2017, a les 15:42:34 CEST, David Edmundson va escriure: > Hey all, > > We'd like to add project plasma-browser-integration into KDE[0]. I'm not happy how the json is filed only on release time, can you not uses the StaticMessages.sh approach that kdeconnect-android uses

D4799: Delay notifications until desktop session has loaded

2017-06-08 Thread Andrius Štikonas
stikonas added a comment. This introduces a regression https://bugs.kde.org/show_bug.cgi?id=380974 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, dfaure, graesslin Cc: stikonas, pl

Proposed Release Schedule to end 2018

2017-06-08 Thread Jonathan Riddell
Following the meeting this week I've made a proposed release schedule until the end of 2018 Three releases a year (5.11 October 2017, 5.12,5.13,5.14 in 2018) Betas to happen in the week after Frameworks release Three weeks from beta to release 5.12 to be an LTS, discussed with suse and they are fi

D6150: [Notes Applet] Show formatting options when it has focus

2017-06-08 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R114:4c2f9a618047: [Notes Applet] Show formatting options when it has focus (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6150?vs=15281&id=

D5729: #379003: Fix National Geographic POTD provider

2017-06-08 Thread Marco Martin
mart accepted this revision. mart added a comment. go for it REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D5729 To: vitali, sebas, mart Cc: mart, Zren, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, l

D6148: [Icon Applet] Repopulate if URL didn't change

2017-06-08 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6148 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D6150: [Notes Applet] Show formatting options when it has focus

2017-06-08 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D6150 To: broulik, #plasma, #vdg, mart Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterbe

D6150: [Notes Applet] Show formatting options when it has focus

2017-06-08 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D6150 To: broulik, #plasma, #vdg Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6150: [Notes Applet] Show formatting options when it has focus

2017-06-08 Thread Kai Uwe Broulik
broulik updated this revision to Diff 15281. broulik added a comment. - Use `root.Plasmoid.activeFocus` REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6150?vs=15276&id=15281 REVISION DETAIL https://phabricator.kde.org/D6150 AFFECTED FILES applet

D6152: Make every applet its own focus scope

2017-06-08 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:e65d7b98be3f: Make every applet its own focus scope (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6152?vs=15278&id

D6152: Make every applet its own focus scope

2017-06-08 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6152 To: davidedmundson, #plasma, hein Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai

D6150: [Notes Applet] Show formatting options when it has focus

2017-06-08 Thread David Edmundson
davidedmundson added a comment. Seems sensible it doesn't save any space as we anchor the text above the button anyway. INLINE COMMENTS > main.qml:238 > > -PlasmaComponents.ToolButton { > -id: toggleFormatBarButton > -tooltip: i18n("Toggle text format option

D6152: Make every applet its own focus scope

2017-06-08 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Like Loaders an applet should be a focus scope. It allows an applet to set an item to have focus which will then

D6150: [Notes Applet] Show formatting options when it has focus

2017-06-08 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D6150 To: broulik, #plasma, #vdg Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6150: [Notes Applet] Show formatting options when it has focus

2017-06-08 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a lot less cumbersome than manually toggling the formatting button. It ensures clean looks when the applet is not being edited while

D6145: Massively simplify the class DesktopPortal

2017-06-08 Thread Jan Grulich
jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. In https://phabricator.kde.org/D6145#115035, @davidedmundson wrote: > Inhibit should be the same as that uses the virtual object from request.cpp which I haven't touched.

D6148: [Icon Applet] Repopulate if URL didn't change

2017-06-08 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6148 To: broulik, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6148: [Icon Applet] Repopulate if URL didn't change

2017-06-08 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We used to always delete the backing .desktop file if we changed a property in a Link (to a document) hoping that setUrl would call populate.

D6145: Massively simplify the class DesktopPortal

2017-06-08 Thread David Edmundson
davidedmundson added a comment. Inhibit should be the same as that uses the virtual object from request.cpp which I haven't touched. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D6145 To: davidedmundson, #plasma, jgrulich Cc: ap