jgrulich requested changes to this revision.
jgrulich added a comment.
This revision now requires changes to proceed.


  In https://phabricator.kde.org/D6145#115035, @davidedmundson wrote:
  
  > Inhibit should be the same as that uses the virtual object from request.cpp 
which I haven't touched.
  
  
  Ok, I'll test that later. Can you please rename all portals? I would propose 
renaming all (Access, AppChooser, FileChooser ....) to (AccessPortal, 
AppChooserPortal, FileChooserPortal ...) so we can rename all methods to start 
with a capital letter. Then it should magically work.
  
  Btw. thank you for this change,  I had hard times at the very beginning to 
make all interfaces registered under one dbus path.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6145

To: davidedmundson, #plasma, jgrulich
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart, lukas

Reply via email to