Re: Plasma 5.10 voice over text

2017-05-16 Thread Martin Gräßlin
Am 16. Mai 2017 23:25:11 MESZ schrieb "Łukasz Sawicki" : >Hi, > >Here is a script/voice over text for Plasma 5.10 video. It is heavily >based on Plasma 5.10 beta announcement. Please check it for grammar, >typos etc. > >https://notes.kde.org/p/Plasma_5.10_script > >If you think that I missed some

Re: Plasma 5.10 voice over text

2017-05-16 Thread David Edmundson
>Folder View is the default desktop and allows users to put whatever files or folders they want easy access to This explains what it is, it doesn't explain what's changed since the last release. "Folder View is now the default desktop ..." > Software Centre Plasma Search (KRunner) suggests to in

D5886: Use QFormLayout for sliders

2017-05-16 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. well that's a billion times cleaner. INLINE COMMENTS > kgamma.cpp:243 > +form->addRow(gammalabel, gctrl); > +form->addWidget(new QWidget); // extra spacing > +fo

Plasma 5.10 voice over text

2017-05-16 Thread Łukasz Sawicki
Hi, Here is a script/voice over text for Plasma 5.10 video. It is heavily based on Plasma 5.10 beta announcement. Please check it for grammar, typos etc. https://notes.kde.org/p/Plasma_5.10_script If you think that I missed something we should show in our upcoming promo video, please also put it

D5889: Keep QIcon::fromTheme in main thread

2017-05-16 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:92bf5a9828d1: Keep QIcon::fromTheme in main thread (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5889?vs=14602&id=14611 REVISION DE

Re: Broken dependencies: plasma-vault

2017-05-16 Thread Ivan Čukić
Hi Ben, Does this seem ok? Most repos tend to skip specifying frameworks, should they be specified or not? Cheers, Ivan On Tue, May 16, 2017 at 11:17 AM, Ben Cooksley wrote: > Hi all, > > When someone gets a chance can they please correct the dependency > metadata in kde-build-metadata for Plas

D5889: Keep QIcon::fromTheme in main thread

2017-05-16 Thread Martin Flöser
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Eh what? That is not thread save?!? Oh sh*** I didn't expect that. Good catch and a nice solution. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.k

Re: Plasma Vault

2017-05-16 Thread Ivan Čukić
On Sun, May 14, 2017 at 06:28:10PM +0100, Jonathan Riddell wrote: > How do I get Plasma Vault to do anything? I've compiled it and the > Plasmoid has a button saying Create a new vault and nothing else. > Clicking it does nothing. I was told I had to install encfs but > installing that doesn't hel

[kio-extras] [Bug 379902] Samba shares no longer work

2017-05-16 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=379902 Elvis Angelaccio changed: What|Removed |Added Assignee|dolphin-bugs-n...@kde.org |plasma-devel@kde.org Component|gene

D5870: Match subsequences in application runner

2017-05-16 Thread Ronnie Thomas
rthomas marked 3 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D5870 To: rthomas, #plasma Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, lukas

D5870: Match subsequences in application runner

2017-05-16 Thread Ronnie Thomas
rthomas updated this revision to Diff 14603. rthomas added a comment. - Splitting the query using splitRef() instead of split() - Using QLatin1Char(' ') as the separator to split the query CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5870?vs=14559&id=14603 REVISION DETAIL http

D5870: Match subsequences in application runner

2017-05-16 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > rthomas wrote in servicerunner.cpp:203 > Could you explain why would we want to use splitRef instead of split? I'm not > sure I understand the need for it. split copies the strings. splitRef creates references to a location within an exits

D5870: Match subsequences in application runner

2017-05-16 Thread Ronnie Thomas
rthomas added inline comments. INLINE COMMENTS > apol wrote in servicerunner.cpp:101 > use a foreach I'm skipping the first string in strList because that string has already been accounted for relavace right before the call to increaseMatchRelavance. Relevance is incremented by 0.01 only based

D5889: Keep QIcon::fromTheme in main thread

2017-05-16 Thread David Edmundson
davidedmundson updated this revision to Diff 14602. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. simplify a line REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5889?vs=14601&id=14602 BRAN

D5889: Keep QIcon::fromTheme in main thread

2017-05-16 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY QIcon::fromTheme is not thread safe, we can't have it done in the future watcher. We can solve this

[Powerdevil] [Bug 379858] Windows open too small

2017-05-16 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=379858 --- Comment #2 from fr...@hmrt.nl --- Ok, will do. But are you sure? It is happening with almost all apps in plasma. Do they really all make the same mistake? -- You are receiving this mail because: You are the assignee for the bug.

D5887: Remove pid changedSignal in Client::PlasmaWindow

2017-05-16 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:c4caf02a9d4b: Remove pid changedSignal in Client::PlasmaWindow (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5887?vs=14597&id=14599

D5887: Remove pid changedSignal in Client::PlasmaWindow

2017-05-16 Thread Martin Flöser
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R127 KWayland BRANCH asdfasdf REVISION DETAIL https://phabricator.kde.org/D5887 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, #framewo

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-16 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D5872#109962, @hein wrote: > I'm fine with no change signal, but heads-up that libtaskmanager has code connecting to it, so if you remove it from kwayland please also adapt plasma-workspace or the build breaks. I highly su

D5888: Get rid of extra margins

2017-05-16 Thread Alexander Volkov
volkov added a reviewer: Plasma. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D5888 To: volkov, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5888: Get rid of extra margins

2017-05-16 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D5888 AFFECTED FILES kcm/src/kcm_kscreen.cpp kcm/src/widget.cpp To:

D5887: Remove pid changedSignal in Client::PlasmaWindow

2017-05-16 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Verified it it send before the initial_state and adjust tests and docs accordingly TEST PLAN All un

D5886: Use QFormLayout for sliders

2017-05-16 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QFormLayout is more natural for label/widget pairs and allows to have uniform label alignment in different styles. REPOSITORY R100 KGamma

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

2017-05-16 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R98 Breeze for Gtk BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5853 To: asturmlechner, #plasma, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensre

D5748: workaround for correct wayland positioning

2017-05-16 Thread David Edmundson
davidedmundson added a comment. Is it tested on X, Qt 5.7 as well as Qt 5.9 If you want me to do any of those, just ask. INLINE COMMENTS > view.cpp:250 > +} else if (event->type() == QEvent::Hide) { > +delete m_plasmaShellSurface; > } else if (m_plasmaShellSurface && eve

D5885: Don't fix a height of sliders

2017-05-16 Thread Alexander Volkov
This revision was automatically updated to reflect the committed changes. Closed by commit R100:160938ffb3f2: Don't fix a height of sliders (authored by volkov). REPOSITORY R100 KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5885?vs=14593&id=14594 REVISION DETAIL https://ph

D5885: Don't fix a height of sliders

2017-05-16 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R100 KGamma BRANCH fix-sliders-height REVISION DETAIL https://phabricator.kde.org/D5885 To: volkov, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-moh

D5885: Don't fix a height of sliders

2017-05-16 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's a bad practice to use magic constants in code, rely on a style instead. REPOSITORY R100 KGamma BRANCH fix-sliders-height REVISION

D5882: Fix spacing in "Select test picture:" row

2017-05-16 Thread Alexander Volkov
This revision was automatically updated to reflect the committed changes. Closed by commit R100:df98599155db: Fix spacing in "Select test picture:" row (authored by volkov). REPOSITORY R100 KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5882?vs=14585&id=14589 REVISION DETAIL

D5883: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"

2017-05-16 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added subscribers: Dolphin, Konqueror, plasma-devel. REVISION SUMMARY This reverts commit https://phabricator.kde.org/R318:58c5eae1953bbdcf6d4150b21cb7ffdad07a5257. Reasons against

[Powerdevil] [Bug 379858] Windows open too small

2017-05-16 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379858 Christoph Feck changed: What|Removed |Added Version|5.34.0 |unspecified Assignee|notm...@gmail.c

D5882: Fix spacing in "Select test picture:" row

2017-05-16 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R100 KGamma BRANCH fix-layout-spacing REVISION DETAIL https://phabricator.kde.org/D5882 To: volkov, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-moh

D5882: Fix spacing in "Select test picture:" row

2017-05-16 Thread Alexander Volkov
volkov added a reviewer: Plasma. REPOSITORY R100 KGamma REVISION DETAIL https://phabricator.kde.org/D5882 To: volkov, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5882: Fix spacing in "Select test picture:" row

2017-05-16 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use QBoxLayout::addLayout() instead of QLayout::addItem() to add a child layout. It's more preferable and makes Qt use a correct spacing for

D5881: Remove .png extension from icon name in the desktop file

2017-05-16 Thread Alexander Volkov
This revision was automatically updated to reflect the committed changes. Closed by commit R100:879e031097bd: Remove .png extension from icon name in the desktop file (authored by volkov). REPOSITORY R100 KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5881?vs=14583&id=14584 R

D5527: add resize handles on all corners/sides

2017-05-16 Thread David Edmundson
davidedmundson added a comment. I do not appreciate having my major bugs ignored. I will be reverting this. You can try again for 5.11. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5527 To: mart, #plasma, hein, broulik Cc: davidedmundson, broulik, p

D5881: Remove .png extension from icon name in the desktop file

2017-05-16 Thread Alexander Volkov
volkov added a comment. Oh, thanks for fast review. REPOSITORY R100 KGamma BRANCH fix-desktop REVISION DETAIL https://phabricator.kde.org/D5881 To: volkov, davidedmundson, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D5881: Remove .png extension from icon name in the desktop file

2017-05-16 Thread Alexander Volkov
volkov added a reviewer: Plasma. REPOSITORY R100 KGamma BRANCH fix-desktop REVISION DETAIL https://phabricator.kde.org/D5881 To: volkov, davidedmundson, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5881: Remove .png extension from icon name in the desktop file

2017-05-16 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R100 KGamma BRANCH fix-desktop REVISION DETAIL https://phabricator.kde.org/D5881 To: volkov, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreute

D5881: Remove .png extension from icon name in the desktop file

2017-05-16 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R100 KGamma BRANCH fix-desktop REVISION DETAIL https://phabricator.kde.org/D5881 AFFECTED FILES kcmkgamma/kgamma.desktop To: volkov Cc: plas

Re: Breeze Grub does not build

2017-05-16 Thread Harald Sitter
breeze-grub doesn't build anything. never did. On Tue, May 16, 2017 at 11:20 AM, Ben Cooksley wrote: > Hi all, > > It seems Breeze Grub does not have a build system as such, and is > therefore not buildable by the CI system. > > See > https://build-sandbox.kde.org/job/Plasma%20breeze-grub%20kf5-

Breeze Grub does not build

2017-05-16 Thread Ben Cooksley
Hi all, It seems Breeze Grub does not have a build system as such, and is therefore not buildable by the CI system. See https://build-sandbox.kde.org/job/Plasma%20breeze-grub%20kf5-qt5%20SUSEQt5.9/ for more details. Should it be marked as an inactive repository? Cheers, Ben

Broken dependencies: plasma-vault

2017-05-16 Thread Ben Cooksley
Hi all, When someone gets a chance can they please correct the dependency metadata in kde-build-metadata for Plasma Vault? See https://build-sandbox.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20SUSEQt5.9/2/console for more details. Thanks, Ben

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-16 Thread Eike Hein
hein added a comment. No, I don't. libtaskmanager doesn't use PlasmaWindowModel, it uses PlasmaWindow. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5872 To: sebas, #plasma, hein, davidedmundson Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, Zre

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-16 Thread David Edmundson
davidedmundson added a comment. No you don't. You connect via QAIM;: dataChanged which is still there. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5872 To: sebas, #plasma, hein, davidedmundson Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, Zr

D5757: add requestToggleKeepAbove/below

2017-05-16 Thread Marco Martin
mart updated this revision to Diff 14582. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - fix comment REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14581&id=14582 BRANCH arcpatch-D5757 R

D5757: add requestToggleKeepAbove/below

2017-05-16 Thread Marco Martin
mart marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D5757: add requestToggleKeepAbove/below

2017-05-16 Thread Marco Martin
mart updated this revision to Diff 14581. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - fix comment REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14320&id=14581 BRANCH arcpatch-D5757 R