D5515: Update the ungrabMouse hack for Qt 5.8

2017-04-24 Thread Anthony Fieroni
anthonyfieroni added a comment. David, it's sould be done in plasma-framework too. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5515 To: davidedmundson, #plasma, mart Cc: anthonyfieroni, mvourlakos, plasma-devel, #frameworks, spstarr, progwolff,

D5574: Don't set ItemHasContents in DropArea

2017-04-24 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D5574 To: davidedmundson, #plasma, aacid Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 726 - Still Unstable!

2017-04-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/726/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Apr 2017 03:46:15 + Build duration: 9 min 17 sec CHANGE SET Revision 563efe89c6e957b3ba8ab81b7ca4bc

D5574: Don't set ItemHasContents in DropArea

2017-04-24 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY ItemHasContents means we get included in generating the QSG node treeview when we render. This item doesn't

D5573: Don't accept hover events in the DragArea

2017-04-24 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY We don't actually process hoverEnter/move events, so there's no need to have the overhead of having them sent to

Re: failing build tests

2017-04-24 Thread David Edmundson
The following two just appstream bugs: plasma-workspace plasma-desktop They're not fixable without breaking translations, nor are they big issues.

D5262: Animate quick tiling outline

2017-04-24 Thread Ken Vermette
kvermette accepted this revision. kvermette added a comment. The movement clearly shows that the window will resize better than a strict fade. +1! On a side note, and this may be a separate revision to consider later, but we may want to animate the transition as you move a window along t

Re: failing build tests

2017-04-24 Thread Martin Gräßlin
Am 2017-04-24 20:53, schrieb Martin Gräßlin: Am 2017-04-24 18:26, schrieb Jonathan Riddell: In master kscreenlocker and plasma-integration are also broken while kwin is pleasingly green In case of kwin I must say that Plasma 5.9 had never been green, but the same state on master when it bran

D5540: Add a KSharedConfigPtr for kcminputrc to KWin::Application

2017-04-24 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:857d8a9c37c6: Add a KSharedConfigPtr for kcminputrc to KWin::Application (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5540?vs=13691&id=13762

D5452: Handle modifier updates in the same sequence as Wayland does

2017-04-24 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:a039c2760f64: Handle modifier updates in the same sequence as Wayland does (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5452?vs=13444&id=137

D5262: Animate quick tiling outline

2017-04-24 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5262 To: broulik, #vdg, #plasma, #kwin, graesslin Cc: fabianr, graesslin, plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed, jen

Re: failing build tests

2017-04-24 Thread Martin Gräßlin
Am 2017-04-24 18:26, schrieb Jonathan Riddell: In master kscreenlocker and plasma-integration are also broken while kwin is pleasingly green In case of kwin I must say that Plasma 5.9 had never been green, but the same state on master when it branched was green. To me it looks like a false

D5186: Add a widget style chooser to oxygen-demo

2017-04-24 Thread René J . V . Bertin
rjvbb abandoned this revision. rjvbb added a comment. Closed with commit https://commits.kde.org/oxygen/3677f75e956e1946cd0ee775ff2969d0b2ecf1c7 REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5186 To: rjvbb, hpereiradacosta Cc: plasma-devel, #plasma, spstarr,

D5186: Add a widget style chooser to oxygen-demo

2017-04-24 Thread René J . V . Bertin
rjvbb set the repository for this revision to R113 Oxygen Theme. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5186 To: rjvbb, hpereiradacosta Cc: plasma-devel, #plasma, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5186: Add a widget style chooser to oxygen-demo

2017-04-24 Thread René J . V . Bertin
rjvbb updated this revision to Diff 13755. rjvbb added a comment. Final version. Most of the forward declarations were actually redundant. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5186?vs=13702&id=13755 REVISION DETAIL https://phabricator.kde.org/D5186 AFFECTED FILES ksty

failing build tests

2017-04-24 Thread Jonathan Riddell
The high gods of KDE have made it tricky to release tars unless the build is marked as green in build.kde.org "WARN -- ReleaseMe::Release: build.kde.org: libkscreen Plasma-5.9 stable-kf5-qt5 is not of sufficient quality https://build.kde.org/job/libkscreen%20Plasma-5.9%20stable-kf5-qt5/"; Plas

D5547: Prevent kcheckpass from becoming an orphan

2017-04-24 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R133:c5e49e466e48: Prevent kcheckpass from becoming an orphan (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5547?vs=13712&id=13754 REVIS

D5570: Update unit test to match change to reselecting top entry

2017-04-24 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY https://phabricator.kde.org/R120:37014e643cec4ee9aed54421f66c675e1bc91b70 introduced a change in the behaviour of what happens when y

D5569: thumbnail ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten
marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the thumbnail ioslave and therefore, along with the previously s

D5568: SFTP ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten
marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the SFTP ioslave. TEST PLAN Built kio-extras with this change

D5567: Settings ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten
marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the settings ioslave. TEST PLAN Built kio-extras with this ch

D5515: Update the ungrabMouse hack for Qt 5.8

2017-04-24 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:29f1ee385891: Update the ungrabMouse hack for Qt 5.8 (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5515?vs=13747&i

D5566: recentdocuments ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten
marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the recentdocuments ioslave. TEST PLAN Built kio-extras with

D5515: Update the ungrabMouse hack for Qt 5.8

2017-04-24 Thread David Edmundson
davidedmundson updated this revision to Diff 13747. davidedmundson added a comment. Rewrote with a runtime check and a link to a qt bug report REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5515?vs=13609&id=13747 BRANCH origin-master (

D5565: Network ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten
marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the network ioslave. TEST PLAN Built kio-extras with this cha

D5564: Man ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten
marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the man ioslave and the man2html converter. TEST PLAN Built k

D5562: Fish ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten
marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the ioslave. TEST PLAN Built kio-extras with this change, che

Re: [KWin Quest. - Update] - KWin authorize external docks to manipulate tasks and windows

2017-04-24 Thread Marco Martin
On Saturday 22 April 2017, Michail Vourlakos wrote: > Just a few statements from the Latte developement team... > We try to use only kde frameworks and plasma libraries, and this is a > strict design decision for us as we are calling ourselves kde. We dont > want to break kwin experience in any mea

D5561: Filter ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten
marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the filter-based ioslaves: bzip/bzip2, gzip, lzma, xz TEST PLAN

D5560: Archive ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten
marten added a comment. Also: Install KIOArchive library with LIBRARY NAMELINK_SKIP so that clients will depend on major soversion, as suggested by jriddell. Make major soversion number the same as first part of full version, for consistency. REPOSITORY R320 KIO Extras REVISION DETAIL

D5560: Archive ioslave: Port away from KDELibs4Support

2017-04-24 Thread Jonathan Marten
marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change removes the build and runtime requirement for KDELibs4Support from the archive-based ioslaves (ar, tar and zip). TEST PLAN Built

D5527: add resize handles on all corners/sides

2017-04-24 Thread David Edmundson
davidedmundson added a comment. Bug 3: Snapping to the grid is now wrong. Before we would drag only from the right, so it would adjust the width to snap to the grid size. That works Now we can drag from the left, when you resize something past the grid size, it will leave the left w

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 725 - Still Unstable!

2017-04-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/725/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 24 Apr 2017 12:20:47 + Build duration: 15 min CHANGE SET Revision 0a8d8b6d1a2974c968332adcfc1b6c042bd8

D5527: add resize handles on all corners/sides

2017-04-24 Thread David Edmundson
davidedmundson added a comment. When you are in edit mode (clicking on toolbox), the handles on the right don't work. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5527 To: mart, #plasma, hein, broulik Cc: davidedmundson, broulik, plasma-devel, spstarr, pro

D5527: add resize handles on all corners/sides

2017-04-24 Thread Kai Uwe Broulik
broulik accepted this revision. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D5527 REVISION DETAIL https://phabricator.kde.org/D5527 To: mart, #plasma, hein, broulik Cc: broulik, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5527: add resize handles on all corners/sides

2017-04-24 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R119:0a8d8b6d1a29: add resize handles on all corners/sides (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5527?vs=13737&id=13738 REVISION DET

D5547: Prevent kcheckpass from becoming an orphan

2017-04-24 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker BRANCH kcheckpass-no-orphan REVISION DETAIL https://phabricator.kde.org/D5547 To: graesslin, #plasma, mart Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterb

D5527: add resize handles on all corners/sides

2017-04-24 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D5527 REVISION DETAIL https://phabricator.kde.org/D5527 To: mart, #plasma, hein Cc: broulik, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterb

D5527: add resize handles on all corners/sides

2017-04-24 Thread Marco Martin
mart updated this revision to Diff 13737. mart added a comment. hide handles when blocked and for applets w/o background REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5527?vs=13650&id=13737 BRANCH arcpatch-D5527 REVISION DETAIL https://phabric

Minutes Monday Plasma Meeting

2017-04-24 Thread Eike Hein
We had the meety-meets, and them be the results! Cheerio, Eike Plasma Team meeting, 2017-04-24 Present: notmart, kbroulik, bshah, Riddell, Sho_, romangg, d_ed notmart: * mouse down (eaten events) finally merged in Qt * redesigning of color scheme kcm, add "current color scheme back for https:/

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 724 - Still Unstable!

2017-04-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/724/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 24 Apr 2017 12:00:02 + Build duration: 6 min 1 sec CHANGE SET Revision 68e4be707e2402ddb623bc70043731a

D5558: [Applet Appearance] Allow moving applets with Alt+left-click

2017-04-24 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:68e4be707e24: [Applet Appearance] Allow moving applets with Alt+left-click (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5558?vs=1373

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 723 - Still Unstable!

2017-04-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/723/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 24 Apr 2017 10:42:20 + Build duration: 15 min CHANGE SET Revision 7ff13bc0f73964e6374a87003bf85ee00bc1

D5558: [Applet Appearance] Allow moving applets with Alt+left-click

2017-04-24 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5558 To: broulik, #plasma, davidedmundson Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

D5558: [Applet Appearance] Allow moving applets with Alt+left-click

2017-04-24 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Makes them behave like windows and saves power users the press-and-hold dance. TEST PLAN Held Alt key, started dragging applet, it moved aro

D5186: Add a widget style chooser to oxygen-demo

2017-04-24 Thread Hugo Pereira Da Costa
hpereiradacosta requested changes to this revision. hpereiradacosta added a comment. This revision now requires changes to proceed. Implementation wise, perfect ! Some minor comments to be fixed, then ship it ! Thanks for the patch INLINE COMMENTS > oxygenstylechooser.cpp:37 > +#includ

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 867 - Still Unstable!

2017-04-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/867/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 24 Apr 2017 09:48:14 + Build duration: 6 min 3 sec CHANGE SET Revision 1c8a46791c4eda644920fd0b6abb6

D5527: add resize handles on all corners/sides

2017-04-24 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > AppletAppearance.qml:609 > +//sides > +ResizeHandle { > +anchors { The handles should be hidden if widgets are locked, otherwise you get the cursors but cannot actually do anything. REPOSITORY R119 Plasma Desktop REVISION DETA

D5522: Introduce a concept of runtime executables that can be ignored.

2017-04-24 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1c8a46791c4e: Introduce a concept of runtime executables that can be ignored. (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5522?vs=13

D5452: Handle modifier updates in the same sequence as Wayland does

2017-04-24 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH modifiers-after-key REVISION DETAIL https://phabricator.kde.org/D5452 To: graesslin, #plasma, #kwin, mart Cc: stikonas, plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed

D5540: Add a KSharedConfigPtr for kcminputrc to KWin::Application

2017-04-24 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. cleanliness++ REPOSITORY R108 KWin BRANCH input-config REVISION DETAIL https://phabricator.kde.org/D5540 To: graesslin, #kwin, #plasma, mart Cc: mart, plasma-devel, kwin, spstarr, progw

D5262: Animate quick tiling outline

2017-04-24 Thread Kai Uwe Broulik
broulik updated this revision to Diff 13729. broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Use moveResizeGeometry() REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5262?vs=13023&id=13729 REVISION DETAIL https:

D5548: KCM: Fix 100% volume label position with RTL

2017-04-24 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D5548 To: drosca, #plasma, mart Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterb

D5522: Introduce a concept of runtime executables that can be ignored.

2017-04-24 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D5522 To: hein, #plasma, davidedmundson, broulik Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensr

D5551: Make WindowSwitching (Alt+Tab) the default left touch screen edge

2017-04-24 Thread Marco Martin
mart accepted this revision. REPOSITORY R108 KWin BRANCH tabbox-default-edge-left REVISION DETAIL https://phabricator.kde.org/D5551 To: graesslin, #kwin, #plasma, ivan, mart Cc: plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apo

D5527: add resize handles on all corners/sides

2017-04-24 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D5527#104226, @broulik wrote: > 10 years I have waited for this \o/ > > Isn't the resize button on the applet a bit redundant then? I wouldn't mind it staying so we keep a discoverable button for that but I'm wondering. > One dow

D5527: add resize handles on all corners/sides

2017-04-24 Thread Kai Uwe Broulik
broulik added a comment. 10 years I have waited for this \o/ Isn't the resize button on the applet a bit redundant then? I wouldn't mind it staying so we keep a discoverable button for that but I'm wondering. One down side is that it makes it harder to move applets, many you could drag