D5203: Add support for interactive selection through touch events

This revision was automatically updated to reflect the committed changes. Closed by commit R108:67295336e57c: Add support for interactive selection through touch events (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5203?vs=12879&id=13015

D5225: [slidingpopups] Only remove WindowClosedGrabRole if the effect owns the grab

This revision was automatically updated to reflect the committed changes. Closed by commit R108:49fc31059433: [slidingpopups] Only remove WindowClosedGrabRole if the effect owns the grab (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5225

D3498: Add scaling to DRM backend

subdiff added inline comments. INLINE COMMENTS > drm_output.cpp:104 > { > -return QRect(m_globalPos, size()); > +return QRect(m_globalPos, pixelSize() / scale()); > } Instead of dividing on every call, declare new private variable `QSize m_scaledSize = pixelSize() / scale()`, and upda

D3504: Implment DRM EGL scaling

subdiff added inline comments. INLINE COMMENTS > egl_gbm_backend.cpp:198 > +qreal scale = output.output->scale(); > +glViewport(-v.x(), v.height() - overall.height() - v.y(), > overall.width() * scale, overall.height() * scale); > return true; I still don't think this is the right

D5250: cursors: Make build scripts more generic; build more sizes

subdiff added a comment. Yea, this fixed the problem. Great! I built it and installed the cursors now. They are also all correctly listed in the cursortheme KCM (`kcmshell5 cursortheme`) and I was able to select them all individually. I've seen only two problems : - On auto resoluti

D5255: [Task Manager] Keep entry highlighted when context menu or group dialog is open

broulik added a comment. > This must be a recent regression - it worked before. I think that was even me adding the Places stuff, I re-arranged some context menu stuff and accidentally caused the `property QtObject contextMenu` to become unused. REPOSITORY R119 Plasma Desktop REVISIO

D5255: [Task Manager] Keep entry highlighted when context menu or group dialog is open

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. This must be a recent regression - it worked before. -1 on the tooltip thing, too much noise. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5255 To: brou

D3498: Add scaling to DRM backend

subdiff added a comment. Regarding all your Diffs about Scaling, that you haven't yet merged: Can you edit the Related Revisions in Phab, so it's easier to review them? For example for this diff here https://phabricator.kde.org/D3159 is needed. REPOSITORY R108 KWin REVISION DETAIL https

D5169: Port away from KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R102:fab046273c6a: Port away from KDELibs4Support (authored by rthomsen). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5169?vs=12793&id=13010 REVISION DETAIL ht

D5254: better layout and animate keyboard

mart added a comment. In https://phabricator.kde.org/D5254#99062, @apol wrote: > In https://phabricator.kde.org/D5254#99012, @mart wrote: > > > before: F3437115: keyboardwrong.png > > > > after: F3437117: keyboardok1.png

D5254: better layout and animate keyboard

graesslin added a comment. making the keyboard smaller is difficult as qt tries to be too smart. One can only specify the width. There is no control over the height. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5254 To: mart, #plasma, davidedmundson, gra

D5250: cursors: Make build scripts more generic; build more sizes

jamesl marked 2 inline comments as done. jamesl added a comment. @subdiff, can you try running: LC_ALL=C ./build.sh If that works I'll update the script. Otherwise, do you have a better suggestion on how to perform the calculations around line 44: newxhot=$(printf '%.0f' $(

D5242: fixes for plasmawindowed sni support

This revision was automatically updated to reflect the committed changes. mart marked 2 inline comments as done. Closed by commit R120:bf19dbba136e: fixes for plasmawindowed sni support (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5242?vs=12999&id=13009#toc REPOSITO

D5254: better layout and animate keyboard

mart added a comment. In https://phabricator.kde.org/D5254#99062, @apol wrote: > In https://phabricator.kde.org/D5254#99012, @mart wrote: > > > before: F3437115: keyboardwrong.png > > > > after: F3437117: keyboardok1.png

D5254: better layout and animate keyboard

apol added a comment. In https://phabricator.kde.org/D5254#99012, @mart wrote: > before: F3437115: keyboardwrong.png > > after: F3437117: keyboardok1.png > > even less space: do without user list F3437120

D5257: [Windowed Widgets Runner] Fix mimeDataForMatch

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5257 To: broulik, #plasma, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5257: [Windowed Widgets Runner] Fix mimeDataForMatch

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes dragging a windowed widgets runner result on the desktop or panel to create an applet. TEST PLAN Typed "fifteen", got "Windowed

D5247: [ModelContextMenu] Silence warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R242:edb05ef98983: [ModelContextMenu] Silence warnings (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5247?vs=12985&id=13004 R

D5246: [Color Picker] Try to parse color from text drop

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D5246 To: broulik, #plasma, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5247: [ModelContextMenu] Silence warnings

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5247 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D5255: [Task Manager] Keep entry highlighted when context menu or group dialog is open

subdiff added a comment. Good idea! Maybe also when task tooltip open? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5255 To: broulik, #plasma, #vdg, hein Cc: subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5256: [Notifications] Port from ProcessRunner to KCMShell.open and respect KIOSK restriction

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Still works, when I place the following in kdeglobals the entry disappears [KDE Control Module Restrictions] kcmnotify.desktop=false REPOS

D5255: [Task Manager] Keep entry highlighted when context menu or group dialog is open

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This makes it easier to see what item the menu or popup is for. In fact, the item should have stayed highlighted when the context menu is op

D5242: fixes for plasmawindowed sni support

davidedmundson accepted this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5242 To: mart, apol, davidedmundson Cc: apol, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D5254: better layout and animate keyboard

mart added inline comments. INLINE COMMENTS > Login.qml:15 > > +//the y position that should be ensured visible when the on screen > keyboard is visible > +property int visibleBoundary: mapFromItem(loginButton, 0, 0).y together with https://phabricator.kde.org/D4893, this property ma

D5254: better layout and animate keyboard

mart added a comment. before: F3437115: keyboardwrong.png after: F3437117: keyboardok1.png even less space: do without user list F3437120: keyboardok2.png REPOSITORY

D5254: better layout and animate keyboard

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Similar to https://phabricator.kde.org/D4893, use a state machine to track the status of the keyboard and animate the open/close. this improv

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

rikmills added a comment. Checked appearance on 'fixed' Firefox 55 nightly. No apparent regressions with those upstream changes and this change as far as I can see. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D5128 To: rikmills, #plasma Cc: elvisangelaccio,

D5242: fixes for plasmawindowed sni support

mart updated this revision to Diff 12999. mart added a comment. use QPointer REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5242?vs=12970&id=12999 BRANCH arcpatch-D5242 REVISION DETAIL https://phabricator.kde.org/D5242 AFFECTED FILES plasm