subdiff added inline comments.

INLINE COMMENTS

> egl_gbm_backend.cpp:198
> +    qreal scale = output.output->scale();
> +    glViewport(-v.x(), v.height() - overall.height() - v.y(), 
> overall.width() * scale, overall.height() * scale);
>      return true;

I still don't think this is the right way to use scale here. But it's currently 
not possible to test it with scale > 1, is it? I tried to use the `scale` 
option from https://phabricator.kde.org/D3159, but `initialOutputScale` is 
currently only available for X11WindowedBackend. Can you make the test option 
usable in the DRM backend as well? This won't test different scale factors on 
multiple monitors though.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3504

To: davidedmundson, graesslin, #plasma
Cc: #kwin, subdiff, graesslin, plasma-devel, kwin, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Reply via email to