This revision was automatically updated to reflect the committed changes.
Closed by commit R108:0bb587dcb9de: Ensure
PointerInputRedirection::processMotion finishes prior to warping (authored by
graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5182?vs=
bshah accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
position-update-blocker
REVISION DETAIL
https://phabricator.kde.org/D5182
To: graesslin, #kwin, #plasma, bshah
Cc: anthonyfieroni, plasma-devel, kwin, progwolff, lesliezhai, ali-moha
anthonyfieroni added inline comments.
INLINE COMMENTS
> graesslin wrote in pointer_input.cpp:234-236
> No it is fine. You need to look at the big picture. This will invoke the
> first queued element for processMotion. Which in turn creates a new blocker
> and when going out of processMotion the
ivanthekdefan added a task: T5743: Update the KDE Plasma documentation.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5189
To: ivanthekdefan, ltoscano, lueck, yurchor
Cc: kde-doc-english, plasma-devel, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts,
graesslin added inline comments.
INLINE COMMENTS
> subdiff wrote in authenticator.h:63
> Can we only use the enum class in Authenticator, instead of duplicating it
> here?
I don't like using enums defined in other classes. But moving it a level up
into the namespace would be an option.
> subd
graesslin added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in pointer_input.cpp:234-236
> This can lead to strange side effect
>
> 1. isPositionBlocked == true
> 2. s_scheduledPositions.size() > 1
> 3. isPositionBlocked == false
> 4. s_scheduledPositions.size() - 1 but still not 0
>
anthonyfieroni added inline comments.
INLINE COMMENTS
> pointer_input.cpp:234-236
> +if (!s_scheduledPositions.isEmpty()) {
> +const auto pos = s_scheduledPositions.takeFirst();
> +m_pointer->processMotion(pos.pos, pos.delta,
> pos.deltaNonAccelerated,
ivanthekdefan added a subscriber: kde-doc-english.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5189
To: ivanthekdefan, ltoscano, lueck, yurchor
Cc: kde-doc-english, plasma-devel, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
ivanthekdefan edited the summary of this revision.
ivanthekdefan edited the test plan for this revision.
ivanthekdefan added reviewers: ltoscano, lueck, yurchor.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5189
To: ivanthekdefan, ltoscano, lueck, yurchor
Cc: p
ivanthekdefan created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Partial rewrite, adding and updating info
TEST PLAN
Documentation, needs constructive criticism
REPOSITORY
R119 Plasma Desktop
BRA
subdiff added inline comments.
INLINE COMMENTS
> authenticator.h:63
> public:
> -explicit KCheckPass(const QString &password, QObject *parent = nullptr);
> +enum class AuthenticationMode {
> +Delayed,
Can we only use the enum class in Authenticator, instead of duplicating it her
rjvbb created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This adds the widget style chooser evoked during the colour scheme chooser
review (https://phabricator.kde.org/D5113).
REPOSITORY
R113 Oxygen
subdiff added inline comments.
INLINE COMMENTS
> kcheckpass.c:263
> char *msg;
> GSendStr (prompt);
> msg = GRecvStr ();
This line (and `GSendArr(len, prompt)` above) writes (in case of shadow auth 0)
to the socket, which should lead to `reapVerify()` being called and the sock
graesslin added a comment.
> FYI, if you want to check via SDDM
> sddm-greeter --test-mode --theme /opt/kde5/share/sddm/themes/breeze/
That one I had tried with the env variable and it worked fine.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/
davidedmundson added a comment.
Bah. Thanks for investigating. Ah well, you didn't expect it work OOTB
anyway...so it's no worse, and I can get this into 0.14.1 rather than it being
a new feature.
Upstream request.
https://github.com/sddm/sddm/pull/803
FYI, if you want to check vi
graesslin added a comment.
In https://phabricator.kde.org/D4806#97649, @subdiff wrote:
> In https://phabricator.kde.org/D4806#97351, @graesslin wrote:
>
> > reapVerify seems to me to be only if the communication horribly breaks.
>
>
> I don't think that's the case, because otherw
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:78d2c9ffbed6: [sddm-theme] Add virtual keyboard support
(authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5061?vs=12503&id=12825#toc
REPOSITORY
R120 Plasma Workspace
C
graesslin added a comment.
I'm going to push nevertheless. A little bit sad, that it doesn't work OOTB,
but well...
INLINE COMMENTS
> davidedmundson wrote in Main.qml:174
> I don't get what this property is all about?
>
> Does Qt.inputMethod.visible start off true, and you're effectively ma
graesslin added a comment.
yep, does not work: sddm/src/daemon/greeter.cpp - setting QT_IM_MODULE is
only done in the branch if (daemonApp->testing())
REPOSITORY
R120 Plasma Workspace
BRANCH
sddm-them-virtualkeyboard
REVISION DETAIL
https://phabricator.kde.org/D5061
To: graesslin, #p
graesslin added a comment.
and just for reference:
sddm --example-config
[Autologin]
# Whether sddm should automatically log back into sessions when they exit
Relogin=false
# Name of session file for autologin session (if empty try last logged in)
Session=
subdiff added a comment.
In https://phabricator.kde.org/D4806#97351, @graesslin wrote:
> reapVerify seems to me to be only if the communication horribly breaks.
I don't think that's the case, because otherwise greeter could've never read
in the exit code of kcheckpass on current m
graesslin added a comment.
In https://phabricator.kde.org/D5061#96641, @davidedmundson wrote:
> FYI, SDDM requires only a config change. We added support a while back.
are you sure that works? I added the config and QT_IM_MODULE is not getting
added to the environment of sddm-gree
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Consider the following situation: we have three InputEventFilter linked
in the sequence A - B - C.
The input filters are processing
On Sunday, 19 March 2017 at 16:22, Martin Gräßlin wrote:
> Am 2017-03-19 14:19, schrieb Kai Uwe Broulik:
> > I'd be fine with splitting drkonqi into its own repository, René
> > recently brought this up as well.
>
> Ideally it would be part of KF5, e.g. a kcrash-runtime tier-3 repo.
So how should
graesslin added a comment.
the accepted still holds :-)
BRANCH
scaling_final
REVISION DETAIL
https://phabricator.kde.org/D5172
To: davidedmundson, #plasma, graesslin
Cc: graesslin, markg, plasma-devel, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
PS: I don't really have an opinion about this: is it wrong for a window manager
to ignore the fact that a window/application uses a different palette? I don't
know any other WM (*) that adapts its decoration palette automatically to each
decorated window's palette.
I could easily image a categor
Hi,
What's the best way to detect >at the level of a style's menu rendering
methods< whether or not the application or even the widget in question uses a
different palette than the current desktop colour palette? I have a draft
method which works fine where I want it to but tends to trigger in
27 matches
Mail list logo
