anthonyfieroni added inline comments.

INLINE COMMENTS

> pointer_input.cpp:234-236
> +            if (!s_scheduledPositions.isEmpty()) {
> +                const auto pos = s_scheduledPositions.takeFirst();
> +                m_pointer->processMotion(pos.pos, pos.delta, 
> pos.deltaNonAccelerated, pos.time, pos.timeUsec, nullptr);

This can lead to strange side effect

1. isPositionBlocked == true
2. s_scheduledPositions.size() > 1
3. isPositionBlocked == false
4. s_scheduledPositions.size() - 1 but still not 0

In next block/unblock will be triggered pertty old motion event, no? Maybe it's 
better to steal all blocked events except last one.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5182

To: graesslin, #kwin, #plasma
Cc: anthonyfieroni, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol

Reply via email to