D5137: Add support for screenedge touchscreen events through XInput 2.2

graesslin updated this revision to Diff 12714. graesslin marked an inline comment as done. graesslin added a comment. Addressed David's comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5137?vs=12701&id=12714 BRANCH screenedge-touch-xinput REVISION DETAIL https://phabrica

D5137: Add support for screenedge touchscreen events through XInput 2.2

graesslin marked 2 inline comments as done. graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in xinputintegration.cpp:188 > what's this for? left over from previous approach. REVISION DETAIL https://phabricator.kde.org/D5137 To: graesslin, #plasma, #kwin Cc: davidedmun

T5412: Improve Plasma PA usability

Zren added a comment. I made https://phabricator.kde.org/D5144 which turns the volume icon/mute button into a ToolButton. TASK DETAIL https://phabricator.kde.org/T5412 To: Zren Cc: davidk, vpilo, Zren, broulik, #vdg, plasma-devel, #plasma, subdiff, drosca, progwolff, lesliezhai, ali-moham

D5144: Change the volume icon/mute button into a ToolButton

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds a hover effect so the user knows it's a button. Unlike the application-menu button, I didn't add the smallSpacing around it so it'

T5412: Improve Plasma PA usability

Zren added a comment. Breeze's 16px small microphone-sensitivity-[low/medium/high] icons do not follow the color scheme. The 16px `-muted`, which is a softlink to the `mic-off.svg` icon is okay. This is because the `style="color:#4d4d4d;..."` which overrides the `fill:currentColor`. We'll ne

D5137: Add support for screenedge touchscreen events through XInput 2.2

davidedmundson added a comment. cool INLINE COMMENTS > xinputintegration.cpp:132 > +m_lastTouchPosition = touchPosition; > +m_lastTouchPositions.insert(m_trackingTouchId, > touchPosition); > +} I think we want to always update m_lastTouchPositions

D5106: Add support for activating screenedges through touch swipe gestures

davidedmundson accepted this revision. This revision is now accepted and ready to land. BRANCH screenedge-touch REVISION DETAIL https://phabricator.kde.org/D5106 To: graesslin, #kwin, #plasma_on_wayland, davidedmundson Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, je

D5086: Applet: Add Raise maximum volume action to context menu

Zren added a comment. Looks good. F3126554: 2017-03-22___20-56-01.png There's one issue I want to point out that I dealt with, is that other instances of the widget won't be in the "raised" state (eg: other screens). Example: https://stream

D4799: Delay notifications until desktop session has loaded

This revision was automatically updated to reflect the committed changes. Closed by commit R289:2d40672b0c85: Do not remove queued notifications when the fd.o service starts. Also start the… (authored by vpilo). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde

D4963: Add scaling support into BlurEffect::doBlur

davidedmundson updated this revision to Diff 12710. davidedmundson added a comment. Oh I see, rather than grabbing two texels and interpolating the average value you're sampling between them and letting the GL return the relevant value. My previous code would break that as I was effectiv

D5106: Add support for activating screenedges through touch swipe gestures

graesslin added a dependent revision: D5137: Add support for screenedge touchscreen events through XInput 2.2. REVISION DETAIL https://phabricator.kde.org/D5106 To: graesslin, #kwin, #plasma_on_wayland Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abett

D5097: Add support for global touchpad swipe gestures

graesslin added a dependent revision: D5137: Add support for screenedge touchscreen events through XInput 2.2. REVISION DETAIL https://phabricator.kde.org/D5097 To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas

D5137: Add support for screenedge touchscreen events through XInput 2.2

graesslin added dependencies: D5106: Add support for activating screenedges through touch swipe gestures, D5097: Add support for global touchpad swipe gestures. REVISION DETAIL https://phabricator.kde.org/D5137 To: graesslin, #plasma, #kwin Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed

D5137: Add support for screenedge touchscreen events through XInput 2.2

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change extends the XInputEventFilter to also listen for all touch events on the root window. The touch points are passed to the n

Re: proposal: make plasma *not* build with Qt 5.8.0

Am 2017-03-22 17:01, schrieb Luca Beltrame: In data mercoledì 22 marzo 2017 16:51:54 CET, Martin Gräßlin ha scritto: So if we have more issues we should tell distros about it. It just makes all of us look bad if there are known issues and distros ship it without better knowledge. Given tha

Re: proposal: make plasma *not* build with Qt 5.8.0

On 22/03/2017 05:51 μμ, Martin Gräßlin wrote: Am 2017-03-22 14:37, schrieb Marco Martin: Hi all, I'm seeing lately many new crash reports in bugzilla which are with Qt 5.8.0, and some even backtraces that i never seen. Knowing the big problems that Qt 5.8.0 had, I've come to thinking that to

Re: proposal: make plasma *not* build with Qt 5.8.0

In data mercoledì 22 marzo 2017 16:51:54 CET, Martin Gräßlin ha scritto: > So if we have more issues we should tell distros about it. It just makes > all of us look bad if there are known issues and distros ship it without > better knowledge. Given that Qt doesn't want to release 5.8.1 before 5.9

Re: proposal: make plasma *not* build with Qt 5.8.0

Am 2017-03-22 14:37, schrieb Marco Martin: Hi all, I'm seeing lately many new crash reports in bugzilla which are with Qt 5.8.0, and some even backtraces that i never seen. Knowing the big problems that Qt 5.8.0 had, I've come to thinking that to make even more obvious that 5.8.0 is discourage

D5061: [sddm-theme] Add virtual keyboard support

graesslin added a comment. > It's worth testing natively as opposed to qmlscene because components loading can be a bit weird because of paths. will do! Wasn't aware that it's possible to use qtvirtualkeyboard already. That was the missing piece for testing. REPOSITORY R120 Plasma Wor

T5412: Improve Plasma PA usability

subdiff added a comment. @drosca: Could you quickly tell how this task has developed until now and what should be done next in your opinion? TASK DETAIL https://phabricator.kde.org/T5412 To: subdiff Cc: davidk, vpilo, Zren, broulik, #vdg, plasma-devel, #plasma, subdiff, drosca, progwolff,

Re: proposal: make plasma *not* build with Qt 5.8.0

On Wed, Mar 22, 2017 at 3:48 PM, Marco Martin wrote: > On Wednesday 22 March 2017, Aleix Pol wrote: >> > >> > -- >> > Marco Martin >> >> -1 >> >> If there's regressions they should be properly upstreamed. We need to >> work together, not entrench us... :( > > I was only referring to specific 5.8.0

Re: proposal: make plasma *not* build with Qt 5.8.0

On Wednesday 22 March 2017, Aleix Pol wrote: > > > > -- > > Marco Martin > > -1 > > If there's regressions they should be properly upstreamed. We need to > work together, not entrench us... :( I was only referring to specific 5.8.0 release, not anything more recent, but all points taken, yep,

Re: proposal: make plasma *not* build with Qt 5.8.0

On Wed, Mar 22, 2017 at 2:37 PM, Marco Martin wrote: > Hi all, > I'm seeing lately many new crash reports in bugzilla which are with Qt 5.8.0, > and some even backtraces that i never seen. > Knowing the big problems that Qt 5.8.0 had, I've come to thinking that to make > even more obvious that 5.8

D4799: Delay notifications until desktop session has loaded

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, graesslin, mck182 Cc: plasma-devel, davidedmundso

D4799: Delay notifications until desktop session has loaded

vpilo added a comment. Ping [my excuses if it's not good practice to do so] REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, graesslin, mck182 Cc: plasma-devel, davidedmundson,

D5085: [DrKonqi] Drop "It is safe to close this dialog if you don't want to report a bug"

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. makes sense REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5085 To: broulik, #plasma, mart Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensre

Re: proposal: make plasma *not* build with Qt 5.8.0

Qt 5.8 also fixes multiple bugs, like the infamous one in the delegate model. We got more of them than we do of setVisibleRecur or any of the other 5.8 bugs. Also if Qt 5.8 does introduce new bugs, it's our job to bloody well fix them. David

Re: proposal: make plasma *not* build with Qt 5.8.0

In data mercoledì 22 marzo 2017 14:37:27 CET, Marco Martin ha scritto: > Knowing the big problems that Qt 5.8.0 had, I've come to thinking that to > make even more obvious that 5.8.0 is discouraged, to make cmake fail in -1, this makes things unnecessarily complicated for downstreams. -- Luca

proposal: make plasma *not* build with Qt 5.8.0

Hi all, I'm seeing lately many new crash reports in bugzilla which are with Qt 5.8.0, and some even backtraces that i never seen. Knowing the big problems that Qt 5.8.0 had, I've come to thinking that to make even more obvious that 5.8.0 is discouraged, to make cmake fail in plasma- workspace wit

D4806: [greeter] Send the auth result through the server instead return value

subdiff added a comment. Since there seem to be not many others I'll try to give you reviews for this and your following patches, but first I've to understand this stuff. Tell me if the following is right: Until now the greeter waited for the exit code of the forked process with the

D5127: Switch to newer KDevelop API

kossebau removed a reviewer: kossebau. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D5127 To: jriddell, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5127: Switch to newer KDevelop API

kossebau removed a reviewer: kossebau. kossebau added a comment. @jriddell : no use to have me as reviewer: I did not do the respective change of kdevplatform API, so cannot really tell if this is the correct usage here. Also have I never run plasmate, so cannot test this patch quickly.

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

rikmills added a reviewer: Plasma. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D5128 To: rikmills, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

rikmills created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a workaround to mitigate broken (huge wide) scrollbars in mozilla/Gecko based applications for GTK3 >= 3.20 in versions 52 onwards.

D4921: [Menu] Harmonize openRelative placement

This revision was automatically updated to reflect the committed changes. Closed by commit R242:28ad7879d3e6: [Menu] Harmonize openRelative placement (authored by subdiff). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4921?vs=12126&id=1268

D5127: Switch to newer KDevelop API

jriddell updated this revision to Diff 12680. jriddell added a comment. Add version check for backwards compat REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5127?vs=12679&id=12680 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5127 AF

D5127: Switch to newer KDevelop API

jriddell added reviewers: Plasma, kossebau. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D5127 To: jriddell, #plasma, kossebau Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5127: Switch to newer KDevelop API

jriddell created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KDevelop API changed TEST PLAN check compiles REPOSITORY R118 Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org

D5036: UI fixes for logout dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5f2f343ef6a3: UI fixes for logout dialog (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5036?vs=12459&id=12677#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UP

D5126: improve position of Clock

davidedmundson added a comment. Fine with me, but it goes against the mockup. > make the clock disappear when there isn't enough room for it anymore, as user icons are more important That already happens... it's the visible: y>0 line that was there before. REPOSITORY R120 Plasma W

D5061: [sddm-theme] Add virtual keyboard support

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. FYI, SDDM requires only a config change. We added support a while back. It's worth testing natively as opposed to qmlscene because components loading can be a bit weird

D5126: improve position of Clock

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY take into account the size of the empty area before the user icons, make the clock disappear when there isn't enough room for it anymore, as u

D5036: UI fixes for logout dialog

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > Logout.qml:21 > import QtQuick 2.2 > +import QtQuick.Window 2.2 > import QtQuick.Layouts 1.2 I think that's unused now REPOSITORY R120 Plasma Workspace BRANCH

D5115: [Logout Greeter] Properly fullscreen window and don't bypass WM

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8777aeb91d91: [Logout Greeter] Properly fullscreen window and don't bypass WM (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5115?vs