davidedmundson added a comment.

  cool

INLINE COMMENTS

> xinputintegration.cpp:132
> +                m_lastTouchPosition = touchPosition;
> +                m_lastTouchPositions.insert(m_trackingTouchId, 
> touchPosition);
> +            }

I think we want to always update m_lastTouchPositions outside of 
if (e->detail == m_trackingTouchId)

otherwise if we get:

TouchBegin
TouchUpdate
TouchOwnership

we start the gesture in the wrong position

> xinputintegration.cpp:188
>      QPointer<X11Cursor> m_x11Cursor;
> +    QPointF m_lastTouchPosition;
> +    Display *m_x11Display = nullptr;

what's this for?

REVISION DETAIL
  https://phabricator.kde.org/D5137

To: graesslin, #plasma, #kwin
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Reply via email to