D5012: Delay notifications until desktop session has loaded

vpilo added reviewers: Plasma, Plasma: Workspaces. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma, #plasma_workspaces Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterbe

D4799: Delay notifications until desktop session has loaded

vpilo updated this revision to Diff 12377. vpilo marked an inline comment as done. vpilo added reviewers: Plasma, Plasma: Workspaces. vpilo added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. New patchset. I moved the waiti

D5012: Delay notifications until desktop session has loaded

vpilo added a dependency: D4799: Delay notifications until desktop session has loaded. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, progwolff, lesliezhai, ali-mohamed, jens

D5012: Delay notifications until desktop session has loaded

vpilo created this revision. vpilo added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Added program to wait for D-Bus Notifications services to register. Needed for Plasma to delay showing notifications until the desktop has fully loaded.

Re: LGPL a possibility for Breeze Qt widget style?

2017-03-09 19:21 GMT+01:00 Elvis Stansvik : > 2017-03-09 18:41 GMT+01:00 Jonathan Riddell : >> On Thu, Mar 09, 2017 at 06:30:36PM +0100, Elvis Stansvik wrote: >>> I just wish the FSF FAQ was more clear on this (direct dynamic linking vs >>> dlopen()ing). >> >> They can't be more clear as the defini

[kio-extras] [Bug 376344] cant write to smb shares which has write access

https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #6 from Elvis Angelaccio --- *** Bug 377198 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

https://bugs.kde.org/show_bug.cgi?id=376344 mathoj...@gmail.com changed: What|Removed |Added CC||mathoj...@gmail.com --- Comment #5 from ma

D5006: Set the correct desktop file name when in a KDE session.

hein added a comment. No idea (I can't start Wayland on Qt 5.9), but I don't see why it wouldn't. The two .desktop files are equal except the other one is NotShowIn=KDE. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D5006 To: hein, #plasma,

D5009: add functions for locking/unlocking the corona

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY add global immutability/setImmutability in scripting there was a locked property in containment, but didn't make much sense as the lock/unlock

D5008: [ksld] Don't unset greeter connection on destroy unconditionally

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If the greeter exits the Wayland connection gets destroyed and a new greeter with a new Wayland connection gets created. As the destroying

D4929: DrKonqi : lldb support

rjvbb updated this revision to Diff 12368. rjvbb added a comment. platform-specific data/debuggers/external *rc files and installation of the AppleTerminal script. gdb and lldb are now both started via that script on Mac and via konsole elsewhere. CHANGES SINCE LAST UPDATE https://pha

D5007: Fix weird scrolling artifact when the viewport is bigger than the content

apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D5007 AFFECTED FILES src/controls/templates/private/ScrollView.qml T

D4929: DrKonqi : lldb support

rjvbb added inline comments. INLINE COMMENTS > kfunk wrote in backtracegenerator.h:87 > Looks pretty unclean to have a backend-specific variable around here. I suppose I could replace m_lldbDetached with something like bool Debugger::isDetached(const QString &outputLine=QString()) { i

D5006: Set the correct desktop file name when in a KDE session.

graesslin added a comment. Does it still work on Wayland? REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D5006 To: hein, #plasma, mart, bshah, graesslin Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apo

D5006: Set the correct desktop file name when in a KDE session.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D5006 To: hein, #plasma, graesslin, mart, bshah Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D5004: manage scrollwheel by hand on desktop

davidedmundson added a comment. Note that you'll still have the same bug in "normal" QQC windows. You still need to handle angleDelta for the non libinput users where pixelDelta ==0 Also have a link: https://bugreports.qt.io/browse/QTBUG-59261 REPOSITORY R169 Kirigami REVISION

D5006: Set the correct desktop file name when in a KDE session.

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY System Settings installs two .desktop files: - kdesystemsettings.desktop setting NotShowIn=KDE, for non-KDE desktops - systemsettings.desktop, the one we use in Plasma As of https://phabrica

D5004: manage scrollwheel by hand on desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e0a623414cfb: manage scrollwheel by hand on desktop (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5004?vs=12361&id=12363 REVISION DETAIL ht

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 663 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/663/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Mar 2017 15:54:45 + Build duration: 19 min CHANGE SET Revision d12216cb7ce44dc5a814f045073a29518503

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 93 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/93/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Mar 2017 15:27:58 + Build duration: 24 min CHANGE SET Revision 721fcd3d309171fde2dc37b8

D4970: Get rid of QWeakPointer

denisshienkov added a comment. What is next steps from my side? REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, afiestas, ltoscano, volkov, davidedmundson Cc: davidedmundson, plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5005: [kcheckpass] Drop all outdated/obsoleted checkpass variants

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This was discussed on the distro mailing list. All checkpass variants which are no longer used are removed. What remains are: - etcsha

D4806: [greeter] Send the auth result through the server instead return value

graesslin added a comment. I plan to push this on Monday, so a review would be appreciated till then :-) REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4806 To: graesslin, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D4952: Restore the backend set viewport when popping the final render target

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4952 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abet

D4950: Scaling support in ColorPicker effect

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4950 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abet

D4951: Take into account scaling in blitFromFrameBuffer

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4951 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abet

D4948: Store GLRenderTarget::scale

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4948 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abet

D4990: Update Aurorae Shadow when we copy the buffer, not one frame after painting

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Hah, due to the render control the rendering became smarter than it used to be. Now after re-reading the existing code I see how your change helps. Looks like a good solution, thanks!

D5004: manage scrollwheel by hand on desktop

mart edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D5004 To: mart, #kirigami Cc: plasma-devel, apol

D5004: manage scrollwheel by hand on desktop

mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY when on desktop, skip the flickable internal scrollwheel manah=gement that is completely broken and manage scrolling by ourselves with a M

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

https://bugs.kde.org/show_bug.cgi?id=375333 --- Comment #16 from Elvis Angelaccio --- Ah right, it seems the fix was committed on master only. -- You are receiving this mail because: You are the assignee for the bug.

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

https://bugs.kde.org/show_bug.cgi?id=375333 Christoph Feck changed: What|Removed |Added Version Fixed In||17.04 -- You are receiving this mail because:

D4929: DrKonqi : lldb support

rjvbb added inline comments. INLINE COMMENTS > kfunk wrote in backtracegenerator.h:87 > Looks pretty unclean to have a backend-specific variable around here. I missed this one. I don't think it's possible to detect detaching (from the debugger output!) elsewhere but in the bt. generator. Not wi

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

https://bugs.kde.org/show_bug.cgi?id=375333 Rog131 changed: What|Removed |Added CC||samrog...@hotmail.com --- Comment #15 from Rog131 ---

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 92 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/92/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Mar 2017 13:44:17 + Build duration: 16 min CHANGE SET Revision b7ce1a4bc1d050ee03837bac77

D4929: DrKonqi : lldb support

rjvbb updated this revision to Diff 12360. rjvbb added a comment. This new version incorporates most of the changes Kevin requested. Quitting lldb through 1. a python "lambda" 2. the quit command seems to work reliably enough on Mac. It still uses AppleTerminal.sh uncondit

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 662 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/662/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Mar 2017 13:47:17 + Build duration: 5 min 52 sec CHANGE SET Revision b7ce1a4bc1d050ee03837bac77d1a3

D4998: [Folder View] Explicitly set prefix as empty in normal state

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b7ce1a4bc1d0: [Folder View] Explicitly set prefix as empty in normal state (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4998?vs=1235

D4998: [Folder View] Explicitly set prefix as empty in normal state

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4998 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4929: DrKonqi : lldb support

rjvbb marked 8 inline comments as done. rjvbb added inline comments. INLINE COMMENTS > kfunk wrote in backtracegenerator.cpp:62 > Please do this only if `lldb` is used then. No need to change code which > apparently worked fine for years. Also, did you try `QProcess::terminate` > instead? > >

D5002: [oxygen/kstyle] Fix build

hpereiradacosta added a comment. I'm ok with the patch However it all feel quite cumbersome I wonder if we could not introduce an animationHoverOrFocus enumeration defined as the or of the other two directly in the flags would make things nicer. What do you think ? REPOSITORY R113 O

D5002: [oxygen/kstyle] Fix build

cfeck created this revision. cfeck added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Not sure if the stricter error checking is from gcc, cmake, or Qt, but on my system with recent versions, I get compile errors, because 'int' cannot be promoted

D4929: DrKonqi : lldb support

rjvbb marked 4 inline comments as done. rjvbb added inline comments. INLINE COMMENTS > kfunk wrote in backtracegenerator.cpp:62 > Please do this only if `lldb` is used then. No need to change code which > apparently worked fine for years. Also, did you try `QProcess::terminate` > instead? > >

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 92 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/92/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Mar 2017 11:18:21 + Build duration: 25 min CHANGE SET Revision bcb6b86d3ab8bd196877473a

Plasma Vault usability

Hi all, Thomas said to contact him (if I wanted, and I did want to :) ) regarding the usability of Plasma Vault. Now, I'm not fond of behind-the-scenes communication, so I'm sending this to ML as well. It would be great to hear opinions on the UI of the Vault (mainly the Vault creation wizard) -

QtCurve window theme

Hi, I've started to use KWin5 on my FranKDEn 4+5 desktop, running it on KUbuntu 14.04 from the parallel prefix where I install my home-built Qt5 and KF5 software. This works pretty (surprisingly?) good with the current v5.9.3 and at least feels faster than KWin4. It also makes porting QtCurve'

D4991: try proper order of corona()->availableScreenRect()

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bcb6b86d3ab8: try proper order of corona()->availableScreenRect() (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4991?vs=12333&id=12355

Re: Scaling and multiple monitors

They are "the code doesn't exist" issues. Wayland will fix it; and there's a patchset nearly ready to mege There is supposedly a way using xrandr --scale. Effectively you set the non high DPI monitor to be twice the size. Set KDE to render everything twice the size using the scale thing then you

D4960: Pause media players on suspend

broulik added a comment. @andreaska F2773419: Screenshot_20170310_110418.png Like this? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4960 To: broulik, #plasma, #vdg, graesslin Cc: andreaska, plasma-devel, progwolff, lesl

D5000: Handle applyPrefixes with an empty string

This revision was automatically updated to reflect the committed changes. Closed by commit R242:547a34d34669: Handle applyPrefixes with an empty string (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5000?vs=1235

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

https://bugs.kde.org/show_bug.cgi?id=375333 --- Comment #14 from Elvis Angelaccio --- @Mahendra: you may want to delete your thumbnail cache folders: ~/.cache/thumbnails/large and ~/.cache/thumbnails/normal -- You are receiving this mail because: You are the assignee for the bug.

D4999: [FrameSvg] Ensure prefix list is never empty

broulik abandoned this revision. broulik added a comment. I like yours better REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4999 To: broulik, #plasma Cc: davidedmundson, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterbe

D5000: Handle applyPrefixes with an empty string

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D5000 To: davidedmundson, #plasma, broulik Cc: plasma-devel, #frameworks, pro

D4999: [FrameSvg] Ensure prefix list is never empty

davidedmundson added a comment. Wrote https://phabricator.kde.org/D5000 based on what you said in the other phab, the advantage there is you don't change what prefixes() returns. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4999 To: broulik, #p

D5000: Handle applyPrefixes with an empty string

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY When setting an empty QStringList as prefix, it can lead to unexpected results, such as the prefix not changing.

D4999: [FrameSvg] Ensure prefix list is never empty

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY When setting an empty QStringList as prefix, it can lead to unexpected results, such as the prefix not changing. BU

D4998: [Folder View] Explicitly set prefix as empty in normal state

broulik added a comment. The difference is that when `State` resets the property, it uses the actual `QStringList` it had in there before and then uses that one. However, it is empty and then applyPrefixes doesn't do anything. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabr

D4998: [Folder View] Explicitly set prefix as empty in normal state

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Somehow with FrameSvg optimizations State no longer manages to reset the property back to its original state when state is reset. BUG: 37

D4990: Update Aurorae Shadow when we copy the buffer, not one frame after painting

davidedmundson added a comment. > I think the call is deferred to get the correct areas repainted in the compositor. Right that's another reason. We both absolutely agree updating the shadow during the compostior pass would break stuff. The old code did a defer to get the shadow upd

D4989: more aggressively repaint when the shadow changes

anthonyfieroni added inline comments. INLINE COMMENTS > toplevel.cpp:337 > if (dirtyRect.isValid()) { > dirtyRect.translate(pos()); > addLayerRepaint(dirtyRect); About me, rectangle should not be translated to pos, cause it does not contain shadow (who stays not updated)

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

https://bugs.kde.org/show_bug.cgi?id=375333 --- Comment #13 from Mahendra Tallur --- (In reply to Mahendra Tallur from comment #12) > Hi ! Really sorry for bothering again, but it seems the fix didn't make it > to KDE apps 16.12.3. I mean, I just upgraded to KDE apps 16.12.3 (in KDE Neon LTS), l

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

https://bugs.kde.org/show_bug.cgi?id=375333 --- Comment #12 from Mahendra Tallur --- Hi ! Really sorry for bothering again, but it seems the fix didn't make it to KDE apps 16.12.3. -- You are receiving this mail because: You are the assignee for the bug.

D4991: try proper order of corona()->availableScreenRect()

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH phab/notificationsavailableScreenRectChanged REVISION DETAIL https://phabricator.kde.org/D4991 To: mart, #plasma, davidedmundson Cc: plasma-devel, progwolff, les