Review Request 129995: Fix KillRunner Memory leak

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129995/ --- Review request for Plasma, Aleix Pol Gonzalez and Kai Uwe Broulik. Reposi

Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/ --- Review request for Plasma, Kai Uwe Broulik and David Edmundson. Repositor

[sysadmin/repo-metadata] projects/kde/workspace/plasma-vault: Move Plasma Vault to (Plasma) Workspace

Git commit b8559f750bfa648ebae4a26882b2a64f07ae3094 by Ben Cooksley. Committed on 07/03/2017 at 06:24. Pushed by bcooksley into branch 'master'. Move Plasma Vault to (Plasma) Workspace Fixes T5335 CCMAIL: release-t...@kde.org CCMAIL: kde-core-de...@kde.org CCMAIL: plasma-devel@kde.org R +0-0

D4917: [Breeze Plasma Theme] Improve action-overlay icons

andreaska added a comment. F2753390: action-overlays.svgz only a draft (not finished, only that you can review something) F2753393: overlayScreenshot.png REPOSITORY R242 Plasma Framework (Library) REVISION DETA

D4956: [Folder View] Lower toolbox when an item is hovered

rikmills added a comment. Applying this: This seems to work ok when as shown in the video, you have a panel moved to the top of the screen and the pager not moved, so it is partially underneath that panel, shifting the relative location of the icon. However, it does not seem to wor

D4917: [Breeze Plasma Theme] Improve action-overlay icons

broulik added a comment. The icons are copied from the Breeze icon set. Granted, it's an "emblem" icon and not one from "actions" which is arguably wrong but I wanted to be consistent with Dolphin here… also, I expressed my frustration with our current visual design workflow numerous times,

[kio-extras] [Bug 359278] Crash when opening smb:// folders

https://bugs.kde.org/show_bug.cgi?id=359278 Elvis Angelaccio changed: What|Removed |Added CC||hi...@tahiti-ingenierie.pf --- Comment #6 fr

D4961: [Folder View] Allow querying currentItem

hein added a comment. If you ask me, from my own experience, assuming GridView can't do $thing is generally reasonable and a sign of healthy skepticism ;) What review is for :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4961 To: broulik, #plasma, he

D4961: [Folder View] Allow querying currentItem

broulik added a comment. > http://doc.qt.io/qt-5/qml-qtquick-gridview.html#currentItem-prop What the… reminds me that I wanted to make an oculist appointment. Damn. So much waste… :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4961 To: broulik, #plas

D4939: Get rid of KDELibs4Support

ltoscano set the repository for this revision to R122 Powerdevil. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

D4962: [Folder View] Open context menu when pressing Menu key

hein added a comment. Could you add a screenie for the pos problem you mentioned? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4962 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4918: [Folder View] Increase delegate action size to smallMedium in icon mode

hein added a comment. I'll check out the new icons tomorrow and then report back (nearing 7 AM here ...). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4918 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D4961: [Folder View] Allow querying currentItem

hein added a comment. In https://phabricator.kde.org/D4961#93230, @broulik wrote: > Note that GridView does *not* have a `currentItem` property – I added it in this patch. http://doc.qt.io/qt-5/qml-qtquick-gridview.html#currentItem-prop REPOSITORY R119 Plasma Desktop REVISION

D4918: [Folder View] Increase delegate action size to smallMedium in icon mode

broulik added a comment. Do you already have the new icons I pushed this morning? They're gray if not hovered so should be less intrusive. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4918 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai,

D4918: [Folder View] Increase delegate action size to smallMedium in icon mode

hein added a comment. I think it'd feel oppressively big - I'd prefer to keep the visual noise of those knobs small I guess? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4918 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

D4961: [Folder View] Allow querying currentItem

broulik added a comment. > Setting the item that has GridView.isCurrentItem to gridView.currentItem should be a no-op. It's already the current item, how can it be more current-item-y? Note that GridView does *not* have a `currentItem` property – I added it in this patch. > Also op

D4918: [Folder View] Increase delegate action size to smallMedium in icon mode

broulik added a comment. Oh, sorry, I misread your comment. Imho in icon mode it should definitely be smallMedium. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4918 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuter

D4964: [Folder View] Remove local copy of PlasmaQuick/Dialog

hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4964 To: broulik, #plasma, hein, davidedmundson Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4961: [Folder View] Allow querying currentItem

hein added a comment. I don't get what this is trying to achieve. Setting the item that has GridView.isCurrentItem to gridView.currentItem should be a no-op. It's already the current item, how can it be more current-item-y? Also opening the context menu is supposed to work already (perhaps i

D4845: Fix context menu button's icon size when on default DPI

aacid resigned from this revision. aacid added a comment. This revision is now accepted and ready to land. Abstain REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4845 To: Zren, subdiff, broulik, drosca Cc: aacid, davidedmundson, plasma-devel, prog

D4959: [Folder View] Turn heading into a "hyperlink" and reduce hit area

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Excellent, +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4959 To: broulik, #plasma, hein Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensre

D4917: [Breeze Plasma Theme] Improve action-overlay icons

hein added a comment. I wouldn't have veto'd it, but FWIW I think those icons don't work - their stem strength is much wider than Breeze lineart icons, they feel very out of place in our UX. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4917 To

D4918: [Folder View] Increase delegate action size to smallMedium in icon mode

hein added a comment. Wait, isn't this the reverse? You wanted smallMedium for listview mode for covering and small for icon mode (as previous, after my comment), no? :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4918 To: broulik, #plasma, hein Cc: plasm

D4956: [Folder View] Lower toolbox when an item is hovered

hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4956 To: broulik, #plasma, #vdg, hein, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D3805: Per-activity favorites (Final?)

hein added a comment. Sorry, I was indisposed on Monday (relationship anniversary, flight booking for company sprint, other stuff) - I'll review soon :). REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterb

D4939: Get rid of KDELibs4Support

denisshienkov edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4939: Get rid of KDELibs4Support

denisshienkov updated this revision to Diff 12250. denisshienkov added a comment. How about this? :) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4939?vs=12179&id=12250 REVISION DETAIL https://phabricator.kde.org/D4939 AFFECTED FILES CMakeLists.txt daemon/CMakeLists.txt d

D4965: Remove ifdef round qCDebugs

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. The ifdefs are from kde4 times. There it was also not needed, but nevertheless there. When working on the qt5 port I kept that under the assumption that the previous maintai

D4965: Remove ifdef round qCDebugs

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's not needed wtih Qt category logging. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kd

D4964: [Folder View] Remove local copy of PlasmaQuick/Dialog

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4964 To: broulik, #plasma, hein, davidedmundson Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D4964: [Folder View] Remove local copy of PlasmaQuick/Dialog

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Compiles. Cascading folder popups still work. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4964 AFFECTED FILES

D4923: [desktop:/ KIO] Strip superfluous slashes and fixup local root url

broulik added a comment. For some reason the `UDS_LOCAL_PATH` isn't properly filled, KFileItem localPath() is still desktop:/ but I got lost in KIO code trying to figure it out :( REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4923 To: broulik, #plasma, h

D4963: Add scaling support into BlurEffect::doBlur

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch caputres from the framebuffer using the framebuffer's geometry, factoring in scale. We then keep the current normal DPI f

D4962: [Folder View] Open context menu when pressing Menu key

broulik edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4962 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4962: [Folder View] Open context menu when pressing Menu key

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If items are selected, show their context menu next to the first selected item, otherwise ignore the signal and let the containment handle it

D4924: [Containment Interface] Trigger context menus on pressing "Menu" key

broulik added a dependent revision: D4962: [Folder View] Open context menu when pressing Menu key. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4924 To: broulik, #plasma, #vdg, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,

D4961: [Folder View] Allow querying currentItem

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY GridView doesn't have an itemAt(index) method, just indexAt(x,y). This workaround emits a signal to which the delegates listen to and then se

D4960: Pause media players on suspend

graesslin added a comment. Looks good to me. Can you please time travel that change back to when I was a student? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4960 To: broulik, #plasma, #vdg, graesslin Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jens

D4939: Get rid of KDELibs4Support

graesslin added a comment. Just as an FYI: I reimplemented parts of the API in kscreenlocker. This code could be used here as well. We just need to split it out into an own library - could be inside Plasma. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To

D4960: Pause media players on suspend

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When suspending the machine pause any media players to avoid embarrassing situation where the machine wakes up with loud music blaring out of

D4924: [Containment Interface] Trigger context menus on pressing "Menu" key

This revision was automatically updated to reflect the committed changes. Closed by commit R242:94a6a168cf45: [Containment Interface] Trigger context menus on pressing "Menu" key (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.k

D4845: Fix context menu button's icon size when on default DPI

drosca accepted this revision. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4845 To: Zren, subdiff, broulik, drosca, aacid Cc: aacid, davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4924: [Containment Interface] Trigger context menus on pressing "Menu" key

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4924 To: broulik, #plasma, #vdg, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D4944: QuickShare: Fix text/buttons cutting off in ShowUrlDialog in HiDPI settings

This revision was automatically updated to reflect the committed changes. Closed by commit R114:6cfee0e84d0e: Fix QuickShare ShowUrlDialog getting clipped in hiDPI settings (authored by Lim Yuen Hoe ). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4944?

D4959: [Folder View] Turn heading into a "hyperlink" and reduce hit area

mart added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4959 To: broulik, #plasma, hein Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4926: Fix cmake warning

This revision was automatically updated to reflect the committed changes. Closed by commit R135:c6305f5edbbd: Fix cmake warning (authored by apol). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4926?vs=12135&id=12241 REVISION

D4945: QuickShare: Fix attempt for Plasma freezing when trying to paste large images to imgur

yuenlim added a comment. Got it. I'll try digging into the notification applet/KIO code and see. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D4945 To: yuenlim, #plasma, apol Cc: mart, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterbe

D4945: QuickShare: Fix attempt for Plasma freezing when trying to paste large images to imgur

mart added a comment. In https://phabricator.kde.org/D4945#92766, @broulik wrote: > The notification is emitted by the notification applet itself and contains the destination URL of a job that finished. Maybe the applet should truncate the text? Or maybe KIO should do that? It's a http P

D4929: DrKonqi : lldb support

rjvbb added a comment. In https://phabricator.kde.org/D4929#93093, @mart wrote: > hmm, frameworksintegration? (but still in frameworks side) Bundling with, you mean? That could work too. It's not really the topic of this review request, but I discussed the idea of bundling wi

D4959: [Folder View] Turn heading into a "hyperlink" and reduce hit area

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I often end up accidentally opening the folder in a file manager because especially when FolderView is placed on a desktop, the hit area for t

D4926: Fix cmake warning

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D4926 To: apol, #frameworks, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreu

D4917: [Breeze Plasma Theme] Improve action-overlay icons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:badf8acfe2c0: [Breeze Plasma Theme] Improve action-overlay icons (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4917?vs=12

D4917: [Breeze Plasma Theme] Improve action-overlay icons

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4917 To: broulik, #plasma, #vdg, andreask, alex-l, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, je

D4917: [Breeze Plasma Theme] Improve action-overlay icons

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4917 To: broulik, #plasma, #vdg, andreask, alex-l Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4929: DrKonqi : lldb support

mart added a comment. hmm, frameworksintegration? (but still in frameworks side) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb, #plasma_workspaces Cc: mart, broulik, kde-mac, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D4939: Get rid of KDELibs4Support

volkov added a comment. 1. Extract QWeakPointer/QPointer change into a separate commit. 2. Use PowerDevil::BackendInterface::supportedSuspendMethods() instead of Solid::PowerManagement::supportedSleepStates(). REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 810 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/810/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Mar 2017 12:38:14 + Build duration: 1 min 33 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 810 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/810/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Mar 2017 12:38:14 + Build duration: 1 min 33 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 90 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/90/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Mar 2017 12:26:39 + Build duration: 20 min CHANGE SET Revision 5b9985501cb67107bd329a04b6

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 654 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/654/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Mar 2017 12:30:36 + Build duration: 5 min 53 sec CHANGE SET Revision 3f296787e289a83bee4d140d6228d6

D4891: Port away from setRoleNames where easily possible

This revision was automatically updated to reflect the committed changes. Closed by commit R242:dfbf2c1c302e: Port away from setRoleNames where easily possible (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4891?vs=120

D4918: [Folder View] Increase delegate action size to smallMedium in icon mode

broulik updated this revision to Diff 12237. broulik retitled this revision from "[Folder View] Increase delegate action size to smallMedium" to "[Folder View] Increase delegate action size to smallMedium in icon mode". broulik edited the summary of this revision. broulik edited the test plan for

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 653 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/653/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Mar 2017 12:21:51 + Build duration: 5 min 45 sec CHANGE SET Revision 5a2e6620f75a3d994ce05866d701ec

D4854: [AppletAppearance] Silence warning

This revision was automatically updated to reflect the committed changes. Closed by commit R119:02ccf21432f5: [AppletAppearance] Silence warning (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4854?vs=11992&id=12236 REVISION DETAI

D4922: [Folder View] Set plasmoid.busy to false when listing canceled

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5a2e6620f75a: [Folder View] Set plasmoid.busy to false when listing canceled (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4922?vs=12

D4915: [Folder View] Fix action button hover and pressed state

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5b9985501cb6: [Folder View] Fix action button hover and pressed state (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4915?vs=12113&id=

D4939: Get rid of KDELibs4Support

denisshienkov added a comment. So, what is final decision? Should I "abandon" it? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas Cc: davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterber

D4956: [Folder View] Lower toolbox when an item is hovered

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4956 To: broulik, #plasma, #vdg, hein, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4939: Get rid of KDELibs4Support

davidedmundson added a comment. > Will it be hard to reanimate it? Yes and no. It wouldn't be hard to finish it as-is, but it's an implementation of this specification: https://www.freedesktop.org/wiki/Specifications/power-management-spec/ which says "This spec is considered

D4939: Get rid of KDELibs4Support

broulik added a comment. > Will it be hard to reanimate it? Well, once you release it you can never fundamentally change it, so it needs to be really thought through. `Solid::PowerManagement::supportedSleepStates()` seems to be calling PowerDevil itself over DBus, so indeed it could

Minutes Monday Plasma Meeting

Attached, the minutes and log of today's meeting... -- sebas http://www.kde.org | http://vizZzion.orgPlasma Weekly Meeting, 6-2-2017 Sho: * [FV] Tweaks to item delegate margins - results in less wide gutters on the desktop, fitting more rows and cols, in response to frequent user feedback * [FV

D4956: [Folder View] Lower toolbox when an item is hovered

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise it might interfere with the item's interaction (e.g. it would overlap the selection button in the top left). CCBUG: 337060 TES

D4939: Get rid of KDELibs4Support

volkov added a comment. Actually we depend only on Solid::PowerManagement::supportedSleepStates(). But there is PowerDevil::BackendInterface::supportedSuspendMethods(). I guess it would be right to use it instead. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/

D4939: Get rid of KDELibs4Support

volkov added a reviewer: afiestas. volkov added a comment. Will it be hard to reanimate it? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D4955: [QDBusMenuBar] Connect to popupRequested signal

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. Can't apply to Plasma/5.9 with arc patch as your diff is missing the workaround code for Qt 5.7.0. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL htt

D4939: Get rid of KDELibs4Support

broulik added a comment. > but it's not built by default. Try to port to that new API. Unfortunately Solid::Power is just as dead as Solid::PowerManagement... sorry. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov Cc: broulik, p

D4955: [QDBusMenuBar] Connect to popupRequested signal

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This signal is emitted when an item should be activated, e.g. when pressing Alt+F to open the "File" menu. It is looked up at runtime as dis

D4939: Get rid of KDELibs4Support

volkov added a comment. Please, replace QWeakPointer with QPointer in a separate commit. As for Solid::PowerManagement, it was actually added to the solid library as Solid::Power, but it's not built by default. Try to port to that new API. REPOSITORY R122 Powerdevil REVISION DETAIL

D4929: DrKonqi : lldb support

rjvbb retitled this revision from "DrKonqi : lldb support (and cross-platform adaptation)" to "DrKonqi : lldb support". rjvbb edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb, #plasma_workspaces Cc: broulik, kd