Plasmoid's TextField on Panel?

2017-03-01 Thread Zoltan Gyarmati
Dear All, I'm developing a simple plasmoid which has a few TextFields (imported from org.kde.plasma.components 2.0) on it. When i add the plasmoid to the desktop or run it with plasmawindowed the TextField accepts the keyboard input as usual, but when i add the plasmoid to a Panel, it doesn't acce

[Differential] [Commented On] D4879: notifications: Correctly display the file in jobs

2017-03-01 Thread Xuetian Weng
xuetianweng added a comment. In https://phabricator.kde.org/D4879#91642, @davidedmundson wrote: > Label0 comes from the dataengine > We have some nice C++ methods to get a filename from a URL, can we do it there? > > (If not, ship this. it seems fine) Label0 is also used el

[Differential] [Commented On] D4879: notifications: Correctly display the file in jobs

2017-03-01 Thread David Edmundson
davidedmundson added a comment. Label0 comes from the dataengine We have some nice C++ methods to get a filename from a URL, can we do it there? (If not, ship this. it seems fine) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4879 EMAIL PREFERENCES

[Differential] [Request, 5 lines] D4879: notifications: Correctly display the file in jobs

2017-03-01 Thread Xuetian Weng
xuetianweng created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY For url with parameter like audiocd:/1.wav?device=/dev/sr0, the filename displayed in notifications applet is not correct ("sr0") instead of 1.wav. This commit try to remove the query string b

[Differential] [Commented On] D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-01 Thread Marco Martin
mart added a comment. sorry for the noise, it was a local setup problem, it works correctly now +1 from me REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4851 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D4877: [lookandfeel] Improve positioning of Clock

2017-03-01 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH lockscreen-clock REVISION DETAIL https://phabricator.kde.org/D4877 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graessli

[Differential] [Commented On] D4877: [lookandfeel] Improve positioning of Clock

2017-03-01 Thread Martin Gräßlin
graesslin added a comment. Wayland case: F2673065: clock-visible.png XWayland case: F2673067: clock-visible2.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4877 EMAIL PREF

[Differential] [Request, 11 lines] D4877: [lookandfeel] Improve positioning of Clock

2017-03-01 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The clock so far was manually positioned in a hard coded way which could result in the clock not being visible or only partly visible. This

[Differential] [Commented On] D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-01 Thread Marco Martin
mart added a comment. also, Failed to find shader ":/plasma-framework/shaders/fadingmaterial_core.vert" Failed to find shader ":/plasma-framework/shaders/fadingmaterial_core.frag" QOpenGLShader:🔗 Vertex shader(s) failed to link, fragment shader(s) failed to link. Vertex link error: INV

[Differential] [Closed] D4853: Find correct version of kirigami

2017-03-01 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R118:930621daed56: Make cmake search for the right version of Kirigami (authored by arojas). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4853?vs=11989&id=12036 RE

[Differential] [Commented On] D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-01 Thread Marco Martin
mart added a comment. tried it now on ati proprietary, the icon does have the highlight effect at the end of the animation but disappear during the animation. on terminal i have the following error: shader compilation failed: "Vertex shader(s) failed to link, fragment shader(s) faile

[Differential] [Updated, 133 lines] D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-01 Thread Martin Gräßlin
graesslin updated this revision to Diff 12034. graesslin added a comment. Hide the user list if it does not fit on screen any more due to keyboard being open REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4870?vs=12033&id=12034 BRANCH lockscre

[Differential] [Updated, 131 lines] D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-01 Thread Martin Gräßlin
graesslin updated this revision to Diff 12033. graesslin added a comment. Small improvements for activating by going through Qt.inputMethods. By that the keyboard closes when one clicks the close button. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.

[Differential] [Request, 1 line] D4876: [lookandfeel] Add Input Method hints for the password field

2017-03-01 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If we show a virtual keyboard, better make sure that useful password hints are set. REPOSITORY R120 Plasma Workspace BRANCH lockscree

[Differential] [Accepted] D4876: [lookandfeel] Add Input Method hints for the password field

2017-03-01 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH lockscreen-imh REVISION DETAIL https://phabricator.kde.org/D4876 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

[Differential] [Closed] D4821: Implement manual focus on click

2017-03-01 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R133:f8043de10b5d: Implement manual focus on click (authored by fvogt). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4821?vs=11941&id=12030 REVISION DETAIL ht

[Differential] [Closed] D4862: Fix rename box width calc.

2017-03-01 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:6a0b3f8a3dc5: Fix rename box width calc. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4862?vs=12026&id=12029 REVISION DETAIL https:/

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 646 - Still Unstable!

2017-03-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/646/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Mar 2017 17:49:56 + Build duration: 16 min CHANGE SET Revision 6a0b3f8a3dc580046f61ae4e01c0553377c1

[Differential] [Updated] D4874: Fix hover out when exiting visible frame.

2017-03-01 Thread Eike Hein
hein added a reviewer: mart. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4874 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, broulik, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterber

[Differential] [Updated] D4875: Fix actions overlay position not adjusting when switching view modes at runtime.

2017-03-01 Thread Eike Hein
hein added a reviewer: mart. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4875 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, broulik, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterber

[Differential] [Request, 33 lines] D4875: Fix actions overlay position not adjusting when switching view modes at runtime.

2017-03-01 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Setting centerIn to undefined when switching modes at runtime doesn't magically move the item back to 0,0. REPOSITORY R119 Plasma Desktop BRANCH meh REVISION DETAIL https://phabricator.kde.org

[Differential] [Accepted] D4862: Fix rename box width calc.

2017-03-01 Thread Marco Martin
mart accepted this revision. REPOSITORY R119 Plasma Desktop BRANCH meh REVISION DETAIL https://phabricator.kde.org/D4862 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, broulik, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

[Differential] [Request, 8 lines] D4874: Fix hover out when exiting visible frame.

2017-03-01 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Previously the hover out hitbox was calculated wrong, causing the hitbox to be too big e.g. for items with fewer actual text lines (and a frame sized to reflect it) than the configured text space.

Re: [KDE4] what component does the screenlocking?

2017-03-01 Thread Martin Gräßlin
Am 2017-03-01 15:50, schrieb Luca Beltrame: In data mercoledì 1 marzo 2017 15:44:48 CET, René J. V. Bertin ha scritto: And is that loginctl command supposed to work only on systems that use Only with systemd. Actually no. We interact with the DBus interface and don't care who owns the int

[Differential] [Commented On] D4821: Implement manual focus on click

2017-03-01 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D4821#91406, @fvogt wrote: > In https://phabricator.kde.org/D4821#91393, @hein wrote: > > > > On Wayland screen locker is initially focused but clicking on different screens doesn't focus them. > > > > If this is outstandin

[Differential] [Updated, 19 lines] D4862: Fix rename box width calc.

2017-03-01 Thread Eike Hein
hein updated this revision to Diff 12026. hein added a comment. Another attempt at fixing rename box positioning for RTL. Should work for both containment and widget cases. Also now smart enough to reposition when a scrollbar appears on the left. REPOSITORY R119 Plasma Desktop C

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

2017-03-01 Thread Chris Holland
Zren added a comment. @davidedmundson: Yes. I usually test in plasmoidviewer since it's the same (except for emoji rendering ). I get the same effect because you're still trying to stuff a 16px icon into a 12px hole at 1x DPI (96). The origina

[Differential] [Updated] D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-01 Thread David Edmundson
davidedmundson added a dependency: D4848: Split frag and vert code of FadingNode into separate files. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4851 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmun

[Differential] [Updated] D4848: Split frag and vert code of FadingNode into separate files

2017-03-01 Thread David Edmundson
davidedmundson added a dependent revision: D4851: Implement FadingMaterial frag/vert shaders on core profile. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4848 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: da

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

2017-03-01 Thread Eike Hein
hein added a comment. I like separation of concerns, so no objections. REVISION DETAIL https://phabricator.kde.org/D3805 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, mart, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterber

[Differential] [Closed] D4803: Basic keyboard support + fixes to QuickShare plasmoid

2017-03-01 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R495:7ce9b21d871e: Basic keyboard navigation for AlternativesView (authored by Lim Yuen Hoe ). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4803?vs=11996&id=12

[Differential] [Commented On] D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-01 Thread Martin Gräßlin
graesslin added a comment. F2672846: greeter-keyboard-not-shown.png F2672847: greeter-keyboard-shown.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4870 EMAIL PREFERENCES

[Differential] [Accepted] D4869: [Notifications Dataengine] Create KConfig object on the stack

2017-03-01 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4869 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, prog

[Differential] [Commented On] D4805: Basic keyboard support + fixes to QuickShare plasmoid: Plasma-addons side patch

2017-03-01 Thread Yuen Hoe Lim
yuenlim added a comment. Hmm, I have tested drag/dropping text, images, files, as well as copying text, images and files and then using the Paste action. They all seem to work as expected. INLINE COMMENTS > apol wrote in main.qml:226 > This is not correct. What if the content isn't urls? I

[Differential] [Request, 4 lines] D4871: Enable qtvirtualkeyboard QT_IM_MODULE for greeter

2017-03-01 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY To be ued together with https://phabricator.kde.org/D4870. REPOSITORY R133 KScreenLocker BRANCH qtvirtualkeyboard REVISION DETAIL ht

[Differential] [Request, 129 lines] D4870: [lookandfeel] Add virtual keyboard to the LockScreen

2017-03-01 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change integrates QtVirtualKeyboard into the Lock screen UI. A new button is added to the bottom row to toggle the appearance of th

[Differential] [Request, 8 lines] D4869: [Notifications Dataengine] Create KConfig object on the stack

2017-03-01 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I don't see why it should be created on the heap. TEST PLAN Did a spectacle notificaton, still got the configure button and it still worked

[Differential] [Request, 2 lines] D4868: [TaskManager] For contextMenuComponent placement use accurate enum on right edge

2017-03-01 Thread Roman Gilg
subdiff created this revision. subdiff added a project: Plasma. REVISION SUMMARY The contextMenuComponent uses currently `TopPosedLeftAlignedPopup` for its placement property if it is on the right edge. Until now this had no influence because of the flawed space correction in plasma-framework.

[Differential] [Updated] D4867: [Menu] Improved available space correction for openRelative

2017-03-01 Thread Roman Gilg
subdiff edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4867 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma Cc: plasma-devel, #frameworks, progwolff, lesliezha

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 645 - Still Unstable!

2017-03-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/645/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Mar 2017 14:45:36 + Build duration: 16 min CHANGE SET Revision 5995ea913aebb960fdf8cb72eedbf40ba4a3

[Differential] [Accepted] D4803: Basic keyboard support + fixes to QuickShare plasmoid

2017-03-01 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D4803 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: yuenlim, mart, apol Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Updated] D4805: Basic keyboard support + fixes to QuickShare plasmoid: Plasma-addons side patch

2017-03-01 Thread Aleix Pol Gonzalez
apol added a comment. I think this patch needs more testing and getting it in was premature. One needs to be able to paste images and text as well. INLINE COMMENTS > main.qml:226 > function action_paste() { > +if (clipboard.formats.length < 1) { // empty clipboard! > +

Re: [KDE4] what component does the screenlocking?

2017-03-01 Thread Luca Beltrame
In data mercoledì 1 marzo 2017 15:44:48 CET, René J. V. Bertin ha scritto: > And is that loginctl command supposed to work only on systems that use Only with systemd. IIRC FreeBSD has a patch to make it work with ConsoleKit. > systemd throughout or elsewhere too? `loginctl kill-session X` works

[Differential] [Updated, 8 lines] D4862: Fix rename box width calc.

2017-03-01 Thread Eike Hein
hein updated this revision to Diff 12017. hein added a comment. Fix rtl pos. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4862?vs=12012&id=12017 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4862 AFFECTED FILES containments/de

[Differential] [Closed] D4860: Reduce the hitbox for regular icon hover.

2017-03-01 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:5995ea913aeb: Reduce the hitbox for regular icon hover. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4860?vs=12011&id=12018 REVISION D

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Thomas Pfeiffer
colomar added a comment. Final comment: Do whatever makes sense, keep only the context menu if you like. I'm out. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

Re: [KDE4] what component does the screenlocking?

2017-03-01 Thread René J . V . Bertin
Luca Beltrame wrote: > With the exception of "loginctl unlock-sessions" as root or "loginctl unlock- > session" as the same user, none. It's the whole point of the screenlocker > architecture (that is, you can't just kill it and unlock the screen). And is that loginctl command supposed to work on

[Differential] [Request, 56 lines] D4867: [Menu] Improved available space correction for openRelative

2017-03-01 Thread Roman Gilg
subdiff created this revision. subdiff added a project: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY There was already some kind of detection and adjustment if there is not enough space for the popup availabl

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Thomas Pfeiffer
colomar added a comment. In https://phabricator.kde.org/D4838#91404, @Fuchs wrote: > > As far as I was informed on IRC, as far as I can see in the very discussion here: context menus were discouraged. Ah right, that was a miscommunication on our side. I'd never discoura

[Differential] [Updated] D4865: [System Tray] Listen to external collapse

2017-03-01 Thread Marco Martin
mart edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4865 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, broulik Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, j

[Differential] [Updated] D4865: [System Tray] Listen to external collapse

2017-03-01 Thread Marco Martin
mart added a dependency: D4866: possible to set expanded=false for a containment. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4865 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, broulik Cc: plasma-devel,

[Differential] [Updated] D4866: possible to set expanded=false for a containment

2017-03-01 Thread Marco Martin
mart added a dependent revision: D4865: [System Tray] Listen to external collapse. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4866 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, broulik Cc: pl

[Differential] [Request, 6 lines] D4866: possible to set expanded=false for a containment

2017-03-01 Thread Marco Martin
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY it will still have no visible effect, but is possible to read and write the property if containments make use of it (the

[Differential] [Request, 17 lines] D4865: [System Tray] Listen to external collapse

2017-03-01 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY when the panel containment collapses all its applets, forward the event right to the internal systray and close the popup TEST PLAN pinned sy

[kio-extras] [Bug 377057] KIO MTP : Download all file before play it

2017-03-01 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=377057 Elvis Angelaccio changed: What|Removed |Added CC||elvis.angelac...@kde.org Resolution|

[Differential] [Accepted] D4862: Fix rename box width calc.

2017-03-01 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4862 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, broulik Cc:

[Differential] [Updated, 7 lines] D4862: Fix rename box width calc.

2017-03-01 Thread Eike Hein
hein updated this revision to Diff 12012. hein added a comment. Fix x. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4862?vs=12008&id=12012 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4862 AFFECTED FILES containments/desktop/

[Differential] [Commented On] D4821: Implement manual focus on click

2017-03-01 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D4821#91393, @hein wrote: > > On Wayland screen locker is initially focused but clicking on different screens doesn't focus them. > > If this is outstanding, maybe add a FIXME TODO so we don't forget ...? Yes, but that can

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Christian
Fuchs added a comment. In https://phabricator.kde.org/D4838#91385, @colomar wrote: > > Okay, personal opinion on why split buttons are among the most horrible things related to UX: > > (And whilst some of these points might not apply to this very specific use case here: they will else

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

2017-03-01 Thread Ivan Čukić
ivan added a comment. Ok, expect a new wrapper model around this one - it is ugly to handle the placeholder item inside of this model. :) REVISION DETAIL https://phabricator.kde.org/D3805 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, mart, hein

[Differential] [Updated] D4862: Fix rename box width calc.

2017-03-01 Thread Kai Uwe Broulik
broulik added a comment. Width seems good now but X position is off F2672751: Screenshot_20170301_150854.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4862 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Accepted] D4860: Reduce the hitbox for regular icon hover.

2017-03-01 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Awesome! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4860 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 644 - Still Unstable!

2017-03-01 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/644/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Mar 2017 12:48:40 + Build duration: 30 min CHANGE SET Revision 8422f020cb1e130385f7e2ffdd73c77331d0

[Differential] [Commented On] D4821: Implement manual focus on click

2017-03-01 Thread Eike Hein
hein added a comment. > On Wayland screen locker is initially focused but clicking on different screens doesn't focus them. If this is outstanding, maybe add a FIXME TODO so we don't forget ...? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4821 EMAIL P

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Thomas Pfeiffer
colomar added a comment. In https://phabricator.kde.org/D4838#91286, @mart wrote: > i don't see the split button a very feasible option on a technical standpoint (and pretty bad purely on aestetics, would also be a thing we use only here and visually clashes with a combobox) If a

[Differential] [Updated, 41 lines] D4860: Reduce the hitbox for regular icon hover.

2017-03-01 Thread Eike Hein
hein updated this revision to Diff 12011. hein added a comment. Fix hitbox for list view mode. It was broken in the initial patch. Use states a la icon code. Compared to the old hitbox in listview mode, with the new code: - The hitbox spans the full row height (no point leaving a

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Thomas Pfeiffer
colomar added a comment. > Okay, personal opinion on why split buttons are among the most horrible things related to UX: > (And whilst some of these points might not apply to this very specific use case here: they will elsewhere, and once one component users this button, others will

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

2017-03-01 Thread Marco Martin
mart added a comment. I would push it right after this frameworks release, ok? REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4508 REVISION DETAIL https://phabricator.kde.org/D4508 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart,

[Differential] [Request, 5 lines] D4862: Fix rename box width calc.

2017-03-01 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4862 AFFECTED FILES containments/desktop/package/contents/ui/FolderView.qml EMAIL PREFERENCES https://phabricator.kde.

[Differential] [Request, 17 lines] D4861: [ConfigCategory] Deduce name and icon from pluginName

2017-03-01 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This way one can just add a KCM as-is without having to worry about a potentially diverging translation or icon from Sys

[Differential] [Commented On] D4860: Reduce the hitbox for regular icon hover.

2017-03-01 Thread Eike Hein
hein added a comment. Screenshots showing the hitbox: Before: F2672705: before.png After: F2672707: after.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4860

[Differential] [Request, 5 lines] D4860: Reduce the hitbox for regular icon hover.

2017-03-01 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY This reduces the sub-rectangle within the delegate that reacts to pointer hover to wrap the icon and label more tightly, which makes doing rectangle selections - foiled by accidentally hover-activa

[Differential] [Closed] D4856: Tighter Folder View item delegates.

2017-03-01 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:8422f020cb1e: Tighter Folder View item delegates. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4856?vs=11999&id=12004 REVISION DETAIL

[Differential] [Commented On] D4842: [System Tray] Listen to external collapse

2017-03-01 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D4842#90987, @broulik wrote: > Of course I meant the code in panel containment, but here it does expanded = false and that's what I wanted to listen to :) > > Plasmoid.onUserConfiguringChanged: { > ... > if (pl

[Differential] [Accepted] D4843: PulseObject: Also use "media.icon_name" for icon

2017-03-01 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH media-iconname (branched from master) REVISION DETAIL https://phabricator.kde.org/D4843 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D4857: Use initialiser list

2017-03-01 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4857 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: p

[Differential] [Accepted] D4854: [AppletAppearance] Silence warning

2017-03-01 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, progwo

[Differential] [Accepted] D4856: Tighter Folder View item delegates.

2017-03-01 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4856 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, mart Cc: davide

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

2017-03-01 Thread Eike Hein
hein added a comment. Imho the placerholder is needed ... :) REVISION DETAIL https://phabricator.kde.org/D3805 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, mart, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

[kio-extras] [Bug 377057] New: KIO MTP : Download all file before play it

2017-03-01 Thread Adrien D
https://bugs.kde.org/show_bug.cgi?id=377057 Bug ID: 377057 Summary: KIO MTP : Download all file before play it Product: kio-extras Version: 5.9.2 Platform: Other OS: Linux Status: UNCONFIRMED Severity: nor

[Differential] [Request, 2 lines] D4857: Use initialiser list

2017-03-01 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Ran REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4857 AFFECTED FILES

[Differential] [Updated, 60 lines] D4848: Split frag and vert code of FadingNode into separate files

2017-03-01 Thread David Edmundson
davidedmundson updated this revision to Diff 12000. davidedmundson added a comment. Change prefix REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4848?vs=11980&id=12000 REVISION DETAIL https://phabricator.kde.org/D4848 AFFECTED FILES

[Differential] [Commented On] D4848: Split frag and vert code of FadingNode into separate files

2017-03-01 Thread Marco Martin
mart added a comment. agree on plasma-framework, in general, looks way cleaner :) INLINE COMMENTS > broulik wrote in shaders.qrc:2 > plasma-framework? +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4848 EMAIL PREFERENCES https://phabricato

[Differential] [Changed Subscribers] D4856: Tighter Folder View item delegates.

2017-03-01 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > FolderItemDelegate.qml:198 > return (icon.height + (2 * units.smallSpacing) + > (label.lineCount > -* theme.mSize(theme.defaultFont).height) + (2 * > units.largeSpacing)); > +* t

[Differential] [Accepted] D4853: Find correct version of kirigami

2017-03-01 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. thanks REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D4853 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: arojas, #plasma, m

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Marco Martin
mart added a comment. i don't see the split button a very feasible option on a technical standpoint (and pretty bad purely on aestetics, would also be a thing we use only here and visually clashes with a combobox) those extra actions are not a fundamental thing at all, and i would not part

[Differential] [Commented On] D4856: Tighter Folder View item delegates.

2017-03-01 Thread Eike Hein
hein added a comment. Updated. This means there's still *slightly* less space left now than before. I considered going even more extreme (increase that width by another two smallSpacings), but it started to feel a little too cramped - but it's borderline. Could you try both locally and give

[Differential] [Updated, 15 lines] D4856: Tighter Folder View item delegates.

2017-03-01 Thread Eike Hein
hein updated this revision to Diff 11999. hein added a comment. More horizontal space for text label. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4856?vs=11998&id=11999 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4856 AFFECTE

[Differential] [Commented On] D4856: Tighter Folder View item delegates.

2017-03-01 Thread Eike Hein
hein added a comment. Aye, let me try! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4856 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensr

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Christian
Fuchs added a comment. In https://phabricator.kde.org/D4838#91010, @colomar wrote: > In https://phabricator.kde.org/D4838#91009, @subdiff wrote: > > > I thought of something like this: F2668672: Screenshot_20170228_114914.png > > Is this in li

[Differential] [Commented On] D4856: Tighter Folder View item delegates.

2017-03-01 Thread Kai Uwe Broulik
broulik added a comment. Can we let the label get wider, though? (compare icon width vs total available delegate width – the label could occupy somewhat more width than the icon) F2672613: Screenshot_20170301_125123.png Especially noticeable here wh

[Differential] [Commented On] D4856: Tighter Folder View item delegates.

2017-03-01 Thread Eike Hein
hein added a comment. Additional screenshots with text lines in config set to 2: F2672608: before2.png F2672610: after2.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4

[Differential] [Commented On] D4856: Tighter Folder View item delegates.

2017-03-01 Thread Kai Uwe Broulik
broulik added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4856 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Commented On] D4856: Tighter Folder View item delegates.

2017-03-01 Thread Eike Hein
hein added a comment. Before: F2672595: before.png After: F2672598: after.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4856 EMAIL PREFERENCES https://phabrica

[Differential] [Request, 13 lines] D4856: Tighter Folder View item delegates.

2017-03-01 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY This patch reduces margins inside the item delegate. The most frequent piece of user feedback for Folder View is "Can you let me change the grid size?", and the background behind the question alway

[Differential] [Updated] D4803: Basic keyboard support + fixes to QuickShare plasmoid

2017-03-01 Thread Yuen Hoe Lim
yuenlim marked an inline comment as done. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D4803 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: yuenlim, mart, apol Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, je

[Differential] [Updated, 8 lines] D4803: Basic keyboard support + fixes to QuickShare plasmoid

2017-03-01 Thread Yuen Hoe Lim
yuenlim updated this revision to Diff 11996. yuenlim added a comment. Use PlasmaComponents.Highlight REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4803?vs=11963&id=11996 REVISION DETAIL https://phabricator.kde.org/D4803 AFFECTED FILES src/qui

[Differential] [Request, 2 lines] D4854: [AppletAppearance] Silence warning

2017-03-01 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY "applet" is set after the item is created and would result in a warning on startup. TEST PLAN Browsed through FolderView, Busy Indicator st

Re: Project: Better touch screen support in the Plasma workspace

2017-03-01 Thread David Edmundson
>How should I go about ... ​Same advice for all GSOC students, get involved in any area of Plasma. Implement some feature that you've always wanted, fix a bug. Any number of small tasks to help us get to know you as a developer. It doesn't even have to be in the same area as the intended GSOC proj

[Differential] [Accepted] D4830: Adjust plasma-desktop to the new fallback prefixes

2017-03-01 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. When I move my panel around I get warnings The image "widgets/tasks" doesn't contain any of the prefixes ("south-", "") but I think that is a false-positive. REPOSITORY R119

  1   2   >