hein updated this revision to Diff 12011. hein added a comment.
Fix hitbox for list view mode. It was broken in the initial patch. Use states a la icon code. Compared to the old hitbox in listview mode, with the new code: - The hitbox spans the full row height (no point leaving a gutter as before). - The hitbox doesn't weirdly end ~1cm early. Note that unlike Dolphin, the hitbox isn't constrained to the length of the label. There's no value to that for FV because we don't do rectangle select in list view mode, and it matches the UX of other Plasma list-like UIs like Kicker & co. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4860?vs=12005&id=12011 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4860 AFFECTED FILES containments/desktop/package/contents/ui/FolderItemDelegate.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
