[Differential] [Commented On] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

2017-01-04 Thread hein (Eike Hein)
hein added a comment. re storing app ids: I'm reluctant to do so because it means not using appsMatch() which the code tries hard to avoid -- the old libtm suffered from different parts of the codebase using different logic to match things. REPOSITORY R120 Plasma Workspace BRANCH master

[Differential] [Requested Changes To] D3955: [Plasma folderview] Improve keyboard navigation

2017-01-04 Thread hein (Eike Hein)
hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. As mentioned before, keywrap should include the Up (soon Back) button item so it can be reached with the keyboard. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabrica

[Differential] [Requested Changes To] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

2017-01-04 Thread hein (Eike Hein)
hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. I'm not entirely happy with the way this works, I think the history may need to be kept on the QML side instead, then: (a) You can properly evict the history when the URL in the c

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 515 - Fixed!

2017-01-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/515/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 05:22:30 + Build duration: 14 min CHANGE SET Revision 180e1072e933cf13edb145dfeab2a62b7623a

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 515 - Fixed!

2017-01-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/515/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 05:22:30 + Build duration: 14 min CHANGE SET Revision 180e1072e933cf13edb145dfeab2a62b7623a

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 514 - Failure!

2017-01-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/514/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 05:17:20 + Build duration: 2 min 32 sec CHANGE SET Revision fc24edd139dd8e75a58b9f6b560a375

[Differential] [Commented On] D3948: Add-app-to-panel string overhaul.

2017-01-04 Thread hein (Eike Hein)
hein added inline comments. INLINE COMMENTS > broulik wrote in actionlist.cpp:144 > Perhaps "(Icon Widget)", or "Add to Panel as Widget"? I decided against naming the widget since we kinda hide the existence of Icon .. > broulik wrote in ContextMenu.qml:409 > Please add some i18nc here, I fear

[Differential] [Commented On] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

2017-01-04 Thread hein (Eike Hein)
hein added a comment. > LauncherTaskModel is activity aware. This is a new 5.9 feature though and the bug got reported as far back as 5.7. > Side suggestion: Maybe it's worth attaching the ModelTest class to every model here for debug builds. I used it during development, but mi

[Differential] [Closed] D3947: Clean up after a window delegate drag exits the window.

2017-01-04 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit R119:180e1072e933: Clean up after a window delegate drag exits the window. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3947?vs=9689&id=9742

[Differential] [Closed] D3948: Add-app-to-panel string overhaul.

2017-01-04 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit R119:fc24edd139dd: Add-app-to-panel string overhaul. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3948?vs=9690&id=9741 REVISION DETAIL ht

[Differential] [Request, 1 line] D3976: And enable high DPI on the icons in kfontview

2017-01-04 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Ran it, opened everything I could find looking for issues REPOSITORY R119 Plasma Desktop BRANCH

[Differential] [Request, 8 lines] D3975: Add high DPI support to kfontview and kfontinst KCM

2017-01-04 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 374118 TEST PLAN Ran with QT_SCALE_FACTOR=2 Now looked both enormous and smooth REP

[Differential] [Closed] D3973: wallpapers/image: Use QImageReader in ImageSizeFinder::run()

2017-01-04 Thread Fredrik Höglund
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ee245780f236: wallpapers/image: Use QImageReader in ImageSizeFinder::run() (authored by fredrik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3973?vs=97

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 108 - Still Unstable!

2017-01-04 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/108/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 Jan 2017 22:13:33 + Build duration: 1 min 8 sec CHANGE SET Revision 034b3acfdd69d04f0e2d3ee35a0bfd3d

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 105 - Still Unstable!

2017-01-04 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/105/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 Jan 2017 22:13:33 + Build duration: 1 min 1 sec CHANGE SET Revision 034b3acfdd69d04f0e2d3ee35

[Differential] [Accepted] D3973: wallpapers/image: Use QImageReader in ImageSizeFinder::run()

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a reviewer: broulik. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3973 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fredrik, #plasma, davidedmundson, broulik Cc: davidedmun

[Differential] [Accepted] D3973: wallpapers/image: Use QImageReader in ImageSizeFinder::run()

2017-01-04 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. thanks REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3973 EMAIL PREFERENCES https://p

[Differential] [Request, 4 lines] D3973: wallpapers/image: Use QImageReader in ImageSizeFinder::run()

2017-01-04 Thread Fredrik Höglund
fredrik created this revision. fredrik added a reviewer: Plasma. fredrik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There is no need to decode the whole i

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2017-01-04 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #22 from Kai Uwe Broulik --- I'll have a look but that needs adjustments in KWin (needed anyway as the effect isn't supported on Wayland yet) (a bit of Trivia: The effect that fades the screen was actually intended for KScreen to "turn off"

[Differential] [Closed] D3651: Add utility to send broadcast notifications

2017-01-04 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R126:455e0209e6a7: Add utility to send broadcast notifications (authored by broulik). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3651?vs=8944&id=9730 REVI

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2017-01-04 Thread S
https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #21 from S --- (In reply to Christoph Feck from comment #20) > The entire discussion in this bug report looks like there is a > misunderstanding between "black" and "off". That seems to be the issue. :-) I should also clarify that I am ref

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2017-01-04 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #20 from Christoph Feck --- Kai, would it be possible to fade to say 25% instead of 0%, and fade the remaining 25% a second before it is turned off? This way, the user still sees that the display is not off yet, but still is urged to move th

Re: Review Request 129652: update network, smb, thumbnail ioslave docbooks

2017-01-04 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129652/ --- (Updated Jan. 4, 2017, 8:18 p.m.) Status -- This change has been mar

[Differential] [Request, 21 lines] D3971: RFC: Run first action on Shift+Return

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to R112 Milou. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When pressing Shift+Return activat

[Differential] [Request, 1,886 lines] D3969: Kill audioplayercontrolrunner

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is yet another mpris implementation

[Differential] [Request, 3 lines] D3968: [Fifteen Puzzle] Start timer on tile click, stop timer on shuffle

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, whiting. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows you to "Stop" a game

[Differential] [Request, 34 lines] D3967: [Fifteen Puzzle] Add "Browse" button

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There's a text field for entering a path

[Differential] [Accepted] D3963: Fix syncing of geometry to internal window when using ::move

2017-01-04 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. BRANCH move-internal-window REVISION DETAIL https://phabricator.kde.org/D3963 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #pl

[Differential] [Closed] D3966: [Fifteen Puzzle] Animate moving of tiles

2017-01-04 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R114:018062bb1294: [Fifteen Puzzle] Animate moving of tiles (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3966?vs=9720&id=9721 REVISION DE

[Differential] [Accepted] D3966: [Fifteen Puzzle] Animate moving of tiles

2017-01-04 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. love this little whimsical things, we should pay more attention to such details :D REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3

[Differential] [Request, 13 lines] D3966: [Fifteen Puzzle] Animate moving of tiles

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, whiting. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Makes the game a lot nicer to loo

[Differential] [Accepted] D3964: Fade out OnScreenNotification when moving with the mouse over it

2017-01-04 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > onscreennotification.cpp:209 > +if (!m_animation) { > +m_animation = new QPropertyAn

[Differential] [Closed] D3962: Add Appstream summary

2017-01-04 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R166:a6f88a9170ef: Add Appstream summary (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3962?vs=9715&id=9719#toc REPOSITORY R166 Spectacle CHANGES SINCE LAST UPDATE https

[Differential] [Updated] D3964: Fade out OnScreenNotification when moving with the mouse over it

2017-01-04 Thread Martin Gräßlin
graesslin added dependencies: D3928: Sync opacity from an internal QWindow to its ShellClient, D3963: Fix syncing of geometry to internal window when using ::move. REVISION DETAIL https://phabricator.kde.org/D3964 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences

[Differential] [Updated] D3928: Sync opacity from an internal QWindow to its ShellClient

2017-01-04 Thread Martin Gräßlin
graesslin added a dependent revision: D3964: Fade out OnScreenNotification when moving with the mouse over it. REPOSITORY R108 KWin BRANCH opacity-internal-window REVISION DETAIL https://phabricator.kde.org/D3928 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Request, 100 lines] D3964: Fade out OnScreenNotification when moving with the mouse over it

2017-01-04 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This change triggers a fade out animation when the mouse is moved ov

[Differential] [Request, 66 lines] D3963: Fix syncing of geometry to internal window when using ::move

2017-01-04 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The OnScreenNotification gets moved during its placement. This updat

[Differential] [Updated] D3928: Sync opacity from an internal QWindow to its ShellClient

2017-01-04 Thread Martin Gräßlin
graesslin added a dependent revision: D3963: Fix syncing of geometry to internal window when using ::move. REPOSITORY R108 KWin BRANCH opacity-internal-window REVISION DETAIL https://phabricator.kde.org/D3928 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences

[Differential] [Updated] D3963: Fix syncing of geometry to internal window when using ::move

2017-01-04 Thread Martin Gräßlin
graesslin added a dependency: D3928: Sync opacity from an internal QWindow to its ShellClient. REVISION DETAIL https://phabricator.kde.org/D3963 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, le

[Differential] [Accepted] D3962: Add Appstream summary

2017-01-04 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R166 Spectacle REVISION DETAIL https://phabricator.kde.org/D3962 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, bgupt

[Differential] [Request, 1 line] D3962: Add Appstream summary

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, bgupta, mak. broulik set the repository for this revision to R166 Spectacle. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN As criticized on kde-devel by Richard Hu

Re: Repo freeze on Thursday

2017-01-04 Thread Marco Martin
On Thursday 29 December 2016 11:13:49 Jonathan Riddell wrote: > > Yo, > > the repo plymouth-kcm should be added as well, today i'll add all the > > needed extra stuff (copying file, readme and what not) > > It might need docs to pass kdereview review. to update on that... I'm fine either way weth

[Differential] [Closed] D3961: [Fifteen Puzzle] Remove custom color picker

2017-01-04 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R114:fb6a95332a3c: [Fifteen Puzzle] Remove custom color picker (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3961?vs=9711&id=9714 REVISION

[Differential] [Commented On] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik added a comment. https://cgit.kde.org/plasma-workspace.git/commit/?h=Plasma/5.8&id=03374b185f9bd3bc4f70726ae641014a33278fdd REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3954 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Closed] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3954 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, j

[Differential] [Closed] D3959: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable

2017-01-04 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:52b1644c8a03: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde

[Differential] [Closed] D3960: [Windowed Widgets Runner] Set applet name instead of plugin ID as runner result text

2017-01-04 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:04854c155df3: [Windowed Widgets Runner] Set applet name instead of plugin ID as runner result… (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

[Differential] [Accepted] D3958: [PackageLoader] Don't access invalid KPluginMetadata

2017-01-04 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3958 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, apol,

Re: Review Request 129772: update padding of the start.svgz file

2017-01-04 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129772/ --- (Updated Jan. 4, 2017, 3:40 p.m.) Status -- This change has been mar

Re: Review Request 129772: update padding of the start.svgz file

2017-01-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129772/#review101793 --- Ship it! sorry, already pushed it before reading the rr

Re: Review Request 129772: update padding of the start.svgz file

2017-01-04 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129772/ --- (Updated Jan. 4, 2017, 3:33 p.m.) Review request for Plasma and Marco Mar

Review Request 129772: update padding of the start.svgz file

2017-01-04 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129772/ --- Review request for Plasma and Marco Martin. Repository: plasma-framework

[Differential] [Accepted] D3961: [Fifteen Puzzle] Remove custom color picker

2017-01-04 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3961 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Accepted] D3959: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable

2017-01-04 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. https://git.reviewboard.kde.org/r/129771/ and lets ship this in master, as it's more correct than the current code. REPO

[Differential] [Commented On] D3959: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable

2017-01-04 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Master and we need to be fixing KPluginMetaData::value() to return something for the bool case for Plamsa 5.8 or older like I did for stringlists just now in https://git.reviewboard.kde.org/r/129770/ REPOSITORY R120 Plasma Workspace REVISION DETAIL

[Differential] [Commented On] D3959: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable

2017-01-04 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Seems it can: inline bool qt_convertToBool(const QVariant::Private *const d) { TInput str = v_cast(d)->toLower(); return !(str.isEmpty() || str == LiteralWrapper("0") || str == LiteralWrapper("false")); } I'll make the kcoreaddons cha

[Differential] [Request, 69 lines] D3961: [Fifteen Puzzle] Remove custom color picker

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R114 Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The round color picker looked fancy but f

[Differential] [Commented On] D3959: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Return "true" and "false" strings maybe? I *think* QVariant is even smart enough to case those to the respective bool values REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3959 EMAIL PREFERENCES https://phabricator.kde.org/settin

[Differential] [Accepted] D3960: [Windowed Widgets Runner] Set applet name instead of plugin ID as runner result text

2017-01-04 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3960 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Request, 16 lines] D3960: [Windowed Widgets Runner] Set applet name instead of plugin ID as runner result text

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN I don't know how this ever worked but I recal

[Differential] [Request, 3 lines] D3959: [Windowed Widgets Runner] Fix check for whether applet is standalone-capable

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes yet another KPluginMetadata regr

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 104 - Still Unstable!

2017-01-04 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/104/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 Jan 2017 14:24:31 + Build duration: 1 min 10 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Updated] D3958: [PackageLoader] Don't access invalid KPluginMetadata

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik updated the test plan for this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3958 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, apol Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jen

[Differential] [Updated] D3958: [PackageLoader] Don't access invalid KPluginMetadata

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik updated the test plan for this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3958 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, apol Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jen

[Differential] [Request, 4 lines] D3958: [PackageLoader] Don't access invalid KPluginMetadata

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, apol. broulik set the repository for this revision to R290 KPackage. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY BUG: 374541 TEST P

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 107 - Still Unstable!

2017-01-04 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/107/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 Jan 2017 14:18:03 + Build duration: 59 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 513 - Fixed!

2017-01-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/513/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 Jan 2017 14:09:59 + Build duration: 7 min 58 sec CHANGE SET Revision ed73ecd6a3de4be92a0630bbeb5815a

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 513 - Fixed!

2017-01-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/513/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 Jan 2017 14:09:59 + Build duration: 7 min 58 sec CHANGE SET Revision ed73ecd6a3de4be92a0630bbeb5815a

[Differential] [Closed] D3923: Make AppstreamQt optional

2017-01-04 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit R119:ed73ecd6a3de: Make AppstreamQt optional (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3923?vs=9617&id=9704#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LA

[Differential] [Request, 26 lines] D3955: [Plasma folderview] Improve keyboard navigation

2017-01-04 Thread chinmoyr (Chinmoy Ranjan Pradhan)
chinmoyr created this revision. chinmoyr added reviewers: hein, Plasma. chinmoyr set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Improvements are (for listview m

[Differential] [Updated] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

2017-01-04 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. I have an idea what could be wrong. (though it's a guess from reading a tonne of code) LauncherTaskModel is activity aware. When I change activity I will cause my (filtered) GroupsModel to change and cause launchertasksmodel to change in the *same ev

plasma-devel@kde.org

2017-01-04 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit R118:229803bec3e5: export kwin theme to l&f (authored by mart). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3833?vs=9449&id=9701 REVISION DETAIL https://phabrica

[Differential] [Accepted] D3939: fix description for option -t in man page

2017-01-04 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3939 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lueck, #frameworks, mart, #plasma, davidedm

[Differential] [Accepted] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

2017-01-04 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. > I'll try to create a small testcase and report that issue to Qt, it shouldn't crash in Yeah, it really shouldn't. REP

[Differential] [Updated] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3954 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg

[Differential] [Commented On] D3948: Add-app-to-panel string overhaul.

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > actionlist.cpp:144 > if (ContainmentInterface::mayAddLauncher(appletInterface, > ContainmentInterface::Panel)) { > -actionList << Kicker::createActionItem(i18n("Add to Panel"), > "addToPanel"); > } Perhaps "(Icon Widget)", or "

[Differential] [Closed] D3953: Improve error message

2017-01-04 Thread apol (Aleix Pol Gonzalez)
apol closed this revision. apol added a comment. https://commits.kde.org/kpackage/f9857670704fb432d08f9807c75708a018a4b538 REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3953 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol

[Differential] [Request, 4 lines] D3954: [MPRIS Data Engine] Don't crash if "Metadata" is a map but of wrong type

2017-01-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QDBusArgument MapType fits all kinds o

[Differential] [Accepted] D3939: fix description for option -t in man page

2017-01-04 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3939 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lueck, #plasma, #framewo

[Differential] [Accepted] D3953: Improve error message

2017-01-04 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D3953 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart Cc: plasma-devel

[Differential] [Accepted] D3948: Add-app-to-panel string overhaul.

2017-01-04 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3948 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, broulik, mart C

[Differential] [Accepted] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

2017-01-04 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3950 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 512 - Still Failing!

2017-01-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/512/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 Jan 2017 12:23:50 + Build duration: 1 min 48 sec CHANGE SET Revision 81be6962b1e43ea4da7caa038fa87d8

[Differential] [Updated, 285 lines] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

2017-01-04 Thread chinmoyr (Chinmoy Ranjan Pradhan)
chinmoyr retitled this revision from "[Plasma folderview] Introduce "Back to Desktop" option in listview mode" to "[Plasma folderview] Replace "Up" button with "Back" button in listview mode". chinmoyr updated the summary for this revision. chinmoyr updated this revision to Diff 9698. REPOSITORY

plasma-devel@kde.org

2017-01-04 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit R119:81be6962b1e4: import kwin deco and button order in l&f (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3832?vs=9662&id=9699 REVISION DETA

[Differential] [Request, 2 lines] D3953: Improve error message

2017-01-04 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Plasma, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY DesktopToJson will convert lists such as "Something=a, b, c" into JSON "Something": ["

Re: Plasma 5.9 Release Announcement

2017-01-04 Thread Jonathan Riddell
On Sun, Jan 01, 2017 at 05:48:11PM +0100, Kai Uwe Broulik wrote: > * I quite dislike the A4 paper layout and font rendering is quite blurry > here‎, not to mention subpar performance and tearing :/ This baby is running libreoffice on the server and rendering it on the website, a bit of blurring

[Differential] [Accepted] D3947: Clean up after a window delegate drag exits the window.

2017-01-04 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3947 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ T

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

2017-01-04 Thread subdiff (Roman Gilg)
subdiff added inline comments. INLINE COMMENTS > hein wrote in ContextMenu.qml:59 > That's kinda what I was wondering. If the context menu is opened for an > element in the tooltip, why is the visualParent the task item? It's basically the second best solution. ;) When I tried to set the toolt

[Differential] [Updated, 1,078 lines] D3738: [Task Manager] Tooltips redesign

2017-01-04 Thread subdiff (Roman Gilg)
subdiff updated this revision to Diff 9695. subdiff marked 12 inline comments as done. subdiff added a comment. - Better description of the workaround - Use `active` property instead of reloading component for workaround - `hideToolTipTemporarily()` to not rely on the workaround when Delega

[Differential] [Commented On] D3910: [Kicker] Don't nuke favorites on startup

2017-01-04 Thread hein (Eike Hein)
hein added a comment. BTW: Kai, if you don't want to work on this today-ish I'll give it another try some time this week. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3910 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Differential] [Request, 25 lines] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

2017-01-04 Thread hein (Eike Hein)
hein created this revision. hein added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY TasksModel filters out matching launchers when a startup or window appears. When they go, dataChanged in

[Differential] [Commented On] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

2017-01-04 Thread hein (Eike Hein)
hein added a comment. This is sort of a brainstorm trolling for David's input~ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3950 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, davidedmundson Cc: plasma-devel, l

[Differential] [Request, 8 lines] D3948: Add-app-to-panel string overhaul.

2017-01-04 Thread hein (Eike Hein)
hein created this revision. hein added reviewers: Plasma, mart, broulik. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY - Get rid of the unwieldy "Show a launcher when not running" and use Pin instead - Clarify that "Add to Panel" adds

[Differential] [Commented On] D3931: [Plasma folderview] Introduce "Back to Desktop" option in listview mode

2017-01-04 Thread hein (Eike Hein)
hein added a comment. > I "special cased" desktop because links were treated as folder only when folder view's location was set to "Desktop Folder". Ah! Actually, on further thought, I don't really having two different modes, and maybe having an "Up" in concert with the decision to

[Differential] [Request, 10 lines] D3947: Clean up after a window delegate drag exits the window.

2017-01-04 Thread hein (Eike Hein)
hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY BUG:373920 REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3947