broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
QDBusArgument MapType fits all kinds of maps but when we try to stream a map
of type other than a{sv} (which the MRPIS spec requires) into a QVariantMap we
would crash. Explicitly check signature to avoid this.
BUG: 374531
FIXED-IN: 5.8.6
TEST PLAN
This is clearly an application bug, Metadata *must* be a{sv} according to
spec but we shouldn't render Plasma unusable if a client is stupid.
I'll try to create a small testcase and report that issue to Qt, it shouldn't
crash in
QVariantMap map;
map << arg; // oops, it's not a{sv} but a{ss}
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3954
AFFECTED FILES
dataengines/mpris2/playercontainer.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
