[Differential] [Commented On] D3479: [libinput] Add more support for touchpads in preparation for the new touchpad KCM

graesslin added a comment. Looks good to me REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #kwin, #plasma Cc: graesslin, davidedmundson, plasma-devel, kwin, #kwin, lesl

[Differential] [Commented On] D3476: Support screenshot current screen and fullscreen on KWin/Wayland

graesslin added inline comments. INLINE COMMENTS > bgupta wrote in KWinWaylandImageGrabber.h:48 > Can we re-use the ImageGrabber::CaptureMode enum here? I would say no as the CaptureMode contains several choices which don't fit here. E.g. we cannot capture the ActiveWindow or a RectangularRegio

[Differential] [Commented On] D3481: [applets] Support KWin/Wayland in ColorPicker

graesslin added a comment. F521307: colorpicking.png REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3481 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma,

[Differential] [Updated] D3481: [applets] Support KWin/Wayland in ColorPicker

graesslin added a dependency: D3480: [effects] Add a colorpicker effect. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3481 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, broulik Cc: plasma-de

[Differential] [Updated] D3480: [effects] Add a colorpicker effect

graesslin added a dependent revision: D3481: [applets] Support KWin/Wayland in ColorPicker. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3480 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, bro

[Differential] [Commented On] D3475: Add interactive position selection to screenshot screen under cursor

graesslin added a comment. In https://phabricator.kde.org/D3475#64750, @bgupta wrote: > Does this mean taking a full screen screenshot also requires a click anywhere on the screen from the user? Or is the click optional? Yes taking full screen screenshot requires a click. The user

[Differential] [Request, 182 lines] D3481: [applets] Support KWin/Wayland in ColorPicker

graesslin created this revision. graesslin added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KWin provides a DBus interface for interactive color picking. This allows to have a color picke

[Differential] [Request, 241 lines] D3480: [effects] Add a colorpicker effect

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, broulik. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The effect exports itself to DBus as object "/ColorPicker"

[Differential] [Updated] D3480: [effects] Add a colorpicker effect

graesslin added a dependency: D3475: Add interactive position selection to screenshot screen under cursor. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3480 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_

[Differential] [Updated] D3475: Add interactive position selection to screenshot screen under cursor

graesslin added a dependent revision: D3480: [effects] Add a colorpicker effect. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3475 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, bgupta Cc: plas

[Differential] [Changed Subscribers] D3479: [libinput] Add more support for touchpads in preparation for the new touchpad KCM

davidedmundson added inline comments. INLINE COMMENTS > connection.h:49 > +Q_CLASSINFO("D-Bus Interface", "org.kde.KWin.InputDeviceManager") > +Q_PROPERTY(QStringList devicesSysNames READ devicesSysNames CONSTANT) > public: This isn't constant. Connection::processEvents() will update m_

[Differential] [Request, 781 lines] D3479: [libinput] Add more support for touchpads in preparation for the new touchpad KCM

subdiff created this revision. subdiff added reviewers: KWin, Plasma. subdiff added subscribers: KWin, plasma-devel. subdiff set the repository for this revision to rKWIN KWin. subdiff added a project: KWin. Restricted Application edited projects, added Plasma; removed KWin. Restricted Application

[Differential] [Accepted] D3469: [taskmanagerrulesrc] Add Rewrite Rule for chromium

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3469 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, hein

Google Code-in tasks -- we need them NOW

Hello folks, November 28th looms, and we are below our needed task count. * If you have already been invited to the GCi webapp, please get your tasks into the system now. We especially need beginning tasks, which can be the same as tasks last year, and they can be reused as often as we need them.

[Differential] [Closed] D3478: Port away from KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit rKGAMMAb1a14d377405: Port away from KDELibs4Support (authored by heikobecker). REPOSITORY rKGAMMA KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3478?vs=8458&id=8459 REVISION DETAIL h

[Differential] [Accepted] D3478: Port away from KDELibs4Support

cfeck accepted this revision. cfeck added a reviewer: cfeck. This revision is now accepted and ready to land. REPOSITORY rKGAMMA KGamma BRANCH master REVISION DETAIL https://phabricator.kde.org/D3478 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hei

[Differential] [Request, 22 lines] D3478: Port away from KDELibs4Support

heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY By - using KPluginFactory instead of the deprecated KGenericFactory - replacing KHBox with QWi

Re: Review Request 129503: Add FreeBSD to metainfo.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129503/ --- (Updated Nov. 23, 2016, 8:39 p.m.) Status -- This change has been ma

Re: Review Request 129475: Add FreeBSD to metainfo.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129475/ --- (Updated Nov. 23, 2016, 7:39 p.m.) Status -- This change has been ma

[Differential] [Accepted] D3476: Support screenshot current screen and fullscreen on KWin/Wayland

bgupta accepted this revision. bgupta added a comment. This revision is now accepted and ready to land. Looks lovely. I just have one nitpick, which is in an inline comment below. INLINE COMMENTS > KWinWaylandImageGrabber.h:48 > +void startReadImage(int readPipe); > +enum class Mode {

[Differential] [Updated] D3475: Add interactive position selection to screenshot screen under cursor

bgupta added a comment. Does this mean taking a full screen screenshot also requires a click anywhere on the screen from the user? Or is the click optional? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3475 EMAIL PREFERENCES https://phabricator.kde.org/settings/p

kirigami meeting notes

present: Aleix, Dan, Marco kirigami2 port nearing to freeze, a couple of potentially invasive changes still to be made, this week: * api change: in drawer and sheet opened->drawerOpen/sheetOpen, because opened is a signal in QQC2 API, annoying but avoids bigger problems in the future * Drop Spli

Re: Split the kioslaves out of plasma-workspace?

On Sat, Nov 5, 2016 at 1:07 PM, David Edmundson wrote: > > > On Fri, Nov 4, 2016 at 7:46 PM, Christoph Feck wrote: >> >> On 04.11.2016 19:20, kainz.a wrote: Radical different idea: what about moving Dolphin from Applications to Plasma? >>> >>> If this mean the plasma

[Differential] [Closed] D2155: kded: fix up invalid current mode before saving

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN96db1a9a1aed: correct possibly invalid current mode (authored by sebas). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2155?vs=5138&id=8454#toc REPOSITORY rKSCREEN KScreen CHANGES SINCE

[Differential] [Request, 304 lines] D3475: Add interactive position selection to screenshot screen under cursor

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, bgupta. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY A second interactive selection mode gets added to select a p

[Differential] [Request, 151 lines] D3476: Support screenshot current screen and fullscreen on KWin/Wayland

graesslin created this revision. graesslin added reviewers: Plasma on Wayland, bgupta. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY Comes with slight refactoring for better code sharing. REPOSITORY rSPECTA

[Differential] [Request, 105 lines] D3474: Sample implementation of window tabbing in breeze

chinmoyr created this revision. chinmoyr added reviewers: Plasma, KWin. chinmoyr set the repository for this revision to rBREEZE Breeze. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Sample implementation to check if

[Differential] [Request, 86 lines] D3473: Window Tabbing support in kwin

chinmoyr created this revision. chinmoyr added reviewers: Plasma, KWin, graesslin. chinmoyr set the repository for this revision to rKWIN KWin. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The code for window tabbing

[Differential] [Request, 508 lines] D3472: API for window tabbing

chinmoyr created this revision. chinmoyr added reviewers: Plasma, KWin, graesslin. chinmoyr set the repository for this revision to rKDECORATION Window Decoration Library. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY

[Differential] [Accepted] D3466: Implementation of PointerConstraints protcol

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH pointer-constraints REVISION DETAIL https://phabricator.kde.org/D3466 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Commented On] D3355: add maskArea in panel view

mvourlakos added a comment. In https://phabricator.kde.org/D3355#64617, @mart wrote: > In https://phabricator.kde.org/D3355#64430, @mvourlakos wrote: > > > My only small problem is that I havent found a way to access the PanelView visibility variable in order to alter it automatically

[Differential] [Closed] D3459: Add top_left_arrow cursor symlinks

This revision was automatically updated to reflect the committed changes. Closed by commit rBREEZE6316df30a995: Add top_left_arrow cursor symlinks (authored by elvisangelaccio). REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3459?vs=8412&id=8442 REVISION DE

[Differential] [Closed] D3463: [SDDM Theme] Add "lastUser" and "disableAvatarsThreshold" properties to dummydata

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE3deb4cd6234e: [SDDM Theme] Add "lastUser" and "disableAvatarsThreshold" properties to… (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE http

[Differential] [Closed] D3462: [SDDM Theme] Remember last username

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE83fac04b7d92: [SDDM Theme] Remember last username (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3462?vs=8415

[Differential] [Closed] D3450: [taskmanagerrulesrc] Add Rewrite Rule for chromium-browser

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6f4b4c26a8f6: [taskmanagerrulesrc] Add Rewrite Rule for chromium-browser (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricato

[Differential] [Closed] D3464: [SDDM Theme] Fix background in qmlscene by providing proper config dummy data

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE2f1efff8516a: [SDDM Theme] Fix background in qmlscene by providing proper config dummy data (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D3459: Add top_left_arrow cursor symlinks

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rBREEZE Breeze BRANCH add-top_left_arrow REVISION DETAIL https://phabricator.kde.org/D3459 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D3467: Ignore non-relevant modifiers when evaluating mouse actions

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH ignore-caps-lock-mouse-actions REVISION DETAIL https://phabricator.kde.org/D3467 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Commented On] D3355: add maskArea in panel view

mart added a comment. In https://phabricator.kde.org/D3355#64430, @mvourlakos wrote: > My only small problem is that I havent found a way to access the PanelView visibility variable in order to alter it automatically from my qml code or its c++ part. So the user must set correctly the Pl

[Differential] [Request, 7 lines] D3469: [taskmanagerrulesrc] Add Rewrite Rule for chromium

drosca created this revision. drosca added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Chromium also changed its window class to Chromium (was chromium before) TEST PLAN Chromium and its app

[Differential] [Closed] D3461: flip systray in ltr layouts

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE8db8722e0fb9: flip systray in ltr layouts (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3461?vs=8435&id=8436 R

[Differential] [Updated, 4 lines] D3461: flip systray in ltr layouts

mart updated this revision to Diff 8435. mart added a comment. - remove useless check on !vertical REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3461?vs=8413&id=8435 BRANCH arcpatch-D3461 REVISION DETAIL https://phabricator.kde.o

[Differential] [Abandoned] D3407: temporary visible panels out of availableScreenRect

mart abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3407 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreut

[Differential] [Request, 71 lines] D3467: Ignore non-relevant modifiers when evaluating mouse actions

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, broulik. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY E.g. CapsLock should not prevent Alt+left click move.