Re: Review Request 129298: KPackage dependencies support

2016-11-20 Thread Bhushan Shah
> On Nov. 21, 2016, 9:34 a.m., Bhushan Shah wrote: > > src/kpackage/private/packagejobthread.cpp, line 190 > > > > > > This can't (and doesn't, as evident by failing test on CI) work on CI > > for two reasons >

Re: Review Request 129298: KPackage dependencies support

2016-11-20 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/#review100996 --- src/kpackage/private/packagejobthread.cpp (line 190)

Review Request 129475: Add FreeBSD to metainfo.yaml.

2016-11-20 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129475/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Review Request 129503: Add FreeBSD to metainfo.yaml.

2016-11-20 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129503/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

[Differential] [Accepted] D3416: [Task Manager] Strip application:// prefix before looking up service

2016-11-20 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3416 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, #plasma Cc: plasma-dev

[Differential] [Accepted] D3415: [Task Manager] Pass local file to KService instead of stringified URL

2016-11-20 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3415 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, #plasma Cc: plasma-dev

[Differential] [Accepted] D3419: [effects] Handle windowShown and windowHidden in fade effect

2016-11-20 Thread hein (Eike Hein)
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY rKWIN KWin BRANCH fade-out-window-hidden REVISION DETAIL https://phabricator.kde.org/D3419 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Commented On] D3425: If we get a notification with no body, treat the subject line as the body

2016-11-20 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Heh, you were quicker :) Can we perhaps use the application name as summary in case none is set? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3425 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/ema

[Differential] [Commented On] D3425: If we get a notification with no body, treat the subject line as the body

2016-11-20 Thread apol (Aleix Pol Gonzalez)
apol added a comment. Is there a chance for a unit test there? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3425 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: apol, plasma-dev

Re: Review Request 129298: KPackage dependencies support

2016-11-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/ --- (Updated Nov. 20, 2016, 5:37 a.m.) Status -- This change has been ma

Re: Review Request 129298: KPackage dependencies support

2016-11-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/ --- (Updated Nov. 20, 2016, 11:35 a.m.) Review request for KDE Frameworks, Pl