----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/#review100996 -----------------------------------------------------------
src/kpackage/private/packagejobthread.cpp (line 190) <https://git.reviewboard.kde.org/r/129298/#comment67728> This can't (and doesn't, as evident by failing test on CI) work on CI for two reasons 1) kpackagehandlers are installed by frameworksintegration 2) Every package building on CI have differnt prefix, so CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 for kpackage is not same as one for frameworks. Possible solution is to mock the resolveHandler for autotests, so that this framework's autotests are functional without depending on other packages. - Bhushan Shah On Nov. 20, 2016, 4:07 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129298/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2016, 4:07 p.m.) > > > Review request for KDE Frameworks, Plasma, Dan Leinir Turthra Jensen, and > Marco Martin. > > > Repository: kpackage > > > Description > ------- > > Makes it possible to specify components to be installed together with a > KPackage. They will be specified by a url, we'll have handlers for any kind, > making reasonably extensible and doesn't tie us to a technology. > > See RR in frameworksintegration for kns and appstream&packagekit: > https://git.reviewboard.kde.org/r/129419/ > > > Diffs > ----- > > autotests/CMakeLists.txt 395b16e > autotests/data/testpackagesdep/contents/ui/main.qml PRE-CREATION > autotests/data/testpackagesdep/metadata.json PRE-CREATION > autotests/data/testpackagesdep/testpackagesdep.testappdataxml PRE-CREATION > src/kpackage/config-package.h.cmake 61f2f0c > src/kpackage/private/packagejobthread.cpp 0a0cc01 > src/kpackage/private/packagejobthread_p.h 1babf0b > > Diff: https://git.reviewboard.kde.org/r/129298/diff/ > > > Testing > ------- > > Can install packages with RR 129419 > > > Thanks, > > Aleix Pol Gonzalez > >
