[Breeze] [Bug 358224] breeze dark plasma look and feel: KDE4 applications are using mixed (light and dark) colors, rendering text unreadable

2016-11-18 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=358224 --- Comment #5 from k...@part4.tech --- (In reply to David Kahles from comment #4) > (In reply to kde from comment #2) > > Can this be switched from resolved? I'm having the same issue with Anki > > which is still using QT4. The problem also effects inpu

[Differential] [Accepted] D3413: Introduce a KWin/Wayland image grabber

2016-11-18 Thread bgupta (Boudhayan Gupta)
bgupta accepted this revision. bgupta added a comment. This is lovely. Thanks for doing this. REPOSITORY rSPECTACLE Spectacle BRANCH kwin-wayland REVISION DETAIL https://phabricator.kde.org/D3413 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Differential] [Updated] D3408: Don't set PanelView visibilty when opening/closing config

2016-11-18 Thread davidedmundson (David Edmundson)
davidedmundson retitled this revision from "Alt fix for D3407" to "Don't set PanelView visibilty when opening/closing config ". davidedmundson updated the summary for this revision. davidedmundson updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DE

[Differential] [Updated, 55 lines] D3408: Alt fix for D3407

2016-11-18 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 8313. davidedmundson added a comment. Fixed up code and tested properly REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3408?vs=8285&id=8313 REVISION DETAIL https://phabricator.kde.org/D340

[Differential] [Request, 816 lines] D3421: Restore system tray SNI manual test

2016-11-18 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In the change to the new system tray one of the old manual tests to run SNIs got lost. This r

[Differential] [Commented On] D3419: [effects] Handle windowShown and windowHidden in fade effect

2016-11-18 Thread Martin Gräßlin
graesslin added a comment. Please note: the fadeOut on windowHidden is not visible. This another bug which still needs investigation. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3419 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 203 lines] D3419: [effects] Handle windowShown and windowHidden in fade effect

2016-11-18 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, hein. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY For Wayland windows we can have a sequence of window unmapped

[Differential] [Commented On] D3355: add maskArea in panel view

2016-11-18 Thread mvourlakos (Michail Vourlakos)
mvourlakos added a comment. In https://phabricator.kde.org/D3355#63086, @mart wrote: > the advantage is that would use all the native controls for sizing the panel, sizing the icons in the panel etc, the bigger window would just be a presentation Martin I managed to subclass the

[Differential] [Closed] D3414: Fix AbstractClient::sizeForClientSize

2016-11-18 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN16c7650d760f: Fix AbstractClient::sizeForClientSize (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3414?vs=8302&id=8309 REVISION DETAIL ht

[Differential] [Accepted] D3414: Fix AbstractClient::sizeForClientSize

2016-11-18 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. REPOSITORY rKWIN KWin BRANCH fix-size-for-client-size-5.8 REVISION DETAIL https://phabricator.kde.org/D3414 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, subdiff, #plasma_on_wayland, sebas, broulik C

[Differential] [Updated, 2 lines] D3415: [Task Manager] Pass local file to KService instead of stringified URL

2016-11-18 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 8306. broulik added a comment. Use serviceByDesktopPath REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3415?vs=8303&id=8306 REVISION DETAIL https://phabricator.kde.org/D3415 AFFECTED FILES applets

[Differential] [Updated, 11 lines] D3416: [Task Manager] Strip application:// prefix before looking up service

2016-11-18 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 8305. broulik added a comment. QStringLiteral REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3416?vs=8304&id=8305 REVISION DETAIL https://phabricator.kde.org/D3416 AFFECTED FILES applets/taskmanag

[Differential] [Accepted] D3414: Fix AbstractClient::sizeForClientSize

2016-11-18 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH fix-size-for-client-size-5.8 REVISION DETAIL https://phabricator.kde.org/D3414 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Commented On] D3416: [Task Manager] Strip application:// prefix before looking up service

2016-11-18 Thread hein (Eike Hein)
hein added inline comments. INLINE COMMENTS > smartlauncherbackend.cpp:152 > +// desktop file name with application:// prefix > +static const QLatin1String applicationSchemePrefix("application://"); > + Just QStringLiteral maybe? REPOSITORY rPLASMADESKTOP Plasma Desktop REVIS

[Differential] [Updated] D3415: [Task Manager] Pass local file to KService instead of stringified URL

2016-11-18 Thread hein (Eike Hein)
hein added a comment. Can we / do we want to depend on the result of launcherUrl.toLocalFile() being a valid local path? Then we should use serviceByDesktopPath instead of serviceByStorageId. serviceByStorageId can work with a path, but the less fuzzy logic the better ... REPOSITORY rPLAS

[Differential] [Request, 11 lines] D3416: [Task Manager] Strip application:// prefix before looking up service

2016-11-18 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY According to Unity Launch

[Differential] [Accepted] D3412: [effects] Add a screenshot dbus method which takes a file descriptor

2016-11-18 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH screenshot-fd-variant REVISION DETAIL https://phabricator.kde.org/D3412 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 2 lines] D3415: [Task Manager] Pass local file to KService instead of stringified URL

2016-11-18 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KService doesn't know wha

[Differential] [Accepted] D3413: Introduce a KWin/Wayland image grabber

2016-11-18 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rSPECTACLE Spectacle BRANCH kwin-wayland REVISION DETAIL https://phabricator.kde.org/D3413 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 3 lines] D3414: Fix AbstractClient::sizeForClientSize

2016-11-18 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, broulik, subdiff. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The method is supposed to return the AbstractClien

[Differential] [Accepted] D3403: [effects] Show info message in interactive window screenshot mode

2016-11-18 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH screenshot-info-message REVISION DETAIL https://phabricator.kde.org/D3403 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences

[Differential] [Accepted] D3402: Drop OpenGL based color correction from KWin

2016-11-18 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH drop-color-correction REVISION DETAIL https://phabricator.kde.org/D3402 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D3408: Alt fix for D3407

2016-11-18 Thread mart (Marco Martin)
mart added a comment. in general +1, seems a bit cleaner one it's all well tested, it's ok for me INLINE COMMENTS > panelview.cpp:577 > +else if (containment() && (containment()->status() == > Plasma::Types::RequiresAttentionStatus )) { > +// || containment()->status() == P

Re: Review Request 129298: KPackage dependencies support

2016-11-18 Thread Marco Martin
> On Nov. 17, 2016, 5:06 p.m., Marco Martin wrote: > > like it, still have some issues with the > > my concern is that an id by itself is not really identifying information > > enough (would in this case for instance colorschemes.knsrc in the url > > identify something on the server which can

Re: Review Request 129298: KPackage dependencies support

2016-11-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/#review100927 --- Ship it! Ship It! - Marco Martin On Nov. 17, 2016, 4 p

[Differential] [Updated] D3413: Introduce a KWin/Wayland image grabber

2016-11-18 Thread Martin Gräßlin
graesslin added a task: T4458: [plasma] Spectacle support. REPOSITORY rSPECTACLE Spectacle REVISION DETAIL https://phabricator.kde.org/D3413 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, bgupta Cc: plasma-devel, lesliezha

[Differential] [Updated] D3413: Introduce a KWin/Wayland image grabber

2016-11-18 Thread Martin Gräßlin
graesslin added a dependency: D3405: Use KWindowSystem::isPlatformX11. REPOSITORY rSPECTACLE Spectacle REVISION DETAIL https://phabricator.kde.org/D3413 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, bgupta Cc: plasma-deve

[Differential] [Request, 202 lines] D3413: Introduce a KWin/Wayland image grabber

2016-11-18 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma on Wayland, bgupta. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY This new ImageGrabber makes use of the new DBus interface introduced with

[Differential] [Request, 105 lines] D3412: [effects] Add a screenshot dbus method which takes a file descriptor

2016-11-18 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The idea behind this mode is to support applications like spectacle

Re: Review Request 129298: KPackage dependencies support

2016-11-18 Thread Dan Leinir Turthra Jensen
> On Nov. 17, 2016, 5:06 p.m., Marco Martin wrote: > > like it, still have some issues with the > > my concern is that an id by itself is not really identifying information > > enough (would in this case for instance colorschemes.knsrc in the url > > identify something on the server which can

[Breeze] [Bug 358224] breeze dark plasma look and feel: KDE4 applications are using mixed (light and dark) colors, rendering text unreadable

2016-11-18 Thread David Kahles
https://bugs.kde.org/show_bug.cgi?id=358224 David Kahles changed: What|Removed |Added CC||david.kahle...@gmail.com --- Comment #4 from Dav