mart added a comment.

  in general +1, seems a bit cleaner one it's all well tested, it's ok for me

INLINE COMMENTS

> panelview.cpp:577
> +    else if (containment() &&  (containment()->status() == 
> Plasma::Types::RequiresAttentionStatus )) {
> +//              || containment()->status() == Plasma::Types::HiddenStatus)) {
> +        autoHide = false;

why this got commented out? (that's the one that should be really checked 
thoroughly)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3408

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Reply via email to