[Differential] [Changed Subscribers] D2718: show an OSD on display button press

graesslin added inline comments. INLINE COMMENTS > daemon.cpp:235-237 > +QString message = i18nc("OSD text after XF86Display button press", "No > External Display"); > +if (m_monitoredConfig && m_monitoredConfig->connectedOutputs().count() > > 1) { > +message = i18nc("OSD text a

[Differential] [Closed] D2636: Remove non visible internal windows from the x stacking order

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN8d4204ac0d13: Remove non visible internal windows from the x stacking order (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2636?vs=6393&id=65

[Differential] [Updated] D2711: add osd slot for screen layout changes

sebas added a dependent revision: D2718: show an OSD on display button press. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2711 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: broulik, plasm

[Differential] [Request, 20 lines] D2718: show an OSD on display button press

sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Show the plasma OSD with icon "preferences-desktop-display-randr" and text when the display button has been pre

[Differential] [Updated] D2718: show an OSD on display button press

sebas added a dependency: D2711: add osd slot for screen layout changes. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2718 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: plasma-devel, lesliezhai, ali-mohame

[Differential] [Commented On] D2711: add osd slot for screen layout changes

sebas added a comment. I had a look at showing the OSD on all screens, and it isn't looking very simple. The situation is as follows: In kscreen, we already have an OSDs, the one when you click on the "Identify" button in bottom right corner the display configuration module's layout view

[Differential] [Updated, 2 lines] D2711: add osd slot for screen layout changes

sebas updated this revision to Diff 6562. sebas added a comment. just export showText, instead of adding a redirection This makes the patch rather simpler and adds a generic method to the dbus object, rather than a specialized name of the call: so showText() vs. screenLayoutChanged().

Re: Review Request 128856: Adds a check for kauthorized ghns so administrators can disable ghns if wanted

> On Sept. 8, 2016, 2:16 a.m., Kai Uwe Broulik wrote: > > src/button.cpp, line 79 > > > > > > Doesn't this need i18n? Also the wording is a bit technical. Yes it does. If you have a better idea for wording I'll c

[Differential] [Commented On] D2691: [Touchpad plasmoid] Major cleanup

colomar added a comment. Looks fine to me REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2691 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, mart Cc: colomar, mart, plasma-dev

[Differential] [Request, 59 lines] D2712: Add a utility to extract config entries from plasmoid xfcg files

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add a small utility to extract config entries from plasmoid xfcg files and export it into med

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

colomar added a comment. In https://phabricator.kde.org/D2680#50099, @ivan wrote: > I meant more of a single shortcut 'Meta+PlasmaKey' which focusses on plasma and shows the overlays. No further shortcuts needed. > > And this would be possible to generalize later to access systray app

[Differential] [Commented On] D2711: add osd slot for screen layout changes

sebas added a comment. yeah ... I don't think it does it right now, and it's perhaps not that critical for now. Anyway, I'll have a look later on, if you have comments on my patch as is, they're welcome to compress the review process a bit. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REV

Documenting applet config keys

For scripting purposes it's important to know the configuration keys of an applet/wallapper/containment . Currently this is written into the wiki, which isn't a good way to do documentation, it gets out of sync. I wrote a script that reads kcfg xml files and autogenerates the docs for the wiki. (

[Differential] [Commented On] D2711: add osd slot for screen layout changes

broulik added a comment. > I think this osd should show up on both screens, will do that once off the train Makes sense for the screen OSD but I rather not have my volume OSD show up on both screens. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.k

[Differential] [Request, 6 lines] D2711: add osd slot for screen layout changes

sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch adds an OSD to the dbus object so we can hook up layout changes of the XF86Display button. The method

[Differential] [Request, 1 line] D2708: Hide clock if there's no room to show it all

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D27

[Differential] [Request, 50 lines] D2707: Keep action buttons in screen if we can't match design gap

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D27

[Differential] [Request, 2 lines] D2705: Fix warnings

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY DefaultListItemBackground expects the item to be called listItem REPOSITORY rKIRIGAMI Kirigami BRANCH

[Differential] [Updated, 175 lines] D2693: Standardize Drawer width

apol updated this revision to Diff 6538. apol added a comment. - Fix warnings REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2693?vs=6513&id=6538 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2693 AFFECTED FILES examples/gallery/

[Differential] [Accepted] D2704: [Activity Manager] Hide "Create Activity" and "Delete Activity" if not authorized

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2704 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Request, 20 lines] D2704: [Activity Manager] Hide "Create Activity" and "Delete Activity" if not authorized

broulik created this revision. broulik added reviewers: Plasma, ivan. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When the "plasma-desktop/

[Differential] [Request, 6 lines] D2703: Fix applets not being added on service restart

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Applet::destroy doesn't delete the applet from Containment::applets in the same event. Potent

Re: Review Request 128856: Adds a check for kauthorized ghns so administrators can disable ghns if wanted

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128856/#review98992 --- src/button.cpp (line 79)

Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect when close window in group item

> On Авг. 20, 2016, 8:21 след обяд, Anthony Fieroni wrote: > > Ping, whats wrong to push it? > > Martin Gräßlin wrote: > Eike is currently on vacations. Let's wait for him to give a chance to > have another look. For master? - Anthony ---

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

> On Čec. 28, 2016, 6:02 dop., Painless Roaster wrote: > > Ship It! > > Eike Hein wrote: > Do you need someone to commit this for you? > > Painless Roaster wrote: > I do not have an account on github. > > Eike Hein wrote: > Thanks, I'll see about getting this in next week. > > Eik