> On Sept. 8, 2016, 2:16 a.m., Kai Uwe Broulik wrote: > > src/button.cpp, line 79 > > <https://git.reviewboard.kde.org/r/128856/diff/1/?file=476426#file476426line79> > > > > Doesn't this need i18n? Also the wording is a bit technical.
Yes it does. If you have a better idea for wording I'll change that at the same time. - Jeremy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128856/#review98992 ----------------------------------------------------------- On Sept. 7, 2016, 3:43 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128856/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2016, 3:43 p.m.) > > > Review request for Plasma, Aleix Pol Gonzalez, Kai Uwe Broulik, and David > Faure. > > > Bugs: 368240 > https://bugs.kde.org/show_bug.cgi?id=368240 > > > Repository: knewstuff > > > Description > ------- > > This shows a messagebox if ghns dialogs are invoked either by the button or > the dialog's exec, open, or show methods if ghns is disabled in kdeglobals > (or the applications rc file). > > > Diffs > ----- > > src/button.cpp 1772d86 > src/downloaddialog.h 0a39f5d > src/downloaddialog.cpp b172e6a > > Diff: https://git.reviewboard.kde.org/r/128856/diff/ > > > Testing > ------- > > Works ok except for the plasma wallpaper case which is doing some strange > pointer.data() to set the window title and somehow goes around these checks. > Need to figure out why it's doing that and if it's still neeeded there or how > to catch those calls to show also. > > > Thanks, > > Jeremy Whiting > >
