https://bugs.kde.org/show_bug.cgi?id=361281
--- Comment #2 from Martin Gräßlin ---
KSysguard is a workspace component. As long as
https://bugreports.qt.io/browse/QTBUG-55384 is not fixed we should not port any
workspace component to WebEngine.
--
You are receiving this mail because:
You are the
kossebau created this revision.
kossebau added reviewers: Plasma, mart, sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Currently plasma_install_package fails if KDE_INSTALL_DIRS_NO_DEPRECATED
is set to TRUE, beca
> On Aug. 30, 2016, 10:57 p.m., Eike Hein wrote:
> > Tech-wise I have no objections, the SVG looks clean.
> >
> > Design-wise I'm conflicted. Unlike the old implementation of the lines,
> > this time no attempt was made to vert-center the content in the remaining
> > negative space. This avoid
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/#review98803
---
Ship it!
Tech-wise I have no objections, the SVG looks cle
> On Aug. 30, 2016, 10:30 p.m., Eike Hein wrote:
> > I can't seem to review this because the patch doesn't contain the changed
> > binary file. I was unable to download the svgz from the web UI or via
> > reviewboard-am. I don't know if Reviewboard supports any patch format with
> > binary con
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/#review98799
---
I can't seem to review this because the patch doesn't contain
> On Aug. 16, 2016, 7:11 vorm., David Faure wrote:
> > Can you move it to kde-baseapps, along with any other konqueror-related
> > docbook?
>
> Burkhard Lück wrote:
> move khtml-behavior, bookmarks, html-java-js, khtml-adblock, history,
> performance, kcmcss, filemanager, khtml-general pre
> On July 28, 2016, 6:02 a.m., Painless Roaster wrote:
> > Ship It!
>
> Eike Hein wrote:
> Do you need someone to commit this for you?
>
> Painless Roaster wrote:
> I do not have an account on github.
>
> Eike Hein wrote:
> Thanks, I'll see about getting this in next week.
Can you
https://bugs.kde.org/show_bug.cgi?id=361281
Fabian Vogt changed:
What|Removed |Added
CC||fab...@ritter-vogt.de
--- Comment #1 from Fabian
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/294/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 30 Aug 2016 16:15:43 +
Build duration: 17 min
CHANGE SET
Revision fe6ea35841ee3649b4feb756fba41fbb41ce
wbauer added a comment.
In https://phabricator.kde.org/D2610#48966, @colomar wrote:
> or clicking on a different widget on the desktop might execute an action
immediately, which is inconsistent again.
It's just that those two are more like (folderview) icons than other widgets.
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/293/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 30 Aug 2016 16:00:58 +
Build duration: 10 min
CHANGE SET
Revision b5fd8c353448f3b1fb50249fd7f4c3d17551
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPb5fd8c353448: Colors KCM: Correct regression in
previews introduced during rewritting (authored by ochurlaud).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2631?vs=6374&id=6375#toc
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/292/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 30 Aug 2016 15:52:11 +
Build duration: 4 min 5 sec
CHANGE SET
Revision 152fadd936b06e44a15e3385b562d02a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/
---
(Updated Aug. 30, 2016, 3:54 p.m.)
Review request for Plasma.
Changes
-
davidedmundson abandoned this revision.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2611
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterb
davidedmundson added a comment.
In https://phabricator.kde.org/D2610#48964, @wbauer wrote:
> In https://phabricator.kde.org/D2610#48934, @colomar wrote:
>
> > The only raison d'être for "double-click to open" is to be able to select
on single click. If selecting is not possible (as is
colomar added a comment.
> What you say does make sense, but I'd like to note that in KDE4 they did
respect the single-/double-click settings (when on the desktop, not in the
panel), so this can be seen as "regression" in Plasma5.
I'd call it an improvement, actually, because now it make
wbauer added a comment.
In https://phabricator.kde.org/D2610#48934, @colomar wrote:
> The only raison d'être for "double-click to open" is to be able to select
on single click. If selecting is not possible (as is the case both in the panel
and in a desktop containment), there is no reaso
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2631
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/e
ochurlaud created this revision.
ochurlaud added reviewers: andreask, Plasma, pino, mart.
ochurlaud added a subscriber: andreask.
ochurlaud set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscribe
luebking added inline comments.
INLINE COMMENTS
> effects.cpp:1560
> +const auto typeId = qMetaTypeId>();
> +for (int i = 0; i < e->metaObject()->methodCount(); ++i) {
> +auto method = e->metaObject()->method(i);
Errr... wut?
Any reason to not *demand* some sort of soft API (slot
graesslin added a comment.
In https://phabricator.kde.org/D2627#48943, @luebking wrote:
> Fixwise good, APIwise, maybe add AbstractClient::placeIn(QRect &area) {
Placement::self()->place(this, area); setGeometryRestore(geometry()); } to
> a) prevent uninformed messing around with the r
luebking added a comment.
Fixwise good, APIwise, maybe add AbstractClient::placeIn(QRect &area) {
Placement::self()->place(this, area); setGeometryRestore(geometry()); } to
a) prevent uninformed messing around with the restore geomery
b) guarantee sync behavior (when placing occurs)
?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/
---
(Updated Aug. 30, 2016, 2:22 p.m.)
Review request for Plasma.
Changes
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/#review98791
---
+1
Perfect.
(I would still like Eike to look over the margi
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
So far TabBox used highlight windows by passing window ids around th
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/
---
(Updated Aug. 30, 2016, 2:04 p.m.)
Review request for Plasma.
Repositor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/
---
(Updated Aug. 30, 2016, 2:03 p.m.)
Review request for Plasma.
Repositor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/
---
(Updated Aug. 30, 2016, 2:02 p.m.)
Review request for Plasma.
Changes
-
colomar added a comment.
The only raison d'être for "double-click to open" is to be able to select on
single click. If selecting is not possible (as is the case both in the panel
and in a desktop containment), there is no reason for opening only on
double-click (other than consistency with W
davidedmundson added a comment.
In https://phabricator.kde.org/D2610#48932, @broulik wrote:
> Hmm, now we have a bit of an inconsistent situtation in a panel. Everything
(including task manager launchers) activates by single click except for custom
icons and trash.
Didn't think o
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128800/
---
(Updated Aug. 30, 2016, 1:05 p.m.)
Status
--
This change has been ma
broulik added a comment.
Hmm, now we have a bit of an inconsistent situtation in a panel. Everything
(including task manager launchers) activates by single click except for custom
icons and trash.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D
broulik added inline comments.
INLINE COMMENTS
> statusnotifieritemsource.cpp:85
> +//when it gets data with a new key it tries to update the QAIM roleNames
> +//from QML this achieves absolutely nothing as there is no signal to
> tell QQmlDelegateModel to reload the roleNames in QQmlAd
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland, bshah.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
The restore geometry gets initially set to 0/0xsize before th
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/78/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 30 Aug 2016 09:43:57 +
Build duration: 8 min 44 sec
CHANGE SET
Revision 3c4afedeffe6990aa82d
> On Aug. 30, 2016, 8:43 vorm., Kai Uwe Broulik wrote:
> > Nice work!
> >
> > Combining the best of both worlds, unintrusive lines where possible but
> > filled background where needed.
> >
> > I like that the text somewhat "sits" on the line (top panel) but descenders
> > of letters like "g"
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/#review98786
---
Nice work!
Combining the best of both worlds, unintrusive li
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128800/#review98785
---
Ship it!
Ship It!
- Marco Martin
On Aug. 29, 2016, 9:24
> On Aug. 30, 2016, 8:06 a.m., Marco Martin wrote:
> > can't download the icon
https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/tasks/start.svgz
- Andreas
---
This is an automatically generated e-mail. To reply, visit:
https://git.re
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128793/#review98783
---
Maybe "...has MTP enabled in its USB connection settings"?
We
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/404/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 30 Aug 2016 06:52:53 +
Build duration: 1 hr 19 min
CHANGE SET
Revision 86af75bc112fbebc31dc7dc4e90b1e
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128800/#review98782
---
can't download the icon
- Marco Martin
On Aug. 29, 2016, 9
44 matches
Mail list logo