[Differential] [Updated, 31 lines] D2613: Fix some status notifier items not appearing

davidedmundson updated this revision to Diff 6333. davidedmundson added a comment. minor fix REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2613?vs=6332&id=6333 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2613 AFFE

[Differential] [Request, 31 lines] D2613: Fix some status notifier items not appearing

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Set the initial values for all the things This is important as Plasma::DataModel has an unsol

Jenkins-kde-ci: khotkeys Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 27 Aug 2016 20:06:17 + Build duration: 9 min 9 sec CHANGE SET No changes JUNIT RESULTS Na

Jenkins-kde-ci: khotkeys Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 27 Aug 2016 20:06:17 + Build duration: 9 min 9 sec CHANGE SET No changes JUNIT RESULTS Na

[Differential] [Changed Subscribers] D2610: Make icon follow styleHints

broulik added inline comments. INLINE COMMENTS > main.qml:21 > > +import QtQml 2.2 > import QtQuick 2.0 I don't think this import is neccessary, "styleHints object is only available when using the Qt Quick module." anyway. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL ht

[Differential] [Accepted] D2612: [Logout Dialog] Set avatarPath

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2612 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Request, 3 lines] D2612: [Logout Dialog] Set avatarPath

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Set avatarPath to the use

[Differential] [Accepted] D2607: [System Tray] Fix warning

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. > No more warning on startup Well that's a bold claim :P REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Request, 4 lines] D2611: Make trash follow styleHints

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 348960 Test Plan: Set mouse to double click. Added icon item Clicked Reviewers: #plasma Subscriber

[Differential] [Request, 5 lines] D2610: Make icon follow styleHints

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY CCBUG: 348960 TEST PLAN Set mouse to double click. Added icon item Clicked REPOSITORY r

[Differential] [Request, 123 lines] D2609: Drop custom systemsettings import, move to QtQml.styleHints

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Cleaner code TEST PLAN grep all QML for any other users of SystemSettings Test applet hand

[Differential] [Closed] D2594: Add new session button to SessionsModel

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE82b0aa2ada43: Add new session button to SessionsModel (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2594?vs=6305&id=6326#toc REPOSITORY rPLASMAWORKS

[Differential] [Request, 4 lines] D2608: [System Tray] Silence warning

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY internalSystray is (for s

[Differential] [Request, 2 lines] D2607: [System Tray] Fix warning

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's PlasmaCore.Types.Unk

[Differential] [Abandoned] D2606: Use QGuiApplication::styleHints to check for singleClickActivation

davidedmundson abandoned this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2606 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreut

[Differential] [Request, 13 lines] D2606: Use QGuiApplication::styleHints to check for singleClickActivation

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2606

[Differential] [Accepted] D2605: [Desktop Containment] Create AppletAppearance component only once

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2605 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Request, 21 lines] D2605: [Desktop Containment] Create AppletAppearance component only once

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead cache the created comp

[Differential] [Commented On] D2595: Fix comic applet appearance

davidedmundson added a comment. Edit: I was wrong about this being a regression. It seems this has always been here. the switch between showing compact and full is: Math.max(minimumWidth, Math.min(centerLayout.comicData.image.nativeWidth * 0.6, implicitWidth)); or implicitWidth

[Differential] [Commented On] D2595: Fix comic applet appearance

davidedmundson added a comment. Thanks, but this is isn't the right fix comic applet hasn't changed which means it's a change in plasma-framework (probably) fixing it here will still leave potentially 3rd party applets broken, and if it is plasma-framework will still leave it broken for

Re: Review Request 128761: Fix crash on exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/#review98718 --- Calling exit() before deleting the QApplication is explicitly

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 288 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/288/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 27 Aug 2016 11:46:46 + Build duration: 16 min CHANGE SET Revision 1010a511e0473b0ff7b1648d706cf41ad23c

Re: task manager lines instead of blocks

I was under the impression that this was already well under way... Note that plasma frameworks freeze is next Saturday (given the recent breaking changes in the theme I don't feel comfortable with theme changes that late in the cycle) and the Frameworks release thereafter will be tight for Plasm

Re: Review Request 128761: Fix crash on exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/#review98712 --- Ship it! Ship It! - Hugo Pereira Da Costa On Aug. 27, 2

Re: Review Request 128761: Fix crash on exit

> On Aug. 27, 2016, 9:14 a.m., Hugo Pereira Da Costa wrote: > > mmm. But then i think it is better (for commit history etc), to just revert > > the incriminated commit (and in oxygen as well), with a possible link to > > this RB. makes sense ? > > Peter Wu wrote: > I tested the reverts for

Re: Review Request 128761: Fix crash on exit

> On Aug. 27, 2016, 11:14 a.m., Hugo Pereira Da Costa wrote: > > mmm. But then i think it is better (for commit history etc), to just revert > > the incriminated commit (and in oxygen as well), with a possible link to > > this RB. makes sense ? I tested the reverts for breeze and oxygen and th

Re: Review Request 128761: Fix crash on exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/#review98709 --- mmm. But then i think it is better (for commit history etc),

Re: Review Request 128761: Fix crash on exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/ --- (Updated Aug. 27, 2016, 11:12 a.m.) Review request for Plasma, David Edmu

Re: Review Request 128760: Fix crash on exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128760/ --- (Updated Aug. 27, 2016, 11:04 a.m.) Review request for Plasma, David Edmu

task manager lines instead of blocks

Should I work on it? Andreas

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

> On Aug. 26, 2016, 4:22 a.m., Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this way >