broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY Instead cache the created component. Also check its status rather than doing a string comparison on errorString and only call it if it actually failed. Moreover, initialize AppletAppearnce already with category set. TEST PLAN Still works. QML Engine has a component cache but still I think calling Qt.createComponent repeatedly (especially since gc will collect it later on when it falls out of scope) should be avoided? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2605 AFFECTED FILES containments/desktop/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
