Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 300 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/300/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 04 Aug 2016 05:49:16 + Build duration: 13 min CHANGE SET Revision fa0b7a9463b4f115196e05edbcebe3603c

[Differential] [Closed] D2342: Use new KWindowSystem platform check API

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEfa0b7a9463b4: Use new KWindowSystem platform check API (authored by graesslin). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2342?

[Differential] [Commented On] D2345: use a separate configuration per look and feel

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in shellcorona.cpp:469 > how would you notice knf has been changed? only info about it is that key in > kdeglobals DBus signal from the KCM. It's how we do fonts, styles, colours etc. > mart wrote in shellcorona.cpp:511 > can

Re: Review Request 128590: Let kpackagetool5 generate appstream information for kpackage components

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128590/ --- (Updated Aug. 4, 2016, 2:38 a.m.) Status -- This change has been mar

[Differential] [Request, 46 lines] D2347: Use a Timer to switch on hover event handling and do the initial geo export.

hein created this revision. hein added reviewers: Plasma, mart. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Different versions of Qt (or maybe it's the position of Jupiter-vs- Saturn) seem to behave differently with regard to whether

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 64 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 03 Aug 2016 20:41:46 + Build duration: 15 min CHANGE SET Revision e737c905f095c2380d881ea76b0

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 64 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 03 Aug 2016 20:41:46 + Build duration: 15 min CHANGE SET Revision e737c905f095c2380d881ea76b0

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 63 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/63/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 03 Aug 2016 20:37:01 + Build duration: 3 min 16 sec CHANGE SET Revision 41f293891f06f2f4e14a5

[Differential] [Reopened] D2345: use a separate configuration per look and feel

mart reopened this revision. This revision now requires changes to proceed. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2345 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, davidedmundson Cc: d

Re: org.kde.kinfocenter.energy.private

Follow up: i misread the mail, it does work, right? It's just Harold's thing doesn't find it? I didn't want to make another installed qml plugin as the kcm itself is already one. I probably could have just exposed the KCModule itself as context property and access the models from there. I can

[Differential] [Closed] D2345: use a separate configuration per look and feel

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE71eb75da019d: more explanatory comments (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2345?vs=5652&id=5657#toc REPOSITORY rPLASMAWORKSPACE Plasma Workspace C

Re: org.kde.kinfocenter.energy.private

Hi, that import is registered in the KCModule's constructor, it is *not* an installed traditional qml plugin. Also it seems rather it's looking for the kcm's cpp plugin itself? At least the QML is loading it seems. I don't know how that KCModule QML stuff works, Marco came up with that :/ Che

Review Request 128594: Add a kapptemplate for Plasma Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128594/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: p

org.kde.kinfocenter.energy.private

Harald did a nifty qml dep checker for neon. Looking at KInfoCenter it asks for org.kde.kinfocenter.energy.private but I'm not convinced that exists possibly not by coincidence I get errors running the energy module in kinfocenter org.kde.kcoreaddons: Error loading plugin "kcm_energyinfo" "The

[Differential] [Commented On] D2345: use a separate configuration per look and feel

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in shellcorona.cpp:469 > why are we tracking file modifications? > That's not how the rest of the KCMs work. how would you notice knf has been changed? only info about it is that key in kdeglobals > davidedmundson wrote in shel

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

> On Aug. 3, 2016, 4:50 p.m., Anthony Fieroni wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 500 > > > > > > This line must be > > if (s_d && wasCompositing != s_d->compositingEnable) { why do you thin

[Differential] [Requested Changes To] D2345: use a separate configuration per look and feel

davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > shellcorona.cpp:469 > + > +void ShellCorona::updateLookAndFeelPackage(const QString &file) > +

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/#review98056 --- src/platforms/xcb/kwindowsystem.cpp (line 500)

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

> On Aug. 3, 2016, 2:02 nachm., Kai Uwe Broulik wrote: > > kwindowsystem master fails to build: > > > > kwindowsystem/src/platforms/xcb/kwindowsystem.cpp:441:48: error: ‘class > > NETEventFilter’ has no member named ‘compositingEnabled’ > > const bool wasCompositing = s_d ? s_d->compos

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

> On Aug. 3, 2016, 4:02 p.m., Kai Uwe Broulik wrote: > > kwindowsystem master fails to build: > > > > kwindowsystem/src/platforms/xcb/kwindowsystem.cpp:441:48: error: ‘class > > NETEventFilter’ has no member named ‘compositingEnabled’ > > const bool wasCompositing = s_d ? s_d->composit

[Differential] [Commented On] D1479: [Notifications] Limit notification size and add scroll bar if needed

broulik added a comment. Thanks for your feedback > It is possible to scroll one letter to the right, although there is a automatic line break. I suppose that's the are the scroll bar occupies, I'll have a look. > I do not know if this is intended, but it does not look correct t

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 299 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/299/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 03 Aug 2016 14:23:57 + Build duration: 9 min 4 sec CHANGE SET Revision 42bb89282c8caf6e406d353037d1c

[Differential] [Commented On] D1479: [Notifications] Limit notification size and add scroll bar if needed

tillschafer added a comment. There are a few glitches left. 1. It is possible to scroll one letter to the right, although there is a automatic line break. Compare screenshot "start of message" and "scroll right" to get an idea of the meaning. A guess: the width calculation does not inclu

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/#review98051 --- kwindowsystem master fails to build: kwindowsystem/src/platf

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 298 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/298/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 03 Aug 2016 13:19:55 + Build duration: 13 min CHANGE SET Revision 25aebf4e1ccd64c70e56f9d82efdc81448

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 297 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/297/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 03 Aug 2016 12:26:23 + Build duration: 16 min CHANGE SET Revision 7981aeeff534b646489eb58b1458f8f790

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon l

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 296 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/296/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 03 Aug 2016 11:19:14 + Build duration: 14 min CHANGE SET Revision c23f894d8bbe95122361f9877c67d5fb89

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon l

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

> On Aug. 3, 2016, 7:38 vorm., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon l

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon l

Re: Review Request 128579: Use KPackage to install Plasma Packages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128579/ --- (Updated Aug. 3, 2016, 11:06 a.m.) Status -- This change has been ma

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/ --- (Updated Aug. 3, 2016, 11:05 a.m.) Status -- This change has been ma

Re: Review Request 128590: Let kpackagetool5 generate appstream information for kpackage components

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128590/ --- (Updated Aug. 3, 2016, 1:03 p.m.) Review request for KDE Frameworks, Plas

[Differential] [Updated] D2111: User interface for adding launchers as global shortcuts

graesslin added a comment. Looks good to me. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2111 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, graesslin Cc: plasma-devel, ali-mohamed, jensreuterberg, abe

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/#review98044 --- Can we have an autotest for this custom iconloader case? - K

Re: Review Request 128588: Make it possible to load metadata.json file from kpackagetool5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128588/ --- (Updated Aug. 3, 2016, 10:50 a.m.) Status -- This change has been ma

[Differential] [Commented On] D2345: use a separate configuration per look and feel

ivan added a comment. All in all, seems ok. I think we need to start commenting code like this - what it is doing. I do realize it is popular for the code to be self-documenting, but that has not been working for us that well :) Can you write short instructions on how to test this?

[Differential] [Accepted] D2342: Use new KWindowSystem platform check API

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. The port away from an explicit xcb check gave me a little pause, but I don't think it matters in practice. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH kwindowsystem-platform-check

[Differential] [Updated, 238 lines] D2345: use a separate configuration per look and feel

mart updated this revision to Diff 5652. mart added a comment. - more explanatory comments REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2345?vs=5651&id=5652 BRANCH mart/separateLookAndFeelLayout REVISION DETAIL https://phabricat

[Differential] [Updated] D2345: use a separate configuration per look and feel

mart added a dependency: D2339: support plasmoid config restore on applet add. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2345 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel,

[Differential] [Updated] D2339: support plasmoid config restore on applet add

mart added a dependent revision: D2345: use a separate configuration per look and feel. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2339 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, hein Cc: pl

[Differential] [Updated] D2345: use a separate configuration per look and feel

mart added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2345 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas _

[Differential] [Request, 234 lines] D2345: use a separate configuration per look and feel

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY plasmashell has a different configuration for every lnf theme. upon switching theme, tear down the whole shell and reload it with the new conf

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/ --- (Updated Aug. 3, 2016, 11:34 a.m.) Status -- This change has been ma

Re: Review Request 128572: [autotest] Extend ThemeTest with a case for compositing changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128572/ --- (Updated Aug. 3, 2016, 11:28 a.m.) Status -- This change has been ma

[Differential] [Closed] D2343: [wayland] Always have a keyboard on the Seat

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN4c6c4e6717f3: [wayland] Always have a keyboard on the Seat (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2343?vs=5648&id=5650 REVISION DETA

[Differential] [Accepted] D2341: Lazy guard for KServiceGroup::root() being null.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2341 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/#review98041 --- Ship it! Ship It! - Marco Martin On Aug. 2, 2016, 12:11

Re: Review Request 128572: [autotest] Extend ThemeTest with a case for compositing changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128572/#review98040 --- Ship it! Ship It! - Marco Martin On Aug. 2, 2016, 8:53

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/#review98039 --- Ship it! Ship It! - Marco Martin On Aug. 2, 2016, 9:11

[Differential] [Accepted] D2343: [wayland] Always have a keyboard on the Seat

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH seat-always-keyboard REVISION DETAIL https://phabricator.kde.org/D2343 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah, #plasm

Re: Review Request 128579: Use KPackage to install Plasma Packages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128579/#review98038 --- Ship it! Ship It! - Marco Martin On Aug. 2, 2016, 4:26

Re: Review Request 128588: Make it possible to load metadata.json file from kpackagetool5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128588/#review98037 --- Ship it! Ship It! - Marco Martin On Aug. 3, 2016, 12:56

Re: Review Request 128590: Let kpackagetool5 generate appstream information for kpackage components

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128590/#review98036 --- Fix it, then Ship it! can't really comment on appstream re

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/#review98035 --- Why does it break for SNIs? It first tries QIcon::fromTheme a

[Differential] [Updated] D2344: Make linux/input.h compile time optional

tcberner added a comment. On FreeBSD we have linux/input.h provided by multimedia/v4l_compat [1] -- which we already depend on at the moment. But I think it's a good idea to make it optional. [1] https://www.freshports.org/multimedia/v4l_compat REPOSITORY rKWAYLAND KWayland REVIS

[Differential] [Updated] D2344: Make linux/input.h compile time optional

graesslin added a reviewer: tcberner. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D2344 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, tcberner Cc: plasma-devel, ali-mohamed, jensreuterberg, a

[Differential] [Request, 98 lines] D2344: Make linux/input.h compile time optional

graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY Instead of hard depending on the include of linux/input.h we check whether that i