----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/#review98039 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Aug. 2, 2016, 9:11 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128580/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 9:11 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Currently the code gets the icon name from the QIcon and tries to do > some Plasma theming with it. > However if that fails it then loads the QIcon::fromTheme again. > > This is pointless in most cases and will break any icons that have a > custom loader (all SNIs) > > > Diffs > ----- > > src/declarativeimports/core/iconitem.cpp > 29c7f05b5df060df7b362b331f7edc412df12307 > > Diff: https://git.reviewboard.kde.org/r/128580/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
