[Differential] [Commented On] D2270: Try to be more clever about what sink to use for volume control

ochurlaud added a comment. Just tested, in my case it solves https://bugs.kde.org/show_bug.cgi?id=365771 REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2270 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 172 lines] D2270: Try to be more clever about what sink to use for volume control

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This changes the applet to display volume icon and control volume through scroll / global shortcuts of "prefe

[Differential] [Request, 4 lines] D2268: Fix loading if KActivities is in state NotRunning

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Used to work, then patch https://phabricator.kde.org/rPLASMAWORKSPACEf7ef6ee87b8957bebc976b6fc

Re: [plasma-workspace/Plasma/5.7] shell: don't try to load layout before kamd starts

Hello Marco and co. On Wed, Jul 20, 2016 at 11:59:37AM +, Marco Martin wrote: > Git commit f7ef6ee87b8957bebc976b6fc9e0df279cea05f1 by Marco Martin. > Committed on 20/07/2016 at 11:57. > Pushed by mart into branch 'Plasma/5.7'. > > don't try to load layout before kamd starts > > if the statu

[Differential] [Accepted] D2257: [ksmserver] Use the new logout greeter binary to show the shutdown dialog

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > shutdown.cpp:187 > +} > +QProcess *p = new QProcess(this); > +p->setProgram(QStr

[Differential] [Requested Changes To] D2264: [ksmserver/greeter] Show one logout greeter on each screen

davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > shutdowndlg.cpp:182 > > -show(); > +connect(this, &QWindow::screenChanged, this, > +

[Differential] [Commented On] D2264: [ksmserver/greeter] Show one logout greeter on each screen

graesslin added a comment. > only one of the views gets mouse events. This behavior is reproducable with both X11 and Wayland. Adding my investigation results: - in qtwayland everything is correct, the enter event is processed correctly - it goes into QWindowSystemInterface::ha

[Differential] [Updated] D2257: [ksmserver] Use the new logout greeter binary to show the shutdown dialog

graesslin added a dependent revision: D2264: [ksmserver/greeter] Show one logout greeter on each screen. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2257 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graes

[Differential] [Updated] D2264: [ksmserver/greeter] Show one logout greeter on each screen

graesslin added dependencies: D2257: [ksmserver] Use the new logout greeter binary to show the shutdown dialog, D2252: [ksmserver] Create a dedicated binary from KSMShutdownDlg. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2264 EMAIL PREFERENCES

[Differential] [Updated] D2252: [ksmserver] Create a dedicated binary from KSMShutdownDlg

graesslin added a dependent revision: D2264: [ksmserver/greeter] Show one logout greeter on each screen. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2252 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graes

[Differential] [Request, 197 lines] D2264: [ksmserver/greeter] Show one logout greeter on each screen

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This follows the approach of kscreenlocker and ksplash: in multi-screen setups there is one dedicated g

[Differential] [Updated] D2258: Do not detect kde4 directory but assume it is the same location, this means people who install as non-root with kde-srcbuild can install it

jriddell added a reviewer: Plasma. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2258 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, dfaure, sebas, #plasma Cc: plasma-devel, jensreuterberg, abetts

[Differential] [Request, 15 lines] D2258: Do not detect kde4 directory but assume it is the same location, this means people who install as non-root with kde-srcbuild can install it

jriddell created this revision. jriddell added reviewers: dfaure, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Do not detect global kde4 directory TEST PLAN run make install REPOSITORY rPLASMAPA Plasma Audi

[Differential] [Commented On] D2218: New logic for screen numbers in plasmashell

mart added a comment. most comments should be adressed now, will need again a period of test with several multiscreen users, as it has changed a bit REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2218 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Updated, 897 lines] D2218: New logic for screen numbers in plasmashell

mart updated this revision to Diff 5425. mart added a comment. - fix merging screwup - be a bit smarter in searching for panel's screens REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2218?vs=5424&id=5425 BRANCH mart/screenConnecto

[Differential] [Updated, 900 lines] D2218: New logic for screen numbers in plasmashell

mart updated this revision to Diff 5424. mart added a comment. - get rid of m_views - don't write config to disk all the time - Merge branch 'master' into mart/screenConnectorManagement - move m_desktopViewforId in shellcorona REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE

[Differential] [Closed] D2251: Missing method for activity deletion from plasma script added

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE5d5f37798e9f: Missing method for activity deletion from plasma script added (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricato

[Differential] [Updated, 18 lines] D2251: Missing method for activity deletion from plasma script added

ivan updated this revision to Diff 5421. ivan added a comment. Just renamed a variable REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2251?vs=5402&id=5421 BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2251 AFFECT

[Differential] [Updated, 319 lines] D2257: [ksmserver] Use the new logout greeter binary to show the shutdown dialog

graesslin updated this revision to Diff 5418. graesslin added a comment. Remove including shutdowndlg.cpp in ksmserver and drop the existing test app REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2257?vs=5416&id=5418 BRANCH ksmserve

[Differential] [Accepted] D2251: Missing method for activity deletion from plasma script added

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2251 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: iv

[Differential] [Abandoned] D2255: add remove activity function in scripting

mart abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2255 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, ivan Cc: davidedmundson, plasma-devel, jensreuterberg, abetts, seb

[Differential] [Commented On] D2255: add remove activity function in scripting

mart added a comment. In https://phabricator.kde.org/D2255#41920, @davidedmundson wrote: > huh? looks like: https://phabricator.kde.org/D2251 ugh, bad coordination :p forget this one then ;) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kd

[Differential] [Accepted] D2251: Missing method for activity deletion from plasma script added

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2251 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, garg,

[Differential] [Updated] D2252: [ksmserver] Create a dedicated binary from KSMShutdownDlg

graesslin added a dependent revision: D2257: [ksmserver] Use the new logout greeter binary to show the shutdown dialog. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2252 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Updated] D2257: [ksmserver] Use the new logout greeter binary to show the shutdown dialog

graesslin added a dependency: D2252: [ksmserver] Create a dedicated binary from KSMShutdownDlg. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2257 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #pl

[Differential] [Request, 211 lines] D2257: [ksmserver] Use the new logout greeter binary to show the shutdown dialog

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ksmerver now starts the logout greeter binary instead of creating the KSMShutdownDlg. The complete inte

[Differential] [Updated, 269 lines] D2252: [ksmserver] Create a dedicated binary from KSMShutdownDlg

graesslin updated this revision to Diff 5415. graesslin added a comment. Small change in the test binary on when to read from the pipe REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2252?vs=5405&id=5415 BRANCH ksmserver-logout-greete

[Differential] [Commented On] D2218: New logic for screen numbers in plasmashell

mart added a comment. In https://phabricator.kde.org/D2218#41871, @davidedmundson wrote: > Personally, I think the part that's out of place is ScreenPool touching the desktop views; if you move m_desktopViewforId to shellCorona the design all fits: > insert/remove in ScreenPool become

[Differential] [Commented On] D2255: add remove activity function in scripting

davidedmundson added a comment. huh? looks like: https://phabricator.kde.org/D2251 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2255 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, ivan Cc:

[Differential] [Updated] D2255: add remove activity function in scripting

mart added reviewers: Plasma, ivan. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2255 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, ivan Cc: plasma-devel, jensreuterberg, abetts, sebas ___

[Differential] [Request, 22 lines] D2255: add remove activity function in scripting

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY removeActivity in the shell script engine, made synchronous as createActivity, needed by distributions REPOSITORY rPLASMAWORKSPACE Plasma Wor

[Differential] [Updated] D2044: WIP: [KSMServer] Load logout dialog after startup rather than on-demand

graesslin added a comment. alternative approach for the problem: https://phabricator.kde.org/D2252 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2044 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Accepted] D2248: [kcm] Show output name in output preview

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH sebas/362570 REVISION DETAIL https://phabricator.kde.org/D2248 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Request, 263 lines] D2252: [ksmserver] Create a dedicated binary from KSMShutdownDlg

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The idea behind this change is to have a dedicated binary for the logout dialog. As a follow up ksmserv

[Differential] [Commented On] D2218: New logic for screen numbers in plasmashell

davidedmundson added a comment. > i may be able to kill idsfordesktopview tough, will update the rr Yep, that's exactly what I meant. ++ Also means panels can use the API directly. (see comment #3) > perhaps would be more clear if the logic for that is completely moved in screenpoo