davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > shutdown.cpp:187 > + } > + QProcess *p = new QProcess(this); > + p->setProgram(QStringLiteral(LOGOUT_GREETER_BIN)); leaks (sort of). multiple logouts and cancels will result in lots of QProcess objects building up. add a deleteLater in the finished slot REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH ksmserver-logout-greeter-use-process REVISION DETAIL https://phabricator.kde.org/D2257 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
