Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2016-07-15 Thread Mindaugas Baranauskas
> On Nov. 22, 2015, 1:24 p.m., Alex Merry wrote: > > Ship It! > > Mindaugas Baranauskas wrote: > Seems that with this patch KDE Plasma crash more often: > https://bugs.kde.org/show_bug.cgi?id=357895#c22 > > David Edmundson wrote: > @Mindaugas > > Can you try this patch now th

Re: translucent moving windows

2016-07-15 Thread Ivan Čukić
Hi Rene, It is called Translucency, and works as it did in 4.x days. No clue whether it depends on your graphics system though. IIRC, the list now hides effects that are unsupported by your hardware / compositing mechanism. Cheers, Ivan ___ Plasma-deve

[Differential] [Request, 83 lines] D2187: ScriptEngine exports the list of activities known to Plasma

2016-07-15 Thread Ivan Čukić
ivan created this revision. ivan added reviewers: Plasma, mart, davidedmundson, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There is a small time-window when Plasma's internal data regarding activities is not

[Differential] [Accepted] D2186: Enable image rotation from exif data

2016-07-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2186 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

translucent moving windows

2016-07-15 Thread René J . V . Bertin
Hi, I was playing around with KWin5 (X11) instead of my usual KWin4 and realised I couldn't find the desktop effect that makes windows translucent while they're being moved. I find that a great mix between moving only outlines (what I usually prefer) and moving solid windows. If that effect is

[Differential] [Request, 10 lines] D2186: Enable image rotation from exif data

2016-07-15 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It was added commented out and no-one went back to enable it. BUG: 365707 REPOSITORY rK

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2016-07-15 Thread David Edmundson
> On Nov. 22, 2015, 1:24 p.m., Alex Merry wrote: > > Ship It! > > Mindaugas Baranauskas wrote: > Seems that with this patch KDE Plasma crash more often: > https://bugs.kde.org/show_bug.cgi?id=357895#c22 @Mindaugas Can you try this patch now that 1e196fdfb2a6eaf1664e1155c086616d55c6712b w

[Powerdevil] [Bug 364275] sleep and hibernate gone after update

2016-07-15 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364275 --- Comment #13 from dominikdanel...@gmail.com --- My problems have been solved by replacing kdm with sddm. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing l

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 265 - Still Unstable!

2016-07-15 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/265/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 15:13:47 + Build duration: 12 min CHANGE SET Revision b95d686e39d2c7507bd35f6cf5db81d173

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 264 - Still Unstable!

2016-07-15 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/264/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 14:55:36 + Build duration: 17 min CHANGE SET Revision adf79ab49011dc61d0be26b93841063666

[Differential] [Request, 60 lines] D2185: Handle restart of Compositor Scene correctly for Wayland client

2016-07-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This change ensures that KWin doesn't crash in the QPainter scene if

[Differential] [Commented On] D2156: improve output identification

2016-07-15 Thread Sebastian Kügler
sebas added a comment. @davidedmundson Good point, I'll revert that one and will give it another good round of testing. It'd be nice if you could test once you're back next week (same for @lbeltrame, of course.) REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D21

[Differential] [Commented On] D2156: improve output identification

2016-07-15 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. > With this patch > > - we detect the case when multiple identical outputs are connected (same hash) > - each of the duplicate outputs also gets matched against the output name OK, that makes sense. But I think then you need to revert the

[Differential] [Accepted] D2183: Add a geometry event to PlasmaWindow

2016-07-15 Thread hein (Eike Hein)
hein accepted this revision. hein added a reviewer: hein. hein added a comment. This revision is now accepted and ready to land. It's the API I need and I spot no bugs. REPOSITORY rKWAYLAND KWayland BRANCH plasma-window-geometry REVISION DETAIL https://phabricator.kde.org/D2183 EMAIL

[Differential] [Request, 125 lines] D2183: Add a geometry event to PlasmaWindow

2016-07-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY This allows the compositor to expose the absolute window geometry to processes wh

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 263 - Still Unstable!

2016-07-15 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/263/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 11:09:14 + Build duration: 12 min CHANGE SET Revision f4a1d740f1e4428f31fd13f66ec2a54bf4

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 41 - Still Failing!

2016-07-15 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 11:08:39 + Build duration: 51 sec CHANGE SET Revision f4a1d740f1e4428f31fd13f66

[Differential] [Closed] D2181: Convert all state checks to KWindowInfo::hasState().

2016-07-15 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEf4a1d740f1e4: Convert all state checks to KWindowInfo::hasState(). (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

Re: Review Request 128454: Kickoff query for CJK support

2016-07-15 Thread Eike Hein
> On July 15, 2016, 7:23 a.m., Eike Hein wrote: > > Being able to find ??/?? with just wy is cool, but I'm concerned about this > > being a sort of very narrow hack. It's only in a specific KRunner plugin, > > so it won't work in any other thing finding apps by name using lower-level > > APIs.

[Differential] [Accepted] D2181: Convert all state checks to KWindowInfo::hasState().

2016-07-15 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2181 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, g

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128457/ --- (Updated July 15, 2016, 10:56 a.m.) Status -- This change has been m

[Breeze] [Bug 365710] New: sddm really slow when using Breeze theme

2016-07-15 Thread Marco Napetti via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365710 Bug ID: 365710 Summary: sddm really slow when using Breeze theme Product: Breeze Version: 5.7.1 Platform: Gentoo Packages OS: Linux Status: UNCONFIRMED Severity:

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128457/#review97437 --- Ship it! Ship It! - Martin Gräßlin On July 15, 2016, 12

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128457/ --- (Updated July 15, 2016, 10:42 a.m.) Review request for Plasma, Bhushan Sh

Re: The situation of KWallet, and what to do about it?

2016-07-15 Thread Kevin Krammer
On Wednesday, 2016-07-13, 11:41:14, Thomas Pfeiffer wrote: > On 11.07.2016 22:29, Mark Gaiser wrote: > > As far as i can tell, QtKeyChain isn't a keychain at all, it's a wrapper > > around platform specific keychains that provides a unified interface for > > keychain functionality. It itself doesn

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128457/#review97436 --- src/plasmaquick/dialog.cpp (line 1084)

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128457/ --- (Updated July 15, 2016, 10:32 a.m.) Review request for Plasma, Bhushan Sh

[Differential] [Updated, 385 lines] D2111: User interface for adding launchers as global shortcuts

2016-07-15 Thread mart (Marco Martin)
mart updated this revision to Diff 5203. mart added a comment. - correctly register new components REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2111?vs=5167&id=5203 BRANCH mart/kserviceaction REVISION DETAIL https://phabricator.kde.

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128457/#review97435 --- src/plasmaquick/dialog.cpp (line 1072)

[Differential] [Request, 32 lines] D2181: Convert all state checks to KWindowInfo::hasState().

2016-07-15 Thread hein (Eike Hein)
hein created this revision. hein added reviewers: Plasma, graesslin. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY We've had bad experiences with state() in a plasma-framework testcase and this is more readable regardless. REPOSITORY

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128457/#review97434 --- src/plasmaquick/dialog.cpp (line 1072)

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128457/ --- (Updated July 15, 2016, 10:03 a.m.) Review request for Plasma, Bhushan Sh

Re: Review Request 128332: [Plasma-nm] Indicate flight mode in system tray icon

2016-07-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128332/#review97433 --- Has the icon been added already? - Kai Uwe Broulik On Juni

plasma-desktop containments desktop isFolder check

2016-07-15 Thread Leslie Zhai
Hi KDE developers, For better KDE and robust MultiScreen, here comes Heavy testcase for Plasma MultiScreen https://blog.martin-graesslin.com/blog/2016/07/multi-screen-woes-in-plasma-5-7/#comment-71362 There is a tiny issue - Primary screen randomly switch to DesktopView, extended is not Desk

[Differential] [Commented On] D2156: improve output identification

2016-07-15 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > sebas wrote in outputgrid_2x3.json:129 > What's the issue? the "No newline at end of file". Just add a new line. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://phabricator.kde.org

Re: Review Request 128454: Kickoff query for CJK support

2016-07-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128454/#review97432 --- Thanks. I can't really comment on this. runners/services/se

[Differential] [Commented On] D2156: improve output identification

2016-07-15 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > graesslin wrote in outputgrid_2x3.json:129 > nitpick What's the issue? REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas,

Re: Review Request 128454: Kickoff query for CJK support

2016-07-15 Thread Leslie Zhai
> On 七月 15, 2016, 7:23 a.m., Eike Hein wrote: > > Being able to find ??/?? with just wy is cool, but I'm concerned about this > > being a sort of very narrow hack. It's only in a specific KRunner plugin, > > so it won't work in any other thing finding apps by name using lower-level > > APIs. A

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 195 - Fixed!

2016-07-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/195/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 08:38:16 + Build duration: 14 min CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 195 - Fixed!

2016-07-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/195/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 08:38:16 + Build duration: 14 min CHANGE SET No changes JUNIT RESULTS Name: (roo

Re: The situation of KWallet, and what to do about it?

2016-07-15 Thread Martin Graesslin
On Friday, July 15, 2016 10:22:32 AM CEST Elvis Angelaccio wrote: > 2016-07-14 1:11 GMT+02:00 Albert Astals Cid : > > El dijous, 7 de juliol de 2016, a les 18:43:57 CEST, Elvis Angelaccio va > > > > escriure: > >> Hi, > >> thanks for raising this topic! > >> > >> 2016-07-07 12:36 GMT+02:00 Thomas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 262 - Still Unstable!

2016-07-15 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/262/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 08:11:33 + Build duration: 17 min CHANGE SET Revision 4275d8eb4b097c789577e8c089d0e90029

Re: The situation of KWallet, and what to do about it?

2016-07-15 Thread Elvis Angelaccio
2016-07-14 1:11 GMT+02:00 Albert Astals Cid : > El dijous, 7 de juliol de 2016, a les 18:43:57 CEST, Elvis Angelaccio va > escriure: >> Hi, >> thanks for raising this topic! >> >> 2016-07-07 12:36 GMT+02:00 Thomas Pfeiffer : >> > Hi everyone, >> > I'm addressing both the Plasma team and kde-devel b

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Eike Hein
> On July 15, 2016, 7:42 a.m., David Rosca wrote: > > Does it work with Qt < 5.6.1 now? > > Martin Gräßlin wrote: > That would be before your change? I guess no. Btw. I read your code > through today in an extremely detailed manner and I'm 100 % sure, that it's > absolutely correct. Good w

[Differential] [Closed] D2176: Removing the Activity wrapper class from the Shell

2016-07-15 Thread Ivan Čukić
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE4275d8eb4b09: Removing the Activity wrapper class from the Shell (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread David Rosca
> On July 15, 2016, 7:42 a.m., David Rosca wrote: > > Does it work with Qt < 5.6.1 now? > > Martin Gräßlin wrote: > That would be before your change? I guess no. Btw. I read your code > through today in an extremely detailed manner and I'm 100 % sure, that it's > absolutely correct. Good w

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128457/#review97428 --- +1 tough before +2 as Martin says, test would be nice - Marc

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread David Rosca
> On July 15, 2016, 7:42 a.m., David Rosca wrote: > > Does it work with Qt < 5.6.1 now? > > Martin Gräßlin wrote: > That would be before your change? I guess no. Btw. I read your code > through today in an extremely detailed manner and I'm 100 % sure, that it's > absolutely correct. Good w

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Eike Hein
> On July 15, 2016, 7:42 a.m., Martin Gräßlin wrote: > > given the pain we had with that just now: > > please add a test case which performs the following actions: > > > > 1) creates a window > > 2) shows it > > 4) verifies with KWindowSystem that the state is correct > > 5) hides it > > 6) veri

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Eike Hein
> On July 15, 2016, 7:42 a.m., David Rosca wrote: > > Does it work with Qt < 5.6.1 now? > > Martin Gräßlin wrote: > That would be before your change? I guess no. Btw. I read your code > through today in an extremely detailed manner and I'm 100 % sure, that it's > absolutely correct. Good w

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Martin Gräßlin
> On July 15, 2016, 9:42 a.m., David Rosca wrote: > > Does it work with Qt < 5.6.1 now? That would be before your change? I guess no. Btw. I read your code through today in an extremely detailed manner and I'm 100 % sure, that it's absolutely correct. Good work! - Martin --

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128457/#review97421 --- Does it work with Qt < 5.6.1 now? - David Rosca On July 15

Re: Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128457/#review97420 --- given the pain we had with that just now: please add a test c

Review Request 128457: Fix the infamous 'dialogs show up on the Task Manager' bug once more.

2016-07-15 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128457/ --- Review request for Plasma, David Edmundson, David Rosca, Martin Gräßlin, an

Re: Review Request 128454: Kickoff query for CJK support

2016-07-15 Thread Eike Hein
> On July 15, 2016, 7:23 a.m., Eike Hein wrote: > > Being able to find ??/?? with just wy is cool, but I'm concerned about this > > being a sort of very narrow hack. It's only in a specific KRunner plugin, > > so it won't work in any other thing finding apps by name using lower-level > > APIs.

Re: Review Request 128454: Kickoff query for CJK support

2016-07-15 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128454/#review97418 --- Being able to find ??/?? with just wy is cool, but I'm concer

Review Request 128454: Kickoff query for CJK support

2016-07-15 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128454/ --- Review request for Plasma and Xuetian Weng. Repository: plasma-workspace