----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128454/#review97418 -----------------------------------------------------------
Being able to find ??/?? with just wy is cool, but I'm concerned about this being a sort of very narrow hack. It's only in a specific KRunner plugin, so it won't work in any other thing finding apps by name using lower-level APIs. And it only works for Chinese. Littering high-level frontend code with language-specific stuff seems wrong. Is there a more central place we could put this, and maybe a more extensible way to do it? Like, a framework like Ki18n could have a matchInput(haystack, needle) that can do this sort of language-specific expansion/transform for haystack to match needle. - Eike Hein On July 15, 2016, 7:03 a.m., Leslie Zhai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128454/ > ----------------------------------------------------------- > > (Updated July 15, 2016, 7:03 a.m.) > > > Review request for Plasma and Xuetian Weng. > > > Repository: plasma-workspace > > > Description > ------- > > Not like English, each word is seperated by a blank, for example, Hello > World, but in Chinese, ????, it needs to segment Chinese words. > > And Kickoff once supported querying for CJK based on Chinese words > segmentation algroithm, but about last year after KF5, the feature was > dropped, so I added an OPTIONAL requirement for KJieba - libcppjieba Chinese > word segmentation DBus service. > > It is able to input Chinese pinyin or even the first letters to query > Application shown as https://pbs.twimg.com/media/CXSKY6YVAAAvGk8.png > https://pbs.twimg.com/media/CXSKY-UUoAADWEs.png > > > Diffs > ----- > > CMakeLists.txt 74e1518 > runners/services/CMakeLists.txt 7e33a3e > runners/services/servicerunner.h 8d9ad1a > runners/services/servicerunner.cpp aa9d2bd > > Diff: https://git.reviewboard.kde.org/r/128454/diff/ > > > Testing > ------- > > > Thanks, > > Leslie Zhai > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
