Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 261 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/261/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 05:53:32 + Build duration: 13 min CHANGE SET Revision 15af96200fac03b8ee178540ab21f983e3

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 194 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/194/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 15 Jul 2016 05:55:22 + Build duration: 3 min 39 sec CHANGE SET Revision 461b9a1c7c4cd2ae81f440dc142f50e

[Differential] [Closed] D2170: Port ActivityPager applet away from LibLegacyTaskManager API.

This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS650b4352c202: Port ActivityPager applet away from LibLegacyTaskManager API. (authored by hein). REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.k

[Differential] [Closed] D2169: Port Pager applet away from LibLegacyTaskManager API.

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP461b9a1c7c4c: Port Pager applet away from LibLegacyTaskManager API. (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D216

[Differential] [Closed] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

This revision was automatically updated to reflect the committed changes. hein marked an inline comment as done. Closed by commit rPLASMAWORKSPACE15af96200fac: Move code to extract legacy window ids from (drop) MIME data into libtm-ng. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Work

[Differential] [Closed] D2171: Drop liblegacytaskmanager and the tasks data engine.

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE49213f778186: Drop liblegacytaskmanager and the tasks data engine. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Differential] [Commented On] D2156: improve output identification

graesslin added a comment. Looks good to me INLINE COMMENTS > outputgrid_2x3.json:129 > +] > \ No newline at end of file nitpick REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Commented On] D2156: improve output identification

lbeltrame added a comment. For now I didnt notice any problems (with version 1 of the patch), at least no regressions (notice that I wasn't able to reproduce the issue described in the bug since a long time). Is there any difference worth testing in the new revision? REPOSITORY rKSCRE

[Differential] [Commented On] D2156: improve output identification

sebas added a comment. @lbeltrame Does it work for you? If you can try this patch, that'd be awesome (also if it already works for you, to check if the patch breaks anything). REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://

[Differential] [Commented On] D2156: improve output identification

sebas added a comment. @davidedmundson Sure. With this patch - we detect the case when multiple identical outputs are connected (same hash) - each of the duplicate outputs also gets matched against the output name The problem I'm fixing is that currently (without my patch) the

[Differential] [Updated, 269 lines] D2156: improve output identification

sebas updated this revision to Diff 5194. sebas added a comment. fix checks and add autotests - autotest for videowall bug - improve and fix checks - randomize order in autotest REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2156?vs=5140&id=519

Re: Review Request 128431: Fix race condition when new applications open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128431/#review97412 --- Ship it! Ship It! - David Edmundson On July 12, 2016, 9

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

mart added a comment. code seems ok, seems some pixel measures here and there, that i guess are ok. can you add a screenshot as well? INLINE COMMENTS > CategorizedView.cpp:30 > setWordWrap( true ); > +setViewportMargins(20,0,20,0); > +QPalette pal(palette()); does this give pr

[Differential] [Accepted] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > hein wrote in xwindowtasksmodel.h:211 > No, because this is X11-specific code that is never run on Wayland and not > built if X11 is not availa

[Differential] [Accepted] D2171: Drop liblegacytaskmanager and the tasks data engine.

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. finally \o/ REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2171 EMAIL PREFERENCES https://phabric

[Differential] [Accepted] D2177: Actually connect the filter bar in holidays plugin

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2177 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D2176: Removing the Activity wrapper class from the Shell

davidedmundson accepted this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2176 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, mart, bshah, davidedmundson, #plasma Cc: plasma-d

[Differential] [Accepted] D2176: Removing the Activity wrapper class from the Shell

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2176 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan,

[Differential] [Request, 10 lines] D2177: Actually connect the filter bar in holidays plugin

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 365621 REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL

[Differential] [Request, 380 lines] D2176: Removing the Activity wrapper class from the Shell

ivan created this revision. ivan added reviewers: Plasma, mart, davidedmundson, bshah. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY After the previous patch which removed the unused Activity class related events, it s

[Breeze] [Bug 365690] New: kaccessibleapp icon

https://bugs.kde.org/show_bug.cgi?id=365690 Bug ID: 365690 Summary: kaccessibleapp icon Product: Breeze Version: 5.6.5 Platform: Debian testing OS: Linux Status: UNCONFIRMED Severity: normal Prio

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 260 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/260/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 14 Jul 2016 17:31:35 + Build duration: 15 min CHANGE SET Revision ada43d447ccf51844bf6c2a99023d69d26

[Differential] [Closed] D2174: Removing dead code - activity-event-handling private slots

This revision was automatically updated to reflect the committed changes. ivan marked an inline comment as done. Closed by commit rPLASMAWORKSPACEada43d447ccf: Removing dead code - activity-event-handling private slots (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SI

[Breeze] [Bug 364849] Tooltip Text in several qt apps such as Amarok and Krusader is unreadable (white on white) with the Breeze/Breeze Dark color schemes

https://bugs.kde.org/show_bug.cgi?id=364849 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pereira.da.costa@gmail

[Breeze] [Bug 365318] KRDC is unreadable under breeze dark theme

https://bugs.kde.org/show_bug.cgi?id=365318 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pereira.da.costa@gmail

Re: [kde-community] Usage of QNetworkAccessManager

On quinta-feira, 14 de julho de 2016 18:33:37 PDT Ben Cooksley wrote: > Hi all, > > Just my regular reminder regarding usage of QNetworkAccessManager in > your applications and libraries, especially when it comes to > interacting with kde.org infrastructure. > > Unfortunately, from it's first ite

[Differential] [Commented On] D2164: Allow struts on panels between screen edges if WM is KWin

luebking added a comment. In https://phabricator.kde.org/D2164#40170, @graesslin wrote: > - fixed logic error with platform check See? ;-) Looks good otherwise. INLINE COMMENTS > panelview.cpp:926 > > -//Extended struts against a screen edge near to another screen

[Differential] [Accepted] D2174: Removing dead code - activity-event-handling private slots

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2174 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, #plasma, s

[Differential] [Updated] D2174: Removing dead code - activity-event-handling private slots

ivan marked an inline comment as done. ivan added inline comments. INLINE COMMENTS > davidedmundson wrote in shellcorona.cpp:1588 > we use this one > > you've even updated the line that's using it in this very patch. It is using activityRemoved(QString), not activityRemoved(), It would not com

[Differential] [Commented On] D2174: Removing dead code - activity-event-handling private slots

davidedmundson added inline comments. INLINE COMMENTS > shellcorona.cpp:1588 > - > -void ShellCorona::activityRemoved() > -{ we use this one you've even updated the line that's using it in this very patch. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kd

[Differential] [Updated] D2174: Removing dead code - activity-event-handling private slots

ivan updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2174 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, #plasma, mart, sebas, davidedmundson Cc: plasma-devel, jensre

[Differential] [Request, 37 lines] D2174: Removing dead code - activity-event-handling private slots

ivan created this revision. ivan added reviewers: Plasma, mart, sebas, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY A few private slots handling the events of Activity objects have been lingering

[Differential] [Updated] D2156: improve output identification

davidedmundson added a comment. I have identical screens so can test when I'm back (Tuesday) if you give me some specific thing to test. Mine's mostly been working since I did https://phabricator.kde.org/rKSCREENb8b2126dbfb1d0cf5c771baf23a29e1130a70fba in kscreen which also makes sure w

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 259 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/259/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 14 Jul 2016 15:02:48 + Build duration: 12 min CHANGE SET Revision 95e3c59606b3b6b9b0ac458a5c372cc24e

[Differential] [Updated] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

hein marked an inline comment as done. hein added inline comments. INLINE COMMENTS > mart wrote in xwindowtasksmodel.h:211 > would this cause problems in wayland? No, because this is X11-specific code that is never run on Wayland and not built if X11 is not available at build time. Now, we don

[Differential] [Accepted] D2169: Port Pager applet away from LibLegacyTaskManager API.

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2169 EMAIL PREFERENCES https://phabricator.kde.org

[Differential] [Request, 380 lines] D2173: WIP: New System Settings delegate design

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Based on VDG design Icon mode lists all submodules which can be accessed directly This r

[Differential] [Reopened] D2111: User interface for adding launchers as global shortcuts

mart reopened this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2111 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, graesslin Cc: plasma-devel, jensreuterberg, abetts, sebas __

[Differential] [Commented On] D2164: Allow struts on panels between screen edges if WM is KWin

mart added a comment. fine with me. we are not "officially" supporting other window managers for libplasma anyways REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2164 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Updated, 111 lines] D2164: Allow struts on panels between screen edges if WM is KWin

graesslin updated this revision to Diff 5170. graesslin added a comment. - fixed logic error with platform check - changed name to canSetStrut to prevent negation in method name - qstricmp - move the setExtendedStrut call with no strut into PanelView::updateStruts REPOSITORY rPLASMAWOR

[Differential] [Accepted] D2170: Port ActivityPager applet away from LibLegacyTaskManager API.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D2170 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Changed Subscribers] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

mart added inline comments. INLINE COMMENTS > xwindowtasksmodel.h:211 > + */ > +static WId winIdFromMimeData(const QMimeData *mimeData, bool *ok = 0); > + would this cause problems in wayland? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/

[Differential] [Updated, 332 lines] D2111: User interface for adding launchers as global shortcuts

mart updated this revision to Diff 5167. mart added a comment. - new layout, without combobox - categorize launchers and other shortcuts REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2111?vs=5161&id=5167 BRANCH mart/kserviceaction RE

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

> On Čec. 14, 2016, 7:58 dop., Eike Hein wrote: > > It seems to work fairly well, but the editor margins are not symmetric on > > the left and right with respect to the item delegate frame: > > > >  > > Painless Roaster wrote: > It is OK. The ve

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 193 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/193/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 14 Jul 2016 13:55:05 + Build duration: 14 min CHANGE SET Revision 49eec39d11e7f689a763e837bc82869bb08db

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 193 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/193/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 14 Jul 2016 13:55:05 + Build duration: 14 min CHANGE SET Revision 49eec39d11e7f689a763e837bc82869bb08db

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 258 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/258/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 14 Jul 2016 13:36:00 + Build duration: 22 min CHANGE SET Revision 6f31fafd167e3b54f8bee05841205f9c15

[Differential] [Updated] D2169: Port Pager applet away from LibLegacyTaskManager API.

hein added a dependent revision: D2171: Drop liblegacytaskmanager and the tasks data engine.. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2169 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma Cc: pl

[Differential] [Request, 12,882 lines] D2171: Drop liblegacytaskmanager and the tasks data engine.

hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. hein added dependencies: D2170: Port ActivityPager applet away from LibLegacyTaskManager API., D2169: Port Pager applet away from LibLegacyTaskManager API.. Restricted Application added a project: Pl

[Differential] [Updated] D2170: Port ActivityPager applet away from LibLegacyTaskManager API.

hein added a dependent revision: D2171: Drop liblegacytaskmanager and the tasks data engine.. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D2170 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma Cc: p

[Differential] [Updated] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

hein added a dependent revision: D2170: Port ActivityPager applet away from LibLegacyTaskManager API.. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2168 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #

[Differential] [Request, 22 lines] D2170: Port ActivityPager applet away from LibLegacyTaskManager API.

hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. hein added a dependency: D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.. Restricted Application added a project: Plasma. REVISION SUMMARY Depends on https://phab

[Differential] [Commented On] D2164: Allow struts on panels between screen edges if WM is KWin

luebking added inline comments. INLINE COMMENTS > graesslin wrote in panelview.cpp:857 > > also, how does this react when the WM is replaced? > > tricky. I think it's a corner case which could be ignored. We don't really > have a way to detect it. I would say only "experienced" users know how t

[Differential] [Updated] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

hein added a dependent revision: D2169: Port Pager applet away from LibLegacyTaskManager API.. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2168 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma C

[Differential] [Request, 24 lines] D2169: Port Pager applet away from LibLegacyTaskManager API.

hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. hein added a dependency: D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.. Restricted Application added a project: Plasma. REVISION SUMMARY Depends on https://phab

[Differential] [Request, 111 lines] D2168: Move code to extract legacy window ids from (drop) MIME data into libtm-ng.

hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY This is remaining (still) useful code from liblegacytaskmanager. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master RE

[Differential] [Closed] D2165: Port Switch Window containment action to libtaskmanager-ng.

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6f31fafd167e: Port Switch Window containment action to libtaskmanager-ng. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.

[Differential] [Accepted] D2165: Port Switch Window containment action to libtaskmanager-ng.

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2165 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Commented On] D2164: Allow struts on panels between screen edges if WM is KWin

graesslin added inline comments. INLINE COMMENTS > luebking wrote in panelview.cpp:857 > qstricmp? > also, how does this react when the WM is replaced? > also, how does this react when the WM is replaced? tricky. I think it's a corner case which could be ignored. We don't really have a way to

[Differential] [Closed] D2111: User interface for adding launchers as global shortcuts

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPba021bc947d8: a dialog to add applications (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2111?vs=5005&id=5161#toc REPOSITORY rPLASMADESKTOP Plasma Desktop CHAN

Re: Review Request 128445: add a subsection for removable devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128445/ --- (Updated July 14, 2016, 1:03 p.m.) Review request for Plasma and Thomas P

[Differential] [Changed Subscribers] D2164: Allow struts on panels between screen edges if WM is KWin

luebking added inline comments. INLINE COMMENTS > panelview.cpp:848 > > +bool PanelView::shouldNotSetStrut() const > +{ API sanity: "if (!shouldNotSetStrut())" ... double negations make people dizzy ;-) > panelview.cpp:857 > +NETRootInfo rootInfo(QX11Info::connection(), NET::Supported |

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 192 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/192/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 14 Jul 2016 12:45:51 + Build duration: 3 min 8 sec CHANGE SET Revision d444c0dc8347f89259cafce5fccbf467

Re: Review Request 128434: rename some kcm desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128434/ --- (Updated July 14, 2016, 12:45 p.m.) Status -- This change has been m

Re: Review Request 128446: KCM move removable devices and device actions into subsection removable-device

> On July 14, 2016, 10:52 a.m., Thomas Pfeiffer wrote: > > Yes, makes sense! Strike that. Please change the name to "Removable Storage Media" (or "Removable Storage" if the first one is too long), because printers, most input devices and external monitors are "removable" just the same. - Tho

Re: Review Request 128445: add a subsection for removable devices

> On July 14, 2016, 12:33 p.m., Thomas Pfeiffer wrote: > > I just realized that we should rename the sub-group to "Removable Storage" > > (or "Removable Storage Media" if that isn't too long) and just treat > > cameras as storage media (because that's basically what they act like when > > conn

Re: Review Request 128434: rename some kcm desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128434/#review97399 --- Ship it! Thanks for the patience, looking good now! - Seb

Re: Review Request 128445: add a subsection for removable devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128445/#review97396 --- I just realized that we should rename the sub-group to "Remov

Re: Review Request 128434: rename some kcm desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128434/ --- (Updated July 14, 2016, 12:25 p.m.) Review request for Plasma. Changes

[Differential] [Commented On] D2160: [System Tray] Round item size to icon size

hein added a comment. Tray icons still larger than conventional panel icons, here comparing Volume Control in tray vs. standalone widget: F179972: Screenshot_20160714_210106.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https:

[Differential] [Closed] D2159: [src/server] Verify that surface has a resource before sending pointer enter

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND92036ba9169d: [src/server] Verify that surface has a resource before sending pointer enter (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.

Re: [RFC] WindowMetadata framework fundamentals

On Thursday, July 14, 2016 6:46:36 PM CEST Eike Hein wrote: > > looking at the code i see it's still based on window ids, any idea how to > > solve that/how to identify windows? [...] > That means no more global ids - the object name itself becomes the > handle. Right. Will need a bit more code,

Re: [RFC] WindowMetadata framework fundamentals

On Thursday, July 14, 2016 1:52:26 PM CEST Sebastian Kügler wrote: > On Thursday, July 14, 2016 1:41:54 PM CEST Martin Graesslin wrote: > > > > - currently open document > > > > > > Don't most applications expose that in their window title, anyway? > > > > Some do, some don't. Some put it at the

Re: [RFC] WindowMetadata framework fundamentals

On Wednesday, July 13, 2016 5:10:25 PM CEST Thomas Pfeiffer wrote: > The caveat that writing text into the thumbnail is problematic is a pretty > big problem > from my perspective. For example in a text editor, I don't see how relevant > information > can be represented by a "pretty picture". I'd

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 257 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/257/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 14 Jul 2016 11:38:57 + Build duration: 17 min CHANGE SET Revision 2e40cf776db230a9d68cbe3577aa9d5afc

Re: Review Request 128434: rename some kcm desktop files

> On July 14, 2016, 11:41 a.m., Sebastian Kügler wrote: > > Looks good to me. > > > > Have you checked if any documentation needs updating? (I.e. are any of the > > names referred to in docbooks?) > > Andreas Kainz wrote: > where are the docbooks? under doc/* in the same repository. Just

[Differential] [Accepted] D2160: [System Tray] Round item size to icon size

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. would have to be only for 5.7 branch tough REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2160 EMAIL PREFERENCES h

[Differential] [Accepted] D2159: [src/server] Verify that surface has a resource before sending pointer enter

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH server-check-surface-resource-on-enter REVISION DETAIL https://phabricator.kde.org/D2159 EMAIL PREFERENCES https://phabricator.kde.org/setti

[Differential] [Closed] D2149: [platforms/fbdev] Handle error conditions more gracefully

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINf0aeda073835: [platforms/fbdev] Handle error conditions more gracefully (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2149?vs=5114&id=5156

Re: [RFC] WindowMetadata framework fundamentals

On Thursday, July 14, 2016 1:41:54 PM CEST Martin Graesslin wrote: > > > - currently open document > > > > Don't most applications expose that in their window title, anyway? > > Some do, some don't. Some put it at the start of their title, some at the > end. Some add some character that the data

Re: Review Request 128434: rename some kcm desktop files

> On Juli 14, 2016, 11:41 vorm., Sebastian Kügler wrote: > > Looks good to me. > > > > Have you checked if any documentation needs updating? (I.e. are any of the > > names referred to in docbooks?) where are the docbooks? - Andreas --

[Differential] [Request, 37 lines] D2165: Port Switch Window containment action to libtaskmanager-ng.

hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Unfortunately this alone won't make it work on Wayland, as it's still based around storing X11 window ids in QActions. For it

[Differential] [Commented On] D2156: improve output identification

graesslin added a comment. asking the evil question ;-) Can we autotest this? REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: graesslin, lbeltrame, plasm

Re: [RFC] WindowMetadata framework fundamentals

On Wednesday, July 13, 2016 5:10:25 PM CEST Thomas Pfeiffer wrote: > Hi sebas, > > On 13.07.2016 02:18, Sebastian Kügler wrote: > > During the Plasma sprint in March, we've been fleshing out plans to create > > a mechanisms for apps to be represented by the shell. > > > > The goals it to achieve

Re: Review Request 128434: rename some kcm desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128434/#review97392 --- Looks good to me. Have you checked if any documentation need

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 256 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/256/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 14 Jul 2016 11:19:01 + Build duration: 16 min CHANGE SET Revision 7f060403a2d44fc76b2b14fc9ebf43ee27

[Differential] [Closed] D2162: Memory-optimizing Activity object not to keep duplicate data

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE2e40cf776db2: Memory-optimizing Activity object not to keep duplicate data (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

[Differential] [Accepted] D2162: Memory-optimizing Activity object not to keep duplicate data

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2162 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, davidedmun

[Differential] [Updated, 145 lines] D2162: Memory-optimizing Activity object not to keep duplicate data

ivan updated this revision to Diff 5153. ivan added a comment. Removing the mutex since Activity objects should reside in the same thread REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2162?vs=5151&id=5153 BRANCH master REVISION DET

[Differential] [Updated] D2164: Allow struts on panels between screen edges if WM is KWin

graesslin updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2164 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma Cc: plasma-devel, jensreuterberg, abetts, s

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 255 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/255/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 14 Jul 2016 11:04:15 + Build duration: 13 min CHANGE SET Revision 56ea0f5947ac3ef285acca2981324c9afb

[Differential] [Request, 106 lines] D2164: Allow struts on panels between screen edges if WM is KWin

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KWin starting with 5.7 supports struts on panels between screen edges. Thus we can start setting struts

[Differential] [Updated, 144 lines] D2162: Memory-optimizing Activity object not to keep duplicate data

ivan updated this revision to Diff 5151. ivan added a comment. Added (C) info REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2162?vs=5149&id=5151 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2162 AFFECTED FILES sh

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 40 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 14 Jul 2016 11:03:45 + Build duration: 58 sec CHANGE SET Revision 56ea0f5947ac3ef285acca298

Re: Review Request 128400: Configuration option for System Tray's icon size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128400/ --- (Updated July 14, 2016, 11:04 a.m.) Status -- This change has been m

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 14, 2016, 10:33 a.m., Viorel-Cătălin Răpițeanu wrote: > > Is there any status update on this commit? Should it be integrated? > > John Salatas wrote: > I'm done with it. Hopefully someone will commit to git as I don't have > commit rights in order to do it myself. i an commit it,

[Differential] [Request, 142 lines] D2162: Memory-optimizing Activity object not to keep duplicate data

ivan created this revision. ivan added reviewers: mart, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Activity object kept all the data that KActivities::Info keeps, and an instance of KActivities:

Re: Review Request 128446: KCM move removable devices and device actions into subsection removable-device

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128446/#review97387 --- Yes, makes sense! - Thomas Pfeiffer On July 14, 2016, 10:3

Re: Review Request 128400: Configuration option for System Tray's icon size

> On July 14, 2016, 10:33 a.m., Viorel-Cătălin Răpițeanu wrote: > > Is there any status update on this commit? Should it be integrated? I'm done with it. Hopefully someone will commit to git as I don't have commit rights in order to do it myself. - John -

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

> On July 10, 2016, 8:49 p.m., Thomas Pfeiffer wrote: > > Nice feature, but the UI unnecessarily mixes two different interaction > > patterns: Checkboxes and drag&drop. > > What I'd prefer to do (and we should introduce that as a general paradigm > > for such things): Put a box "Hidden tabs" be

  1   2   >