luebking added inline comments.
INLINE COMMENTS
> panelview.cpp:848
>
> +bool PanelView::shouldNotSetStrut() const
> +{
API sanity:
"if (!shouldNotSetStrut())" ...
double negations make people dizzy ;-)
> panelview.cpp:857
> + NETRootInfo rootInfo(QX11Info::connection(), NET::Supported |
> NET::SupportingWMCheck);
> + if (qstrcmp(rootInfo.wmName(), "KWin") == 0) {
> + // KWin since 5.7 can handle this fine, so only exclude for other
> window managers
qstricmp?
also, how does this react when the WM is replaced?
> panelview.cpp:863
> + const QRect thisScreen = screen()->geometry();
> + const int numScreens = corona()->numScreens();
> + for (int i = 0; i < numScreens; ++i) {
if (numScreens < 2) return false; (ie. true for the switched API - already
confused?)
> panelview.cpp:878
> + if (otherScreen.bottom() <= thisScreen.top()) {
> + KWindowSystem::setExtendedStrut(winId(), 0, 0, 0, 0, 0, 0,
> 0, 0, 0, 0, 0, 0);
> + return true;
the query has a side effect - the strut update should be in the calling branch,
yesno?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2164
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #plasma
Cc: luebking, plasma-devel, jensreuterberg, abetts, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
