Re: Review Request 128362: Add unclutter/cascade window actions

2016-07-05 Thread Martin Gräßlin
> On July 5, 2016, 4:32 p.m., Martin Gräßlin wrote: > > I do not understand why this review was discarded. Care to elaborate? > > Eike Hein wrote: > Based on IRC discussion neither you or I are are available to write the > favored implementation so I decided to abandon the proposed code. B

[Differential] [Commented On] D1231: Add Remote Access interface to KWayland

2016-07-05 Thread Martin Gräßlin
graesslin added a comment. I had been thinking about multi-screen issue and how we can get it working in the protocol. The biggest problem is that we cannot really map to the wl_output in a way that it's useful to the client. Also caused by QtWayland not exposing the wl_output in the native

[Differential] [Commented On] D2092: Fix icon loading in Widget Explorer

2016-07-05 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. I know, I copied the "is this icon valid" from there. I chose not to use it, partly because we don't have 5.7 and partly because it means you prematurely create the fallback qicon which is slightly additional overhead. I think related to this change t

[Differential] [Commented On] D2092: Fix icon loading in Widget Explorer

2016-07-05 Thread broulik (Kai Uwe Broulik)
broulik added a comment. New in 5.7: https://code.qt.io/cgit/qt/qtbase.git/commit/?id=d3a21a18de73b70d0f20a36ae36439eac1f17ce4 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2092 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/em

Re: Review Request 128374: solid kcm small change of the entire ux file

2016-07-05 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128374/ --- (Updated Juli 5, 2016, 7:03 nachm.) Status -- This change has been m

Re: Review Request 128375: kcm color preview on top and buttons on bottom.

2016-07-05 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128375/ --- (Updated July 5, 2016, 7 p.m.) Status -- This change has been marked

Re: Review Request 128373: re-arrange of the emoticon kcm buttons

2016-07-05 Thread Andreas Kainz
> On Juli 5, 2016, 9:05 vorm., Marco Martin wrote: > > doesn't that many buttons in an horizontal layout risk to either five the > > window a too big minimum horizontal size (or alternatively all buttons with > > elided text that's not good either?) good question in a second step I'd like to r

[Differential] [Request, 5 lines] D2092: Fix icon loading in Widget Explorer

2016-07-05 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In new Qt (not sure which version) QIcon::fromTheme(QString) returns a valid icon object, thus hasThemeIcon always returns true as tha

[Breeze] [Bug 365103] "Icons Tint to Match Highlight" makes icons invisible when "draw a thin line to indicate focus" is activated

2016-07-05 Thread Marco Martin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365103 Marco Martin changed: What|Removed |Added Latest Commit||http://commits.kde.org/bree |

Re: Review Request 128362: Add unclutter/cascade window actions

2016-07-05 Thread Eike Hein
> On July 5, 2016, 2:32 p.m., Martin Gräßlin wrote: > > I do not understand why this review was discarded. Care to elaborate? Based on IRC discussion neither you or I are are available to write the favored implementation so I decided to abandon the proposed code. - Eike

5.8 draft schedule

2016-07-05 Thread Jonathan Riddell
I've made a draft schedule for Plasma 5.8, comments welcome. It sticks to the same formula as the last couple of releases, Beta just after the .5 bugfix release, putting repo freeze two weeks before (which is 1 week after akademy). Then final .0 is 18th October and bugfix releases 1,1, 2,3&5 week

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

2016-07-05 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > kwinqml.cpp:47-49 > +if (!m_socketName.isNull() && !m_socketName.isEmpty()) { > +m_display->setSocketName(m_socketName); > +} actually we don't need that. The socketName is for the kwin process which we start. Our Display in thi

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

2016-07-05 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > config-kwin.h.cmake:6 > #define KWIN_INTERNAL_NAME_X11 "${KWIN_INTERNAL_NAME_X11}" > +#define KWIN_INTERNAL_NAME_WAYLAND "${KWIN_INTERNAL_NAME_WAYLAND}" > #define KWIN_CONFIG "${KWIN_NAME}rc" best generate the absolute install path of the bina

Re: Review Request 128362: Add unclutter/cascade window actions

2016-07-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128362/#review97125 --- I do not understand why this review was discarded. Care to el

Plasma 5.8 Kickoff Meeting

2016-07-05 Thread Jonathan Riddell
Time for a meeting to review the release schedule and todo items for Plasma 5.8 Please tick the days and times you can make it and we'll pick a meeting time http://doodle.com/poll/w44vkv6euyd73cde Remember to set timezone to your local one first Jonathan

[Differential] [Updated, 520 lines] D2089: Rewrite Window List plasmoid.

2016-07-05 Thread hein (Eike Hein)
hein updated this revision to Diff 4962. hein added a comment. Drop the Unclutter/Cascade buttons. Moving the existing code implementing those actions from the tasks data engine to kdeclarative didn't get through review and this is the most I have time for. REPOSITORY rPLASMADESKTOP

Re: Review Request 128362: Add unclutter/cascade window actions

2016-07-05 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128362/ --- (Updated July 5, 2016, 2:13 p.m.) Status -- This change has been dis

Re: Review Request 128362: Add unclutter/cascade window actions

2016-07-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128362/#review97124 --- as we have a dbus xml description for KWin, I suggest to copy

[Breeze] [Bug 365103] "Icons Tint to Match Highlight" makes icons invisible when "draw a thin line to indicate focus" is activated

2016-07-05 Thread Marco Martin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365103 --- Comment #2 from Marco Martin --- I'll do that :) -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/

[Breeze] [Bug 365103] "Icons Tint to Match Highlight" makes icons invisible when "draw a thin line to indicate focus" is activated

2016-07-05 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365103 Kai Uwe Broulik changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[Breeze] [Bug 365103] New: "Icons Tint to Match Highlight" makes icons invisible when "draw a thin line to indicate focus" is activated

2016-07-05 Thread Robby Engelmann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365103 Bug ID: 365103 Summary: "Icons Tint to Match Highlight" makes icons invisible when "draw a thin line to indicate focus" is activated Product: Breeze Version: 5.6.95 Platform: Othe

Re: Review Request 128362: Add unclutter/cascade window actions

2016-07-05 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128362/ --- (Updated July 5, 2016, 1 p.m.) Review request for Plasma. Changes -

[Differential] [Closed] D2086: Restore asynchronous QML object incubation in krunner

2016-07-05 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE0cec97bd9d11: Restore asynchronous QML object incubation in krunner (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabrica

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 235 - Still Unstable!

2016-07-05 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/235/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 05 Jul 2016 12:38:39 + Build duration: 17 min CHANGE SET Revision 0cec97bd9d11a19d55d8abb154f145fe2e

Re: Which applications does the Plasma team recommend to use with Plasma?

2016-07-05 Thread Martin Graesslin
On Tuesday, July 5, 2016 3:51:45 PM CEST R.Harish Navnit wrote: > On Tue, Jul 5, 2016 at 11:36 AM, Martin Graesslin wrote: > > On Monday, July 4, 2016 10:52:12 PM CEST Thomas Pfeiffer wrote: > > > On 04.07.2016 18:37, Martin Gräßlin wrote: > > > > Am 2016-07-04 14:43, schrieb Thomas Pfeiffer: > >

Re: Which applications does the Plasma team recommend to use with Plasma?

2016-07-05 Thread Heiko Becker
> Browser: We do not recommend one at the moment for browser I would turn the recommendation the other way: let's explicitly recommend to not use any of the Qt browsers. >>> >>> I've heard people using e.g. QupZilla as their daily browser and not being >>> unhappy with it.

Re: Which applications does the Plasma team recommend to use with Plasma?

2016-07-05 Thread R.Harish Navnit
On Tue, Jul 5, 2016 at 11:36 AM, Martin Graesslin wrote: > > On Monday, July 4, 2016 10:52:12 PM CEST Thomas Pfeiffer wrote: > > On 04.07.2016 18:37, Martin Gräßlin wrote: > > > Am 2016-07-04 14:43, schrieb Thomas Pfeiffer: > > >> Hi everyone, > > >> every now and then, distributions approach us a

[Powerdevil] [Bug 365100] New: Power button ignored

2016-07-05 Thread Gordan Krešić via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365100 Bug ID: 365100 Summary: Power button ignored Product: Powerdevil Version: 5.6.5 Platform: Kubuntu Packages OS: Linux Status: UNCONFIRMED Severity: normal

[Differential] [Commented On] D2073: Add a KCM setting to control pulse audio module combine-sinks

2016-07-05 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Then it's not technically a virtual device as it shows as "simultaneous output to x, y, and z" in the list. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2073 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Commented On] D2073: Add a KCM setting to control pulse audio module combine-sinks

2016-07-05 Thread drosca (David Rosca)
drosca added a comment. In https://phabricator.kde.org/D2073#38500, @broulik wrote: > Can we perhaps add a special sorting logic so this virtual device always shows at the top of the list? We have something similar to keep the "Notification Sounds" stream always ontop. If this cr

Re: Review Request 128373: re-arrange of the emoticon kcm buttons

2016-07-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128373/#review97122 --- doesn't that many buttons in an horizontal layout risk to eit

Re: Review Request 128375: kcm color preview on top and buttons on bottom.

2016-07-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128375/#review97121 --- Ship it! Ship It! - Marco Martin On July 5, 2016, 1:03

[Differential] [Request, 296 lines] D2091: [server] Properly send a selection clear prior to keyboard focus enter

2016-07-05 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY When setting the keyboard focus the server needs also to send the current selecti

Re: Review Request 128374: solid kcm small change of the entire ux file

2016-07-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128374/#review97120 --- Ship it! Ship It! - Marco Martin On July 5, 2016, 12:21

Re: Which applications does the Plasma team recommend to use with Plasma?

2016-07-05 Thread Marco Martin
On Monday 04 July 2016 18:37:59 Martin Gräßlin wrote: > > File manager: Dolphin > > Music player: Cantata > > I think Cantata is unsuited as it requires an mpd running. Given that > it's out of scope for simple usage. thing is, Cantata is the only Qt based music player i know that has an UI that

Re: Which applications does the Plasma team recommend to use with Plasma?

2016-07-05 Thread Marco Martin
On Tuesday 05 July 2016 07:56:50 Martin Graesslin wrote: > > That's just negative speech, not something we want to be responsible > > for. I'm sure KDE could have a good web browser. > > KDE might be able to have a good web browser. Currently we don't. If we > explicitly recommend software we need

Re: Which applications does the Plasma team recommend to use with Plasma?

2016-07-05 Thread Marco Martin
On Monday 04 July 2016 16:52:09 Jens Reuterberg wrote: > IRC is too uncommon to be "ship by default" and argument i heardfor irc is that distributions still nowdays depends on it for semi-official user support, so most distributions wants it anyways > - Cantata is not relevant enough ugh, are the

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 164 - Fixed!

2016-07-05 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/164/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 05 Jul 2016 07:35:46 + Build duration: 5 min 40 sec CHANGE SET Revision e3dd908601d95ae4ec87350aaed997a

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 164 - Fixed!

2016-07-05 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/164/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 05 Jul 2016 07:35:46 + Build duration: 5 min 40 sec CHANGE SET Revision e3dd908601d95ae4ec87350aaed997a