davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY In new Qt (not sure which version) QIcon::fromTheme(QString) returns a valid icon object, thus hasThemeIcon always returns true as that simply calls fromTheme internally and checks the names match. This patch uses the same check as the new QIcon::fromTheme(QString &name, QIcon fallback) to check the original icon was found. This patch is therefore not only is a workaround but also a speed bost as before we were effectively loading the same icon twice. BUG: 365111 REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2092 AFFECTED FILES components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson Cc: plasma-devel, jensreuterberg, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
