[Differential] [Updated] D1783: [server] Don't assert when destroying a still referenced BufferInterface

2016-06-06 Thread Martin Gräßlin
graesslin added a reviewer: Plasma. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1783 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, #plasma Cc: plasma-devel, sebas ___

[Differential] [Updated] D1783: [server] Don't assert when destroying a still referenced BufferInterface

2016-06-06 Thread Martin Gräßlin
graesslin added a subscriber: plasma-devel. graesslin added a project: Plasma on Wayland. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1783 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc: pl

plasma 5.6.90

2016-06-06 Thread kainz.a
dear plasma developers, I'm searching always to find some improvements in plasma. today I search a long long time, cause plasma 5.6.90 is awesome. really awesome. I did also play a few hours with qml and I have to say, I don't have the time to learn it. Sorry, but this is your turn and I'm happy

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-06-06 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/ --- (Updated June 6, 2016, 10:56 p.m.) Review request for Plasma, KDE Usabili

Re: Proposal: kde-libs.org, a repository of contributed libraries

2016-06-06 Thread Kevin Krammer
On Saturday, 2016-06-04, 15:52:17, kdea wrote: > On Sun May 29 11:17:16 UTC 2016, Kevin Krammer wrote: > > > They suggested me to upload the library to the "Qt Components" section > > > of http://qt-apps.org/ , so I did it, and the library is now available > > > to other developers. > > > > Wouldn

Re: Review Request 128108: update weather applet ui

2016-06-06 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/ --- (Updated June 6, 2016, 8:41 p.m.) Review request for Plasma and Friedrich

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 122 - Still Unstable!

2016-06-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/122/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jun 2016 20:20:34 + Build duration: 17 min CHANGE SET Revision 695d6272149c962d804d0bce051c03f759

Re: Review Request 128108: update weather applet ui

2016-06-06 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/ --- (Updated June 6, 2016, 8:36 p.m.) Review request for Plasma and Friedrich

[Differential] [Commented On] D1350: [Digital Clock] Allow copying current date to clipboard

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Is there a way to force an update of the DataSource data? Since it's 1min aligned the seconds in the menu will always be 0 (or 1 or 59) and I don't see a (public) method to force an update. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://pha

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 121 - Still Unstable!

2016-06-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/121/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jun 2016 20:07:26 + Build duration: 11 min CHANGE SET Revision 92efc6ca6ec3c1c1c34a777c470337d4fd

[Differential] [Closed] D1562: [OSD] Enable wrapping into two lines

2016-06-06 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE695d6272149c: [OSD] Enable wrapping into two lines (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1562?vs=370

[Differential] [Closed] D1781: [Task Manager] Don't show "Move To Desktop" menu when there is just one virtual desktop

2016-06-06 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP2429e5699344: [Task Manager] Don't show "Move To Desktop" menu when there is just one… (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://ph

[Differential] [Closed] D1782: [Task Manager] Fix adding launcher

2016-06-06 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP2c0767395ce9: [Task Manager] Fix adding launcher (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1782?vs=4255&id=425

[Differential] [Closed] D1673: WIP: [Libtaskmanager] Add support for regular expression mapping

2016-06-06 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE92efc6ca6ec3: [Libtaskmanager] Add support for regular expression mapping (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricat

[Differential] [Accepted] D1782: [Task Manager] Fix adding launcher

2016-06-06 Thread hein (Eike Hein)
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Broke while refactoring :) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1782 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

[Differential] [Updated] D1782: [Task Manager] Fix adding launcher

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1782 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein Cc: plasma-devel, sebas _

[Differential] [Request, 2 lines] D1782: [Task Manager] Fix adding launcher

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's requestAddLauncher,

[Differential] [Accepted] D1673: WIP: [Libtaskmanager] Add support for regular expression mapping

2016-06-06 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1673 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, #plasma Cc: plasma

[Differential] [Updated, 53 lines] D1673: WIP: [Libtaskmanager] Add support for regular expression mapping

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 4254. broulik added a comment. - Rebase ontop of new libtaskmanager - was a straight forward port :) Cool side-effect: Chome webapp windows are no longer grouped to other Chrome browser windows, making them behave like real applications. REPOSITORY

[Differential] [Accepted] D1781: [Task Manager] Don't show "Move To Desktop" menu when there is just one virtual desktop

2016-06-06 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1781 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, #plasma Cc: plasma-dev

[Differential] [Request, 7 lines] D1781: [Task Manager] Don't show "Move To Desktop" menu when there is just one virtual desktop

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Right click - no annoying menu

[Differential] [Commented On] D1673: WIP: [Libtaskmanager] Add support for regular expression mapping

2016-06-06 Thread hein (Eike Hein)
hein added a comment. Looks like you forgot to update plasma-desktop. TaskManager::GroupManager is a class from the old libtaskmanager, which was renamed to legacylibtaskmanager in the plasma-workspace changes. So it looks like you're trying to run the old applet against an updated p-w. REP

Re: Review Request 128108: update weather applet ui

2016-06-06 Thread Andreas Kainz
> On Juni 6, 2016, 7:39 vorm., Sebastian Kügler wrote: > > applets/weather/package/contents/ui/TopPanel.qml, line 34 > > > > > > add a spacer Item instead of putting in magical numbers what's a spacer item? - A

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 120 - Still Unstable!

2016-06-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/120/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jun 2016 18:40:40 + Build duration: 9 min 19 sec CHANGE SET Revision a246d0eada390936e9c548b13d6e

[Differential] [Commented On] D1673: WIP: [Libtaskmanager] Add support for regular expression mapping

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Will do, once I figure out what I forgot to update: plasmashell: symbol lookup error: /usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/private/taskmanager/libtaskmanagerplugin.so: undefined symbol: _ZN11TaskManager12GroupManagerC1EP7QObject :) REPOSITORY rPLASMAWO

[Differential] [Requested Changes To] D1673: WIP: [Libtaskmanager] Add support for regular expression mapping

2016-06-06 Thread hein (Eike Hein)
hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. Kai, could you rebase this against the new lib? The heuristic is in XWindowsTasksModel now. It's the one slice of code still similar to the old lib so it shouldn't be much work. REPO

[Differential] [Commented On] D1706: [Switch Window Containment Action] Fix listing windows with just one virtual desktop

2016-06-06 Thread hein (Eike Hein)
hein added a comment. > Sho_: https://phabricator.kde.org/D1706 is this still an issue with the new lib (the applet needs to be adjusted to use the new lib?) Yes, this code stil uses the old lib. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.o

[Differential] [Closed] D1774: Save code by using newly-added KActivities::Consumer signal.

2016-06-06 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEa246d0eada39: Save code by using newly-added KActivities::Consumer signal. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

2016-06-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/119/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jun 2016 18:02:40 + Build duration: 10 min CHANGE SET Revision b22a742395fba4c6428743db4845dd4d67

Re: Review Request 124509: Use small button for session combo

2016-06-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124509/ --- (Updated Juni 6, 2016, 6:04 nachm.) Status -- This change has been d

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 118 - Still Unstable!

2016-06-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jun 2016 17:53:08 + Build duration: 9 min 17 sec CHANGE SET Revision 83eacf74ce6aba414a697747f3f2

[Differential] [Closed] D1635: [OSD] Make volume OSD thresholds consistent with Volume Applet

2016-06-06 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEad36c6dba6a7: [OSD] Make volume OSD thresholds consistent with Volume Applet (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabri

[Differential] [Closed] D1765: [KRunner] Disable high dpi scaling

2016-06-06 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb22a742395fb: [KRunner] Disable high-dpi scaling (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1765?vs=4205&

[Differential] [Closed] D1769: [Service Runner] Don't use KRun::runService

2016-06-06 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE83eacf74ce6a: [Service Runner] Don't use KRun::runService (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1769?vs=4246&id=4247#toc REPOSITORY rPLASMAWORKSPAC

Jenkins-kde-ci: kde-gtk-config 2.2 stable-qt4 » Linux,gcc - Build # 1 - Unstable!

2016-06-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kde-gtk-config%202.2%20stable-qt4/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jun 2016 17:27:58 + Build duration: 52 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kde-gtk-config 2.2 latest-qt4 » Linux,gcc - Build # 1 - Unstable!

2016-06-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kde-gtk-config%202.2%20latest-qt4/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jun 2016 17:27:58 + Build duration: 55 sec CHANGE SET No changes JUNIT RESULTS Name: (root

[Differential] [Accepted] D1769: [Service Runner] Don't use KRun::runService

2016-06-06 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1769 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Updated, 2 lines] D1769: [Service Runner] Don't use KRun::runService

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 4246. broulik added a comment. Use "new KRun" REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1769?vs=4211&id=4246 REVISION DETAIL https://phabricator.kde.org/D1769 AFFECTED FILES runners/servi

[Differential] [Updated] D1779: Add a parent_window event to Plasma Window interface

2016-06-06 Thread Martin Gräßlin
graesslin edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1779 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, hein Cc: plasma-devel, seba

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

2016-06-06 Thread Marco Martin
> On June 5, 2016, 2:59 p.m., Anthony Fieroni wrote: > > Ping? the issues have not been adressed - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/#review96206 -

[Differential] [Updated] D1780: Expose the transientFor relationship to PlasmaWindowInterface

2016-06-06 Thread Martin Gräßlin
graesslin edited projects, added KWin, Plasma on Wayland; removed Plasma. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1780 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, hein Cc: plasma-devel,

[Differential] [Updated] D1780: Expose the transientFor relationship to PlasmaWindowInterface

2016-06-06 Thread Martin Gräßlin
graesslin edited projects, added Plasma; removed Plasma on Wayland, KWin. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1780 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, hein Cc: plasma-devel,

[Differential] [Updated] D1780: Expose the transientFor relationship to PlasmaWindowInterface

2016-06-06 Thread Martin Gräßlin
graesslin edited projects, added KWin, Plasma on Wayland; removed Plasma. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1780 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, hein Cc: plasma-devel,

[Differential] [Updated] D1779: Add a parent_window event to Plasma Window interface

2016-06-06 Thread Martin Gräßlin
graesslin added a dependent revision: D1780: Expose the transientFor relationship to PlasmaWindowInterface. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1779 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasm

[Differential] [Updated] D1780: Expose the transientFor relationship to PlasmaWindowInterface

2016-06-06 Thread Martin Gräßlin
graesslin added a dependency: D1779: Add a parent_window event to Plasma Window interface. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1780 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, hein

[Differential] [Request, 171 lines] D1779: Add a parent_window event to Plasma Window interface

2016-06-06 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma on Wayland, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change adds a parent_window event to Plasma Window. From server side it's possible

Re: Review Request 128109: Provide demo/preview for checkable menu items too [WIP]

2016-06-06 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128109/ --- (Updated June 6, 2016, 2:08 p.m.) Review request for Plasma. Changes --

[Differential] [Updated] D1778: [PanelConfigView] Set enabled borders on PanelShadow

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1778 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, sebas _

[Differential] [Request, 39 lines] D1778: [PanelConfigView] Set enabled borders on PanelShadow

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes the panel conf

Re: Review Request 128109: Provide demo/preview for checkable menu items too [WIP]

2016-06-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128109/#review96221 --- Can you provide a screenshot? - Kai Uwe Broulik On Juni 6,

Review Request 128109: Provide demo/preview for checkable menu items too [WIP]

2016-06-06 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128109/ --- Review request for Plasma. Repository: oxygen Description --- It's

[Differential] [Accepted] D1774: Save code by using newly-added KActivities::Consumer signal.

2016-06-06 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1774 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein,

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 117 - Still Unstable!

2016-06-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/117/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jun 2016 10:55:34 + Build duration: 25 min CHANGE SET Revision 939521a905389f5dcdc58f9adeee5f4ea3

[Powerdevil] [Bug 364019] New: Screen is flickering when setting brightness while in Kodi

2016-06-06 Thread Côme Chilliet via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364019 Bug ID: 364019 Summary: Screen is flickering when setting brightness while in Kodi Product: Powerdevil Version: 5.6.4 Platform: Archlinux Packages OS: Linux

[Differential] [Closed] D1773: Introduce an initial state event into Plasma Window protocol

2016-06-06 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDc4a4c998e42e: Introduce an initial state event into Plasma Window protocol (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1773?vs

[Differential] [Updated, 73 lines] D1757: [Panel] Reduce duplicate enabled borders calculation

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 4233. broulik added a comment. - It's panel.enabledBorders, not containment - Remove onPrefixChanged handler REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1757?vs=4189&id=4233 REVISION DETAIL http

[Differential] [Request, 48 lines] D1774: Save code by using newly-added KActivities::Consumer signal.

2016-06-06 Thread hein (Eike Hein)
hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1774 AFFECTED FILES li

[Differential] [Accepted] D1773: Introduce an initial state event into Plasma Window protocol

2016-06-06 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH plasma-window-initial-state REVISION DETAIL https://phabricator.kde.org/D1773 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

[Differential] [Request, 200 lines] D1773: Introduce an initial state event into Plasma Window protocol

2016-06-06 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The event is sent to the client once all initial state is transmitted. This means the client is ab

[Differential] [Request, 199 lines] D1772: Port custom collasablebutton to KWidgetAddons::KCollapsibleGroupBox

2016-06-06 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Saves duplicating code using a shared implementation. REPOSITORY rKSCREEN KScreen BRANCH

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > mart wrote in Panel.qml:32 > perhaps as a property of the view could work Ah yeah, it's not on containment, I put it on panel. yay for testing my patches :D REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.or

[Differential] [Commented On] D1770: [OSD] Allow disabling OSD through config file

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik added a comment. See https://phabricator.kde.org/D1771 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1770 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: mart, graesslin, plasma

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 116 - Still unstable!

2016-06-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/116/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jun 2016 08:06:59 + Build duration: 21 min CHANGE SET Revision 8fd9770b50ecc069adda4f5e3f79cf2c98

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik added a comment. See https://phabricator.kde.org/D1771 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, graesslin Cc:

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

2016-06-06 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. @mart See https://phabricator.kde.org/D1756 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1757 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson, m

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

2016-06-06 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > mart wrote in Panel.qml:32 > there is no enabledborders property in containment? (neither i want such a > property, is not the right place) perhaps as a property of the view could work REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL h

[Differential] [Requested Changes To] D1757: [Panel] Reduce duplicate enabled borders calculation

2016-06-06 Thread mart (Marco Martin)
mart requested changes to this revision. mart added a reviewer: mart. This revision now requires changes to proceed. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1757 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

2016-06-06 Thread mart (Marco Martin)
mart added a comment. I don't understand what the patch is supposed to be doing.. the enabled bprders of the svg can be calculated only based on the location of the panel, that has been completely removed INLINE COMMENTS > broulik wrote in Panel.qml:29 > Dunno if we still need this, ie. if

[Differential] [Accepted] D1757: [Panel] Reduce duplicate enabled borders calculation

2016-06-06 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > broulik wrote in Panel.qml:29 > Dunno if we still need this, ie. if we need a way to signal this back to

[Differential] [Accepted] D1756: [PanelView] Expose enabled borders as property and also forward it to PanelShadows

2016-06-06 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1756 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 91 - Still Failing!

2016-06-06 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/91/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jun 2016 08:10:18 + Build duration: 4 min 36 sec CHANGE SET Revision 3d5d15a76d5f4492455ed9a1b9fa1cee

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

2016-06-06 Thread hein (Eike Hein)
hein added a comment. In https://phabricator.kde.org/D1722#32995, @shumski wrote: > Plasma addons don't build against this change: > > /home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.6.90git~20160524T120553~7d85a2c/applets/activitypager/plugin/activitypager.cpp:53:30: fatal error: t

[Differential] [Commented On] D1770: [OSD] Allow disabling OSD through config file

2016-06-06 Thread mart (Marco Martin)
mart added a comment. this configuration is intended for kiosk setups? if it's hidden, there is always the risk of bitrot REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1770 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/ema

[Differential] [Commented On] D1768: Pass screen ID to systray applets

2016-06-06 Thread mart (Marco Martin)
mart added a comment. yeah, i'm not happy that the screen is not passed. I'm not sure i like this approach completely (if the panel gets moved to another screen the internal screen won't be updated?), but i didn't manage to think about a viable way to pass the screen without making the syst

[Differential] [Accepted] D1768: Pass screen ID to systray applets

2016-06-06 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. yeah, i'm not happy that the screen is not passed. I'm not sure i like this approach completely (if the panel gets moved to another screen the internal screen won'

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 90 - Failure!

2016-06-06 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/90/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jun 2016 07:46:09 + Build duration: 1 min 41 sec CHANGE SET Revision 2e3d7c5c5726827f2f82490c7f0ab566

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

2016-06-06 Thread shumski (Hrvoje Senjan)
shumski added a comment. Plasma addons don't build against this change: /home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.6.90git~20160524T120553~https://phabricator.kde.org/rKDEPLASMAADDONS7d85a2cf3c6c968a41ab30425c62b2f058408a3e/applets/activitypager/plugin/activitypager.cpp:53:30: fatal er

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 115 - Failure!

2016-06-06 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/115/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jun 2016 07:44:13 + Build duration: 1 min 4 sec CHANGE SET Revision 8f3f5ee25b4de4694ea4f11599c0af

[Differential] [Closed] D1738: [startkde] Set QT_WAYLAND_FORCE_DPI from startplasmacompositor

2016-06-06 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE5f9663e0c1ec: [startkde] Set QT_WAYLAND_FORCE_DPI from startplasmacompositor (authored by graesslin). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phab

[Differential] [Accepted] D1765: [KRunner] Disable high dpi scaling

2016-06-06 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. > but also the TextField sizing is completely broken because Plasma Components don't handle Qt scaling well. Ship it!

[Differential] [Closed] D1723: Rename Task Manager applets out of the way of rewrites.

2016-06-06 Thread hein (Eike Hein)
hein closed this revision. hein added a comment. Closed by https://phabricator.kde.org/rPLASMADESKTOP2e3d7c5c5726827f2f82490c7f0ab566205a5522. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1723 EMAIL PREFERENCES https://phabricator.kde.org/setti

[Differential] [Commented On] D1769: [Service Runner] Don't use KRun::runService

2016-06-06 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. This now matches what Icon is doing, but Kicker is using: new KRun(QUrl::fromLocalFile(service->entryPath()), 0, true, ...); This puts the kservice parsing into being done by klauncher/kinit which seems more "right". Does using ->exec() skip the K

[Differential] [Closed] D1724: Import Task Manager widgets ports to the new library.

2016-06-06 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP3d5d15a76d5f: Import Task Manager widgets ports to the new library. (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D172

[Differential] [Closed] D1722: Import next-gen libtaskmanager.

2016-06-06 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE8fd9770b50ec: Import next-gen libtaskmanager. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1722?vs=4226&id=422

[Differential] [Closed] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

2016-06-06 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE8f3f5ee25b4d: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1721?vs=4082&id=4227#toc REPO

[Differential] [Commented On] D1769: [Service Runner] Don't use KRun::runService

2016-06-06 Thread apol (Aleix Pol Gonzalez)
apol added a comment. Would it make sense to add such API in KRun@KIOWidgets? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1769 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: apol, pl

[Differential] [Accepted] D1722: Import next-gen libtaskmanager.

2016-06-06 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH importlibtmng REVISION DETAIL https://phabricator.kde.org/D1722 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein

[Differential] [Accepted] D1722: Import next-gen libtaskmanager.

2016-06-06 Thread lbeltrame (Luca Beltrame)
lbeltrame accepted this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1722 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, graesslin, #plasma, davidedmundson, lbeltrame Cc: lbeltrame, graesslin,

Re: Review Request 128108: update weather applet ui

2016-06-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/#review96217 --- applets/weather/package/contents/ui/TopPanel.qml (line 34) <

[Differential] [Accepted] D1722: Import next-gen libtaskmanager.

2016-06-06 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1722 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, graesslin, lbeltrame, #plasma, davidedmundson Cc: lbeltrame, graes

Re: Review Request 128108: update weather applet ui

2016-06-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/#review96215 --- applets/weather/package/contents/ui/WeatherListView.qml (lin

[Differential] [Accepted] D1724: Import Task Manager widgets ports to the new library.

2016-06-06 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH importtmng REVISION DETAIL https://phabricator.kde.org/D1724 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Commented On] D1724: Import Task Manager widgets ports to the new library.

2016-06-06 Thread hein (Eike Hein)
hein added a comment. In https://phabricator.kde.org/D1724#32754, @lbeltrame wrote: > Second multiscreen issue found: right clicking to get the menu from a task gets the task in the wrong screen. Screenshot attached (left: screen 1, right: screen 2). > > F142172: Screenshot_20160603_

[Differential] [Commented On] D1724: Import Task Manager widgets ports to the new library.

2016-06-06 Thread hein (Eike Hein)
hein added a comment. In https://phabricator.kde.org/D1724#32773, @lbeltrame wrote: > Tested it on a single screen system. No issues with context menus. Notice: I don't see jump lists with the new task manager, should I see them? Yes, you should: F143583: Screenshot_20160606_

[Differential] [Updated, 9,403 lines] D1722: Import next-gen libtaskmanager.

2016-06-06 Thread hein (Eike Hein)
hein updated this revision to Diff 4226. hein added a comment. Evict window info cache on WMGeometry changes. This fixes stale data being returned for AbstractTasksModel::Screen. Should fix Luca's bug mentioned in https://phabricator.kde.org/D1724. REPOSITORY rPLASMAWORKSPACE Plasm

[Differential] [Commented On] D1724: Import Task Manager widgets ports to the new library.

2016-06-06 Thread hein (Eike Hein)
hein added a comment. > Not sure if it's in libtm or in the applets: but if you move a window to another screen, the corresponding task will not get updated until I minimize the task. This is a cache eviction issue in the library. I'll update https://phabricator.kde.org/D1722 with the n