----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/#review96217 -----------------------------------------------------------
applets/weather/package/contents/ui/TopPanel.qml (line 34) <https://git.reviewboard.kde.org/r/128108/#comment65022> add a spacer Item instead of putting in magical numbers applets/weather/package/contents/ui/WeatherListView.qml (line 39) <https://git.reviewboard.kde.org/r/128108/#comment65021> the alpha argument equates to zero, no reason to write ((index+1)/repeater.count)*0 ... applets/weather/package/contents/ui/main.qml (line 117) <https://git.reviewboard.kde.org/r/128108/#comment65020> units.Spacing is not a thing, this throws a reference error (and will set the margin to zero, the default). Just killing these lines will have the same effect. - Sebastian Kügler On June 6, 2016, 6:48 a.m., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128108/ > ----------------------------------------------------------- > > (Updated June 6, 2016, 6:48 a.m.) > > > Review request for Plasma and Friedrich W. H. Kossebau. > > > Repository: kdeplasma-addons > > > Description > ------- > > the scaling work now better and the pading between the single lines can be > smaler (If you make the applet higher you can also have the old line spacing) > > it's my first qml change, so ... > > on my todo, I'd like to change the powerd by weather.com text color so a > secondary gray (bring it a bit more to the background), but I don't know how. > > > Diffs > ----- > > applets/weather/package/contents/ui/TopPanel.qml 1821f16 > applets/weather/package/contents/ui/WeatherListView.qml c7b331e > applets/weather/package/contents/ui/main.qml d490728 > > Diff: https://git.reviewboard.kde.org/r/128108/diff/ > > > Testing > ------- > > with breeze and breeze dark color scheme on two different pc's. the icons are > breeze weather icons (master) > > > File Attachments > ---------------- > > screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png > > > Thanks, > > Andreas Kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
