[Differential] [Closed] D1726: Introduce a test server

graesslin closed this revision. graesslin added a comment. pushed with https://phabricator.kde.org/rKWAYLAND37f7cb99535d8fdcfc16ad99c045bddb67798b45 - seems to not have been picked up as I added a changelog entry. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org

[Differential] [Commented On] D1742: Make udev seriously mandatory

graesslin added a comment. @broulik: why is udev mandatory? It's not supported by BSDs and in KWin it's optional due to that. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1742 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Request, 82 lines] D1742: Make udev seriously mandatory

bshah created this revision. bshah added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY https://phabricator.kde.org/rPOWERDEVIL73e13daef13d38948b1194d2d1103404fdd808b7 done just half work of

[Differential] [Changed Subscribers] D1735: Notify about low peripheral batteries (mouse, keyboard)

graesslin added inline comments. INLINE COMMENTS > PowerDevilSettings.kcfg:35 > + > + 10 > + Given the experience with my trackball: I think I used it for another half year once it dropped below 10 % > powerdevilcore.cpp:508 > +msg = i18n("The battery in your keybo

[Breeze] [Bug 349411] Horizontal and vertical task buttons should have consistent margin sizes

https://bugs.kde.org/show_bug.cgi?id=349411 Eike Hein changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

[Differential] [Accepted] D1738: [startkde] Set QT_WAYLAND_FORCE_DPI from startplasmacompositor

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH force-dpi-startplasmacompositor REVISION DETAIL https://phabricator.kde.org/D1738 EMAIL PREFERENCES https://phabricator.kde.o

[Differential] [Accepted] D1732: [Kickoff] Use a single MouseArea for opening user manager

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1732 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broul

[Differential] [Closed] D1691: kfontinst: Port to Qt widget classes

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPd0ac79bae59a: kfontinst: Port to Qt widget classes (authored by volkov). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1691?vs=4011&id=41

[Differential] [Closed] D1692: kfontinst: Port away from Kdelibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPc2944ed823ad: kfontinst: Port away from Kdelibs4Support (authored by volkov). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1692?vs=4012&

[Differential] [Request, 4 lines] D1738: [startkde] Set QT_WAYLAND_FORCE_DPI from startplasmacompositor

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change makes the force DPI combobox in fonts kcm work in a Wayland session for QtWayland applicati

[Differential] [Commented On] D1691: kfontinst: Port to Qt widget classes

volkov added a comment. Thanks. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1691 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov, #plasma, graesslin Cc: graesslin, plasma-devel, sebas _

[Differential] [Request, 10 lines] D1737: [Desktop Containment] Remove debug elements

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Some of them were even needles

Re: Review Request 128074: [libkscreen] [Backend Manager] emitBackendReady() only after fetching the config finishes

> On June 1, 2016, 2:19 p.m., Sebastian Kügler wrote: > > I've gone over the handlers for backendReady, and none of them is actually > > used to request a config then (that's encapsulated in backendmanager), so > > requesting a config before the backend is announced ready makes sense. > > Kai

[Differential] [Closed] D1730: address race condition around setoperation

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN17199d32f292: address race condition around setoperation (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1730?vs=4136&id=4137 REVISION D

[Differential] [Closed] D1736: Use QObject's parent to memory-manage the timers

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN13a03dc11bb0: Use QObject's parent to memory-manage the timers (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1736?vs=4139&id=4140 REVI

[Differential] [Closed] D1727: Add a test case for KIdleTime

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDINTEGRATION3fa0d000a2a1: Add a test case for KIdleTime (authored by graesslin). REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://p

[Differential] [Commented On] D1736: Use QObject's parent to memory-manage the timers

graesslin added a comment. As I cannot accept again: ShipIt REPOSITORY rKSCREEN KScreen BRANCH sebas/timer-parenting REVISION DETAIL https://phabricator.kde.org/D1736 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, graesslin Cc: plasma-deve

[Differential] [Updated, 16 lines] D1736: Use QObject's parent to memory-manage the timers

sebas updated this revision to Diff 4139. sebas added a comment. - Use QScopedPointer for the elapsed timer REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1736?vs=4138&id=4139 BRANCH sebas/timer-parenting REVISION DETAIL https://phabricator.kde.or

[Differential] [Request, 12 lines] D1736: Use QObject's parent to memory-manage the timers

sebas created this revision. sebas added a reviewer: graesslin. sebas added a subscriber: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use QObject's memory management tricks by parenting the timers. TEST PLAN

[Differential] [Accepted] D1736: Use QObject's parent to memory-manage the timers

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH sebas/timer-parenting REVISION DETAIL https://phabricator.kde.org/D1736 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, graess

[Differential] [Accepted] D1730: address race condition around setoperation

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH sebas/setop-race REVISION DETAIL https://phabricator.kde.org/D1730 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, graesslin C

[Differential] [Updated, 15 lines] D1730: address race condition around setoperation

sebas updated this revision to Diff 4136. sebas added a comment. - --debug and invalidate REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1730?vs=4135&id=4136 BRANCH sebas/setop-race REVISION DETAIL https://phabricator.kde.org/D1730 AFFECTED FILES

[Differential] [Requested Changes To] D1730: address race condition around setoperation

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > daemon.cpp:190 > { > +qCDebug(KSCREEN_KDED) << "QET" << m_changeBlockTimer->isValid() << > m_changeBlockTimer->hasExpired(100) << m_changeBlockTime

[Differential] [Request, 231 lines] D1735: Notify about low peripheral batteries (mouse, keyboard)When the battery in a non-power supply battery drops below 10% (configurable)a notification is shown t

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ...Initial support for peripheral battery notifications When the battery in a non-power supply battery d

[Differential] [Updated, 15 lines] D1730: address race condition around setoperation

sebas updated this revision to Diff 4135. sebas added a comment. - Use QElapsedTimer instead of QTimer REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1730?vs=4103&id=4135 BRANCH sebas/setop-race REVISION DETAIL https://phabricator.kde.org/D1730 A

Re: Review Request 128074: [libkscreen] [Backend Manager] emitBackendReady() only after fetching the config finishes

> On Juni 1, 2016, 2:19 nachm., Sebastian Kügler wrote: > > I've gone over the handlers for backendReady, and none of them is actually > > used to request a config then (that's encapsulated in backendmanager), so > > requesting a config before the backend is announced ready makes sense. 5.6 or

[Differential] [Updated] D1735: Notify about low peripheral batteries (mouse, keyboard)

broulik updated the summary for this revision. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1735 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: plasma-devel, sebas _

[Differential] [Commented On] D1735: Notify about low peripheral batteries (mouse, keyboard)

broulik added a comment. F139915: Screenshot_20160601_154635.png F139917: Screenshot_20160601_155244.png REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1735 EMAIL PREFERENCES

Re: Review Request 128074: [libkscreen] [Backend Manager] emitBackendReady() only after fetching the config finishes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128074/#review96138 --- Ship it! I've gone over the handlers for backendReady, and

[Differential] [Updated] D1735: Notify about low peripheral batteries (mouse, keyboard)

broulik retitled this revision from "Notify about low peripheral batteries (mouse, keyboard) When the battery in a non-power supply battery drops below 10% (configurable) a notification is shown to the user so he or she is not surprised when the device suddenly stops working. ===..." to "Notify

[Breeze] [Bug 349411] Horizontal and vertical task buttons should have consistent margin sizes

https://bugs.kde.org/show_bug.cgi?id=349411 --- Comment #8 from apache --- It's a long time since last comment - almost a year. Can we expect some changes any time soon? Icons on panel on task manager are ridiculously small in relation to panel size. Not only in active task but in launchers as w

[Differential] [Closed] D1734: [server] Properly handle the case that a PlasmaWindow is unmapped before client bound it

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDb1bbb908114f: [server] Properly handle the case that a PlasmaWindow is unmapped before… (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde

[Differential] [Commented On] D1726: Introduce a test server

sebas added a comment. Changes look good. REPOSITORY rKWAYLAND KWayland BRANCH test-server REVISION DETAIL https://phabricator.kde.org/D1726 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, sebas, #plasma, bshah Cc: sebas, bshah, plasma-

[Differential] [Accepted] D1691: kfontinst: Port to Qt widget classes

graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. sorry that you had to ping. I guess nobody is really familiar with the code. The change looks good to me and makes sense, so I give you the S

[Differential] [Accepted] D1734: [server] Properly handle the case that a PlasmaWindow is unmapped before client bound it

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH plasma-window-destroy REVISION DETAIL https://phabricator.kde.org/D1734 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

[Differential] [Request, 42 lines] D1734: [server] Properly handle the case that a PlasmaWindow is unmapped before client bound it

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY So far we directly destroyed the resource on the server side. But this causes a wayland error when the

Review Request 128074: [libkscreen] [Backend Manager] emitBackendReady() only after fetching the config finishes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128074/ --- Review request for Plasma, Daniel Vrátil and Sebastian Kügler. Repository

[Differential] [Commented On] D1691: kfontinst: Port to Qt widget classes

volkov added a comment. ping REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1691 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov, #plasma Cc: plasma-devel, sebas __

Re: Review Request 128073: Make Wayland optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128073/#review96137 --- Speaking with the maintainer's hat on: I don't want this. He

[Differential] [Commented On] D1724: Import Task Manager widgets ports to the new library.

hein added inline comments. INLINE COMMENTS > mart wrote in Task.qml:203 > maybe using an inline Component{} ? Leaving that to Kai (this is not new code, and his) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1724 EMAIL PREFERENCES https://phabric

[Differential] [Changed Subscribers] D1724: Import Task Manager widgets ports to the new library.

mart added inline comments. INLINE COMMENTS > Task.qml:203 > +var smartLauncher = Qt.createQmlObject(" > +import org.kde.plasma.private.taskmanager 0.1 as TaskManagerApplet; > +TaskManagerApplet.SmartLauncherItem { }", task); maybe using an inline Component{} ? REPOSITORY

[Differential] [Commented On] D1732: [Kickoff] Use a single MouseArea for opening user manager

broulik added a comment. Probably better put that in 5.6.5 branch and then resolve the conflict by adding the new in 5.7 visible: KCMShell.authorize("user_manager.desktop").length > 0 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1732 EMAIL

[Differential] [Request, 25 lines] D1732: [Kickoff] Use a single MouseArea for opening user manager

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Avoid code duplication which h

Re: Review Request 128073: Make Wayland optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128073/#review96135 --- Just to be clear: by doing the review, I do not change my min

Re: Review Request 128073: Make Wayland optional

> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with > non-Linux platforms; considering

[Differential] [Accepted] D1723: Rename Task Manager applets out of the way of rewrites.

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. that should go in asap REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1723 EMAIL PREFERENCES https://

Re: Review Request 128073: Make Wayland optional

> On June 1, 2016, 8:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with > non-Linux platforms; considering l

[Differential] [Commented On] D1706: [Switch Window Containment Action] Fix listing windows with just one virtual desktop

mart added a comment. there was an inconsistency at some point between the applet counting from 0 and x counting from 1 iirc, and nowdays *should* be possible to remove that if (KWindowSystem::numberOfDesktops() < 2) { code? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL h

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/ --- (Updated June 1, 2016, 9:45 a.m.) Status -- This change has been mar

Re: Review Request 128073: Make Wayland optional

> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with > non-Linux platforms; considering

Re: Review Request 128070: Update mouse kcm docbook to 5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128070/#review96131 --- Looks good to me, but let's have others also a look on it. B

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/#review96130 --- Ship it! Ship It! - David Edmundson On Nov. 23, 2015, 9

Re: Review Request 128073: Make Wayland optional

On Wednesday 01 June 2016 09:08:48 Pino Toscano wrote: > > Bhushan Shah wrote: > > https://mail.kde.org/pipermail/release-team/2015-July/008725.html > > > > https://mail.kde.org/pipermail/kde-distro-packagers/2015-July/76.html > > https://mail.kde.org/pipermail/release-team/2015-July/00872

Re: Review Request 128070: Update mouse kcm docbook to 5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128070/ --- (Updated Juni 1, 2016, 9:22 vorm.) Review request for Documentation and P

Re: Review Request 128073: Make Wayland optional

> On June 1, 2016, 8:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with > non-Linux platforms; considering l

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

hein marked an inline comment as done. hein added inline comments. INLINE COMMENTS > hein wrote in xwindowtasksmodel.cpp:756 > Actually not done -- I'll ask you later about this. Done now. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1722 EMAIL

[Differential] [Updated, 9,271 lines] D1722: Import next-gen libtaskmanager.

hein updated this revision to Diff 4128. hein added a comment. Make QByteArray snippet shorter. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1722?vs=4123&id=4128 BRANCH importlibtmng REVISION DETAIL https://phabricator.kde.org/D

Re: Review Request 128073: Make Wayland optional

> On June 1, 2016, 1:43 p.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with > non-Linux platforms; considering l

Re: Review Request 128073: Make Wayland optional

> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with > non-Linux platforms; considering

Re: Review Request 128073: Make Wayland optional

> On June 1, 2016, 8:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with > non-Linux platforms; considering l

Re: Review Request 128073: Make Wayland optional

> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with > non-Linux platforms; considering

Re: Review Request 128073: Make Wayland optional

> On June 1, 2016, 8:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. Nowhere there is discussed (only briefly mentioned) about support with non-Linux platforms; considering libkscreen is a library used by c

Re: Review Request 128073: Make Wayland optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128073/#review96120 --- -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for

Review Request 128073: Make Wayland optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128073/ --- Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and Sebast

Re: Review Request 128070: Update mouse kcm docbook to 5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128070/#review96118 --- doc/kcontrol/mouse/index.docbook (lines 152 - 157)

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

graesslin added inline comments. INLINE COMMENTS > broulik wrote in main_wayland.cpp:449 > That dialog is a separate binary kwin_rules_dialog. Except for the virtual > keyboard and wayland debug console I don't think there are any user-facing > kwin-internal windows (that are real windows, not

[Differential] [Requested Changes To] D1730: address race condition around setoperation

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Given that you don't connect to the timer at all, I think the usage of QTimer is wrong here. QElapsedTimer seems like the better choice here. The main change would be in

[Differential] [Requested Changes To] D1231: Add Krfb interface to KWayland

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Overall I would also like to see autotests for it similar to the tests for other interfaces. INLINE COMMENTS > remote_access_interface.cpp:146-149 > +if (bound) { > +